* make SimplifyNameEachItemDelay zero

* QuickParse.GetPartialLongNameEx returns pos of the last dot in long ident which is used father in GetDeclaredItems to determine the RHL type

* refactoring

* fix QuickParse

* move QuickParse to FSharp.Compiler.Private project

* add QuickParse to all projects which need it

* fix QuickParse

* add a test

* fix QuickParse

* xml docs

* embed colAtEndOfNamesAndResidue into PartialLongName

* revert unrelated change

* Generate source for .resx files on build. (#3607)

* add build task to generate *.fs from *.resx files

* generate source for embedded resources in tests

* generate source for embedded resources in FSharp.Editor

* generate source for embedded resources in FSharp.LanguageService

* generate source for embedded resources in FSharp.ProjectSystem.FSharp

* generate source for embedded resources in FSharp.VS.FSI

* don't generate non-string resources when <=netstandard1.6

* update baseline error message for tests

The error output should be the exception message, not the exception type.

* perform up-to-date check before generating *.fs from *.resx

* remove non-idiomatic fold for an array comprehension

* correct newline replacement

* output more friendly error message

* throw if boolean value isn't explicitly `true` or `false`

* only generate object resource code on non `netstandard1.*` and `netcoreapp1.*` platforms

* ensure FSharp.Core specifies a target framework for resource generaton

* rename attributes to be non-ambiguous and properly include them

* fix order of file items in FSharp.Core

* Fix build.cmd for certain always-shown errors (like "unable to find registry key"), improve finding of VS2017 tools, fix DEVGUIDE.md (#3635)

* Fix build.com displaying the following error on each run "ERROR: The system was unable to find the specified registry key or value."

* Remove warning about reg.exe errors introduced in #3614 (in commit b548bd7, but unrelated to that fix), it is no longer necessary.

* Fix #3638, VS2017 Preview installation was not found when VS2017RTM is not installed. Remove comment introduced in #3614 (through commit 966bd7f7)

* Fixing JaroWinkler tests with InvariantCulture and fixing async tests by removing Debugger.Break() (#3627)

* Fixing JaroWinkler tests to use InvariantCulture for number-to-string

* Fixing the crashing of test runners because of a Debugger.Break() in a test

* update to System.Collections.Immutable 1.3.1 (#3641)

* update to System.Collections.Immutable 1.3.1

* fixes

* fix assembly reference

* [WIP] Adds optimized emit for int64 constants (#3620)

* Adds optimized emit for int64 constants.

* Adds comment linking to the changing PR.

Thanks for this PR.

Kevin

* fix assembly reference (#3646)

* Remove a few more build warnings (#3647)

* fix assembly reference

* remove more build warnings

* fix build

* move BuildFromSource projects to their own directory

* Adds tests for emitted IL for new Int64 constants. (#3650)

* Enable FS as prefix and ignore invalid values for warnings (#3631)

* enable fs as prefix and ignore invalid values for warnings + tests

* Allow #pragma to validate warnings

* do it right

* use ordinal compare

* In both places

* Add fs prefix to warnaserror

* Fixup tests

* Fix stack overflow on assembly resolution (#3658)

* Fix stack overflow on tp assembly resolution

* Feedback

* Add impl files to file check results (#3659)

* add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project

* add ImplementationFiles to FSharpCheckFileResults

* make FSharpImplementationFileContents ctor internal

* throw if ImplementationFiles is called having keepAssemblyContents flag set to false

* add a test

* spelling and cosmetics

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd (#3672)

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd

* Remove ambiguous an irrelevant instruction, improved help and instructions

* Fix a scenario where the return code wasn't nonzero for error conditions, fixes not creating backup dir when not backing up

* add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project (#3657)

* bump FCS version (#3676)

* bump version

* Update RELEASE_NOTES.md

* Parsing improvements: no reactor, add parsing options, error severity options (#3601)

* Parse without reactor, add parsing options, error severity options

* Revert parsing APIs (fallback to the new ones), fix VFT projects

* Cache parse results after type check

* Add impl files to file check results (#3659)

* add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project

* add ImplementationFiles to FSharpCheckFileResults

* make FSharpImplementationFileContents ctor internal

* throw if ImplementationFiles is called having keepAssemblyContents flag set to false

* add a test

* spelling and cosmetics

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd (#3672)

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd

* This adds backup, restore, coloration and many more checks to the update-vsintegration.cmd

* Remove ambiguous an irrelevant instruction, improved help and instructions

* Fix a scenario where the return code wasn't nonzero for error conditions, fixes not creating backup dir when not backing up

* add LanguageServiceProfiling project to internals visible to list of FSharp.Compiler.Private project (#3657)

* bump FCS version (#3676)

* bump version

* Update RELEASE_NOTES.md

* updates to make tests pass

* restore old behaviour of CheckFileInProjectAllowingStaleCachedResults (builder had been created by ParseFileInProject)

* restore use of CheckFileInProjectAllowingStaleCachedResults

* deprecate test relying on whacky behaviour of deprecated GetCheckResultsBeforeFileInProjectEvenIfStale

* Use ParseFile and FSharpParsingOptions instead of ParseFileInProject

* prepare FCS release with this feature

* whitespace cleanup (#3682)

* whitespace and docs (#3684)

* Preserve XML docs for in-memory project references (#3683)

* fix xmldocs for in-memory project references

* add test

* fix tests

* whitespace and comments (#3686)

* fix assembly reference

* whitespace and comments

* whitespace and comments

* whitespace and comments

* cherry pick two PRs from FCS (#3687)

* fix assembly reference

* remove line endings from all *.nuspec files

* ProjectCracker returns *.fsi files in FSharpProjectOptions.SourceFiles array (in addition to *.fs files, in right order)

* ProjectCracker raises exception if ProjectCrackerTool returns non null ProjectCrackerOptions.Error (new field)

* fix build on linux

* fix a test

* slashes

* revert slashes

* Update FSharp.Compiler.Service.ProjectCracker.nuspec

* try to fix travis

* try to fix travis

* list dependencies

* no obsolete pdb in nuget

* list dependencies

* cherry pick of fsharp/fsharp change

* bump FCS version number (#3688)

* Update FSharp.Compiler.Service.MSBuild.v12.nuspec

* fix FCS nuget on windows

* fix-resource (#3690)

* Bump FSharp.Compiler.Tools to 4.1.27 and align mono build files (#3693)

* ri change from fsharp

* fix test

* bump FSC tools to 4.1.27

* remove fsharp.core from Mono GAC

* align mono directory

* fix typo

* install back versions with Mono

* fix typo

* update FCS doc generation (#3694)

* update DEVGUIDE to add addiitional steps before running build (#3725)

* Split templates out into a seperate vsix (#3720)

* merge error

* Merge issues

* fix xmldocs for in-memory project references

* add test

* fix tests

* TypeChecker notifies name resolution sink about IL constant fields

* TypeChecker notifies name resolution sink about literal values in patterns

* add tests

* allow build of community FCS nuget pacakge from this repo

* fix build of vs tests

* build fcs nupkg

* clean project files

* build all FCS bits, incl right dependencies

* fcs nuget updates

* netstandard is not netcore

* make FCS tests pass

* make FCS tests pass

* revert unintended change

* fix build of FCS docs

* remove explicit codegen from fcs .NETStandard build

* remove explicit codegen from fcs .NETStandard build

* add version numbers to DLLs

* missing file

* remove duplicate package

* try use roslyn build error reporter

* undo changes

* undo changes

* undo changes

* try use roslyn build error reporter

* more work on unifying diagnostics

* minimize diff

* bang bang

* code review feedback

* remove old test

* no in-memory project references for projects using generative type providers

* add test and build FCS as part of 'all'

* remove needless file

* add missing compiled TP dll

* cleanup

* cleanup

* diagnostics

* cleanup diagnostics

* even cleaner diagnostics

* cleanup diagnostics

* default tuning

* adjust tuning, more logging

* add test, fix whitespace

* import remaining FCS code

* add missing files

* fix some parts of build

* more FCS integration work

* build fcs.dll and vs targets

* revert changes to proj files

* update sig files

* various cleanup items

* simplify #ifs

* fix various tests

* enable scripting testing

* fix build

* fix build

* fix tests and build

* fix tests and build

* fix build

* fix tests

* fix tests

* add diagnostic and fix coreclr build

* fix printing tests

* test updates

* improve error logging

* integrate visualfsharp master

* dependency files

* proj file

* dependency files

* fix build

* fix fsi.exe in GUI mode

* add end of line to source text if needed as before

* fix many tests

* fix remaining tests

* better strong name logic to fix final test

* reinstate all strong names

* fix last tests

* fix last test again

* concrete instantiations

* concrete instantiations (2)

* more propagation

* concrete instantiations (3)

* more propagation

* more propagation

* minor cleanup

* try to fix failing tests

* fix test

* try to fix test

* make text available in UI

* fix test

* minor fix

* copy right version of System.Collections.Immutable to bin folder

* fix visuals

* fix build

* add tests

* generic parameters for F# values

* tests for F# values, and move Full name to right place

* final tweaks

* fix some tests

* test fixes

* fix assertion

* fix tests

* change to 'a is int

* wip

* port Roslyn's C# completion triggering logic as is

* fixed: completion do not trigger at all

* fix position

* fix a test

* do not provide completion on certain places

* fix muting completion on Named(Wild) pat in binding

* do not provide completion on ctor / lambda parameter names + tests

* fix binding traversing in completion

* fix tests

* fix the last failing test

* wip

* wip

* fix compilation

* the list kind of works

* try to add open (fake)

* insert fake open statement

* works for dummy ns insert position

* it works (draft)

* wip

* pass proper namespace to open

* do not suggest operators

prefer already resolvable items

* fix compilation

* fix

* filter out unqualified types if there are same normal ones (UnqualifiedType (tcRef1 :: _) is equal to TType.Type_app (_, tcRef1) is tcRef1 = tcRef2)

* fix compilation

* do not open Microsoft.FSharp.xxx namespaces

add mandatory qualifier, which makes completion works for symbols like `Printf.kprintf`

* fix bugs

* wip

* wip

* Revert "wip"

This reverts commit fe3247e08fccabc00242f658282565f568eb2f3b.

* fixing bugs with RCA modules

* bug fixing

* fix filter text

* optimize completion list sorting

* code cleanup and doc

* defer getting all entities (do not get them after dot completion at all)

* fix compilation

* remove dead code

* rename RawEntity to AssemblySymbol and use FSharpSymbol instead of Item in it

* do not call getAllSymbols unless necessary (now for real)

* AssymblySymbol -> AssemblySymbol

* add completion for keywords

* order completion items by IsResolved property

* add CompletionContext.OpenDeclaration, remove IsAtOpenDeclaration ad-hoc filtering

do not show keywords at open declaration position

* add distinct list for priority completion items (wip)

* Revert "add distinct list for priority completion items (wip)"

This reverts commit a854f2646b682079c83841ac1cdb1595799b1197.

* it works

* smarter completion items ordering

* show type's own instance methods and properties first

* show type's own static methods and properties first

* own IL fields are shown first

* order fields, props, methods, events

refactoring

* simple MRU completion items priority

* fix tests, normalize mru items hints, refactoring

* fix priorities inside mru

* completion items glyphs take accessibility into account, proper glyph for extension members

* fix a test

* fix completion item description ordering regression

* rename GlyphMajor to FSharpGlyph and make it a union instead of enum

remove GlyphMinor
remove the old navbar and tests

* minimize diff

* make MRU list keyed by Item.FullName instead of DisplayName

fix a bug with emptyArray.max

* fixed: FullNameOfItem throws being called on Item.Types (TType.<anything but TType_app>)

* fixed again: FullNameOfItem throws being called on Item.Types (TType.<anything but TType_app>)

* fix stack overflow

* fix tests

* fix tests

* fix tests

* port rest of the code from priority-in-completion branch

* minimize diff

* fix wrong accessibility in CompletionItem

* add signature file

* fix 2489

* another sig file

* another sig file

* error logger for GetProjectOptionsFromScript

* fix build

* fix build (2)

* wip

* adjust color when color theme changes

* highlight mutable record / struct fields

* remove theme changing listener

* fix typo in a test

* address code review

* black color for functions by default

* try to fix false range for get, set auto properties

This implements signature help (method overload tips and parameter info). #1767. Also fixes #1856

This is mostly just wiring up the necessary things and copying across some of the nitty-gritty detail from the old language service. Some additional information was propagated such as HasParamArrayArg.

Fixes underlying issues associated with https://github.com/Microsoft/visualfsharp/issues/1815

After getting a 15+ second UI block in VS 2017, I've done a complete review of the way the new LanguageService implementation is using FSharp.Compiler.Service (the DLL internally called FSharp.Compiler.LanguageService in the Visual F# Tools repo, but it's basically the same component as FCS)

In short, the new LS implementation expects FCS to honour cancellation of submitted tasks in a more timely way.  This PR greatly improves the cancellability of FCS requests, which was one of the underlying causes of such a long UI block.

1. Improve FCS so that it respects cancellation in a more timely way.  Cancellation will now be respected at each step of the evaluation of the incremental build graph (IncrementalBuild.fs). This represents a fundamental improvement to FCS which will be very useful to other F# editors as well, as long as they are cancelling tasks.

   In particular, some FCS requests could be _very_ long running, e.g. CheckFileInProject may require checking **all** the files prior to this file (and if cross-F#-to-F#-project checking is enabled then it will  require checking all the dependent projects too).  

   Prior to this PR FCS was not respecting cancellation of these requests, and was simply running them through and then throwing the results away.

2. The new LS implementation was using some unnecessary calls to Async.RunSynchronously.  All of these could inject arbitrary non-responsiveness into some part of the causality chains.  I've removed these in favour of fully async code.

3. In FCS the old IsResultObsolete logic can be removed in favour of checking a cancellation token

This also fixes https://github.com/Microsoft/visualfsharp/issues/1756, see [this change here](https://github.com/Microsoft/visualfsharp/pull/1819/files#diff-69fa840cd1c6d144d0cd489cad82e901R88)

We have a separate issue that too may errors/warnings are shown for out-of-project files - the old LS implementation showed the first 3 errors - a good choice which we decided on long ago.  I'll add an issue for that.