Merge master to vs2017-rtm

* add checks for famANDassembly visibility

fixes https://github.com/Microsoft/visualfsharp/issues/1373

* add unit tests for FamAndAssembly / FamOrAssembly

* disable failing test

* adapt ut error message for error message rework

* add issue link to disabled unit test

* align and replace all tabs with whitespace (maybe build failure is related to tabs? I'm probably paranoid ....)

* -a => --target:library

* fix assembly

* fix FamAndAssembly

* manually modify accessibilities in AccessibilityTests.dll

* Revert "-a => --target:library"

This reverts commit 33af6458fc2839511e7b110b4b0c3922ff95fa4e.

* Fix MethodDebugTable for portablePDBs

* ensure that pdb gets a record for abstract methods

* minimise diff

* Saved

* SDK editor support

* Address merge issues

* Feedback

* reduce delta

* invalidate ide when a new file is discovered

* Go faster stripes

* feedback + refactor

* tryFindIndex

* Cleanup + Ensure that FSharp.Core.BuildFromSource.proj works at designtime

* final clean up

* label for HandleCommandLineChanges

* ensure some buildfromsource porojects load

add build task to generate *.resx and *.fs from *.txt resources

* improve debugging

* add missing files

* update baselines

* update baselines

* update test baselines

* Add editor formatting service for auto-deindent

* Minor refactor of the indentation service - do not indent after 'function'

* Only use smart indentation if indent style is set to 'Smart'

* Fix broken unit test build

* Implement review comments, fix build

* Fix some broken brace matching tests

Still WIP, other tests still broken

* Fix failing indentation tests

* Add formatting service tests

* Add more brace matching tests

Fixes #2092

* add assertion message

* fix Async.StartAsTask cancelling behavior (wait for stuff to cleanup)

* implement check and codefix for mismatched parameters

* apply consistent param names to FSHarp.Core

* undo changes to fst/snd to prevent any codegen changes

Fix 996 - resource usage of infinite sequence expression containing recursive function definitions (#3536)

* Fix part of 3465 - allow nativeptr address of in 'let'

* fix tests

* fix test

* fix test

Issue opened:  https://github.com/Microsoft/visualfsharp/issues/3539

* whitespace cleanup

* whitespace cleanup

* whitespace cleanup

* undo changes to fst/snd to prevent any error text changes

* undo changes to fst/snd to prevent any error text changes

* Fix attribute references

* For attributes with type arguments only add reference to Nominal types

* fix test

* fix test

* don't copy incorrect fsharp.core

* Update TestTP.fsproj

* fix 3489 - struct unions

* fix 3489 - struct unions - test

* fix 3489 - struct unions - fix code gen

* fix tests

* Generate correct names for delegate and object expression arguments

* update test baselines

* simplify key and value access

* Remove unused function

* Directly use from list - saves couple of Map Ctors

* Revert "Remove unused function"

This reverts commit a2f6dc54a5d64842d7a66d24b4b28629db77d90f.

# Conflicts:
#	src/absil/zmap.fs

Do not calc map height twice

Prepare file headers for License change.

add WPF path to fsi.exe and cleanup resolution flags