Co-authored-by: NPetr Pokorny <petrpokorny@microsoft.com>
Co-authored-by: NTomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: NDon Syme <dsyme@users.noreply.github.com>

* Pattern discard not allowed for union case that takes no data

* Add test for grouped patterns discard

* Remove unnecesary use of wildcare across the compiler

* Format code

* Remove unnecesary wildcard on tests

* Update the warning logic

* Add warning behing preview flag

* More testing

* Add single-case unions when using them as a deconstruct syntax in functions

* Update FSComp.txt
Co-authored-by: NTomas Grosup <tomasgrosup@microsoft.com>

* revamp parallel checking

* simplify names

* fix diagnostics

* code formatting

* update surface area

* simplify diagnostic logging and format diagnostics eagerly when processing in parallel

* format code

* remove SplitRelatedDiagnostic

* fix build and cleanup

* further cleanup

* further cleanup

* format code

* fix flaterrors

* allow error recovery on collisions

* fix name generation to be deterministic

* fix build

* Update RecursiveSafetyAnalysis.fs

* Add flag for parallel type checking of files backed by signatures.

* Update src/Compiler/Driver/ParseAndCheckInputs.fs
Co-authored-by: NPetr Pokorny <petr@innit.cz>

* format code

* Update TypeTests.fs

* Prefix DiagnosticsLoggerProvider with I

* Remove duplicate hadSig binding.

* Add basic test for ParallelCheckingWithSignatureFiles flag.

* Add additional CI job.

* Produce binlog for ParallelCheckingWithSignatureFiles

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* Update TypeTests.fs

* Update SyntaxTreeTests

* Correct code after rebase

* Correct SynModuleSigDecl in SignatureTypeTests.fs

* Format ParseAndCheckInputs.fs
Co-authored-by: NDon Syme <donsyme@fastmail.fm>
Co-authored-by: NDon Syme <dsyme@users.noreply.github.com>
Co-authored-by: NPetr Pokorny <petr@innit.cz>
Co-authored-by: NVlad Zarytovskii <vzaritovsky@hotmail.com>

Co-authored-by: NDon Syme <dsyme@users.noreply.github.com>
Co-authored-by: NDon Syme <donsyme@fastmail.fm>
Co-authored-by: NPetr Pokorny <petrpokorny@microsoft.com>

* cleanup some things around names

* more rigorously separate display names, core display names and logical names

* fix build

* Fixing build

* Update

* Fixed a test

* Fixed a test

* Fixing more tests

* Update PrettyNaming.fs

* Update

* Update

* ok

* conflict

* Added a test

* Added another test

* And another test

* Minor stuff
Co-authored-by: NPeter Semkin <petersemkin@duck.com>
Co-authored-by: NPetr <psfinaki@users.noreply.github.com>

* normalize some names

* format code

* fix build

* Allow lower-case DU cases when RequireQualifiedAccess is specified

* Fix PR suggestions and Add more testing

* Protect feature under preview version

* Add a NotUpperCaseConstructorWithoutRQA warning to be raised in lang version preview

* Fix formatting

* Parser: simplify viewing productions in debug

* Formatter

* update fantomas (#13206)

* Format most of FSharp.Core (#13150)

* modify fantomasignore

* fix setting

* no single line functions in FSHarp.Core

* update fantomas

* apply formatting

* Format src/Compiler/Driver (#13195)

* adjust settings

* adjust code

* adjust settings

* adjust code

* fix code before formatting

* remove unnecessary yield

* manual pre-formatting

* preadjust code

* preadjust code

* preadjust code

* preadjust code

* adjust settings"

* adjust settings"

* adjust settings

* adjust settings

* fix build

* adjust settings

* adjust code

* adjust code

* adjust code

* update fantomas

* apply formatting

* apply formatting (fix build) (#13209)

* preformat

* apply formatting
Co-authored-by: NDon Syme <dsyme@users.noreply.github.com>

* adjust settings

* adjust code

* adjust settings

* adjust code

* fix code before formatting

* remove unnecessary yield

* manual pre-formatting

* preadjust code

* preadjust code

* preadjust code

* preadjust code

* adjust settings"

* adjust settings"

* adjust settings

* adjust settings

* fix build

* adjust settings

* adjust code

* adjust code

* adjust code

* update fantomas

* apply formatting

* fix merge problem

* fix merge problem

* more cleanup

* more cleanup

* improve CheckExpressions

* format

* fix build

* remove ModuleOrNamespaceExprWithSig and put it in CheckedImplFile

* format

* cleanup the cleanup

* cleanup

* split files

* rename

* split infos.fs and SymbolHelpres.fs

* split infos.fs and SymbolHelpres.fs

* fix code formating

* rename autobox --> LowerLocalMutables

* adjust names

* block --> ImmutableArray

* format

* Error --> SRDiagnostic

* Error --> SRDiagnostic

* this -> _

* rename and cleanup

* rename Diagnostic --> FormattedDiagnostic

* format sigs

* format sigs

* organise files in src/fsharp

* organise files in src/fsharp

* fix build

* fix build

* fix build

* merge

* move more files

* move more files

* move more files

* move more files

* fix build

* file reorg

* finish moves

* fix links in docs

* code format

* fix build

* save xlf, InteractiveSession/ --> Interactive/

* moved xlf

* cleanup .gitignore

* fixed Linux build

* cleanup docs

* cleanup docs

* cleanup

* split files

* rename

* split infos.fs and SymbolHelpres.fs

* split infos.fs and SymbolHelpres.fs

* fix code formating

* rename autobox --> LowerLocalMutables

* adjust names

* block --> ImmutableArray

* format

* Error --> SRDiagnostic

* Error --> SRDiagnostic

* this -> _

* rename and cleanup

* rename Diagnostic --> FormattedDiagnostic

* format sigs

* format sigs

* fix build

* fix build

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

Co-authored-by: NVlad Zarytovskii <vzaritovsky@hotmail.com>
Co-authored-by: Ndotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: NKevin Ransom <codecutter@hotmail.com>
Co-authored-by: NKevin Ransom (msft) <codecutter@hotmail.com>
Co-authored-by: NDon Syme <dsyme@users.noreply.github.com>
Co-authored-by: NDon Syme <donsyme@fastmail.fm>
Co-authored-by: Nkerams <kerams@users.noreply.github.com>
Co-authored-by: Njkone27 <jkone27@users.noreply.github.com>
Co-authored-by: Ndotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: NChet Husk <baronfel@users.noreply.github.com>
Co-authored-by: NAlex Berezhnykh <alexey.berezhnykh@jetbrains.com>
Co-authored-by: NFlorian Verdonck <florian.verdonck@outlook.com>
Co-authored-by: NPierre Irrmann <pierre.irrmann@gmail.com>
Co-authored-by: NEugene Auduchinok <eugene.auduchinok@jetbrains.com>
Co-authored-by: NRafał Gwoździński <rafal.gwozdzinski@gmail.com>
Co-authored-by: NKostiantyn Sharovarskyi <services@sharovarskyi.com>
Co-authored-by: NKevin Malenfant <kevin@xaai.ch>
Co-authored-by: NWill Smith <lol.tihan@gmail.com>

<p dir="auto">lol should always have been this</p>

* further cleanup

* fix srtp processing related to tasks

* fix 12189 - bad codegen for tasks. Also eliminate 'trace' parameter and put it in the constraint solver context instead

* fix 12189 - bad codegen for tasks. Also eliminate 'trace' parameter and put it in the constraint solver context instead

* fix 12189 - bad codegen for tasks. Also eliminate 'trace' parameter and put it in the constraint solver context instead

* fix 12189 - bad codegen for tasks. Also eliminate 'trace' parameter and put it in the constraint solver context instead

* cleanup and fix method arg lambda propagation rule

* fix error messages

* fix error messages

* fix error messages

* fix error messages

* simplify diff

* simplify diff

* reduce diff and fix errors

* reduce diff and fix errors

* fix srtp processing related to tasks

* fix 12189 - bad codegen for tasks. Also eliminate 'trace' parameter and put it in the constraint solver context instead

* fix 12189 - bad codegen for tasks. Also eliminate 'trace' parameter and put it in the constraint solver context instead

* fix 12189 - bad codegen for tasks. Also eliminate 'trace' parameter and put it in the constraint solver context instead

* fix 12189 - bad codegen for tasks. Also eliminate 'trace' parameter and put it in the constraint solver context instead

* cleanup and fix method arg lambda propagation rule

* fix error messages

* fix error messages

* fix error messages

* fix error messages

* simplify diff

* simplify diff

* reduce diff and fix errors

* reduce diff and fix errors

* Diagnostics: add production rule index

* Parser: fix recovery for unfinished match clause

Fixes recovery for missing right hand sides:
```
match () with
| x
```

* Add tests

* Add recovery near to next clause

* Restore indent in test data

* Update desktop test baselines

* Update FSharpQA test baselines

* Fix recovered patterns ranges

* Try to fix Desktop test suite

* Update surface area

* Better diagnostics

* Try to fix Desktop test suite

* Fix tests

* Simplify test

* Add more tests

* Disable failing test

* indexer notation expr[expr]

* add tests

* back compat

* update tests

* fix build

* fix build

* fix additional case of syntactic sugar triggering warning

* fix warning#

* fix warnings

* fix warning#

* improve messages

* remvoe test case no longer of interest

* emit informationals

* update baselines

* don't produce informationals for expr.[idx] as yet

* tweak error messages

* remove dead code

* merge main

* fix tests

* fix tests

* fix tests

* fix tests

* improve diagnostics

* add aka.ms links

* update baselines

* fix error messages

* change warning to informational in preview

* fix test

* code review feedback

* code review feedback

* Update salsa.fs
Co-authored-by: NDon Syme <donsyme@fastmail.com>

* merge main

* merge main

* fix some misc bits and pieces

* fix bug

* assert constructor return type

* no subsumption for type-directed records

* fix bootstrap build

* fix test

* fix test baselines

* respect rigid type annotations within expressions

* respect rigid type annotations within expressions

* reenable rigid type annotations within expressions

* update baseline

* add language version check

* adjust test baseline for better error recovery

* adjust test baseline for better error recovery

* Merge main to feature/auto-widen (#10918)

* [main] Update dependencies from dotnet/arcade (#10913)

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21068.2 -> To Version 6.0.0-beta.21069.2
Co-authored-by: Ndotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Refactor everything but the type provider tests in signature help testing (#10908)
Co-authored-by: Ndotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Ndotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: NPhillip Carter <pcarter@fastmail.com>

* fixes for type directed conversion for optional args, backwards compat for overloads

* op_Implicit support

* update baselines

* fix bug in nullable codegen

* fix tests

* fix unions and records

* ignore hanging test for now

* fix hang

* update baseline

* trim trailing spaces

* simplify expression leaf logic and make regular

* fix build

* update testing

* update baselines

* cache implicit operator lookup

* add op_Implicit tests: checks, options, ambiguities, extrinsic extensions

* remove int32 --> float32 and floar32 --> float64, improve error messages

* update baseline and improve errors

* update message

* adjust mechanism and policy for warnings

* adjust warnings implementation and policy

* Update FSharp.Test.Utilities.fsproj

* Update FSharp.Compiler.Service.Tests.fsproj

* Fix merge issue

* Update CheckExpressions.fs
Co-authored-by: NDon Syme <donsyme@fastmail.com>
Co-authored-by: Ndotnet bot <dotnet-bot@dotnetfoundation.org>
Co-authored-by: Ndotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Ndotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: NPhillip Carter <pcarter@fastmail.com>
Co-authored-by: NKevin Ransom (msft) <codecutter@hotmail.com>
Co-authored-by: NVlad Zarytovskii <vzaritovsky@hotmail.com>

Co-authored-by: NVlad Zarytovskii <vzaritovsky@hotmail.com>

* Cleanup: remove redundant parens

* Move existing Compiler.ComponentTests to a new Compiler.fs framework (#9839) (#9847)

* Move existing Compiler.ComponentTests to a new Compiler.fs framework; Add 'parse' function

* Changed some wording in error messages
Co-authored-by: NVlad Zarytovskii <vzaritovsky@hotmail.com>

* fix build

* fix order of diagnostics

* update baselines

* Delete FSharp.Compiler.Service.fsproj

* fix comments

* fix comments

* fix build

* fix build

* Reduce number of typeEquiv checks (#10324) (#10374)
Co-authored-by: NSteffen Forkmann <steffen.forkmann@msu-solutions.de>

* xlf

* fix build

* fix build

* fix build

* fix build

* fix list and array builder perf

* better perf testing

* better perf testing

* better perf testing

* update baselines

* work on taskSeq { ... }

* remove old file

* enable all benchmarks

* update benchmarks

* update baseline

* static checking of resumable code

* static checking of resumable code

* fix build

* fix build

* fix build

* fix build

* fix build

* fix build

* fix baseline

* try fix stack overflow

* fix up tests

* add some negative testing, simplify implementation

* fix up tests

* fix baseline

* fix test and add negative baselines

* rename intrinsic and add test for seq case

* fix build

* fix and rename test

* fix test

* improve debugging

* improve debugging of try/with and try/finally

* fix baseline

* infer resumable code from single attribute on delegate type

* update samples

* inline if lambda

* update baselines

* fix check

* delegate and computed function reductions for inlined code

* update baselines

* update baselines

* update test

* fix test that failed randomly due to inexact floating point

* add tests for generated IL

* update tests

* don't use InlineIfLambda on sumBy and averageBy due to slight floating point changes

* add ability for struct machines to implement additional interfaces (needed for low allocation co-routines)

* add coroutines

* update baselines

* resumable code combinators and tailcalls for coroutines

* fix baselinhe

* make tasks using shared resumable code combinators the default. Also testing and fixes for dynamic execution of resumable code

* update baselines

* suppress warning in FSharp.Core

* suppress warning in FSharp.Core

* fix build

* fix build

* fix build

* update test

* only struct state machines

* codegen IResumableStateMachine

* update baselines

* update baselines

* notes on sample

* fix build

* Update coroutine.fs

* Negative testing following spec for compilability. Additional testing for dynamic implementation of tasks

* simpler coroutine sample, fix build

* update baselines

* remove unused state vars from internal represenation of object expressions

* add coroutine example

* update perf benchmarks

* remove old files

* code cleanup

* add compilergenerated attribute, add async2 approximate implementation

* test async perf w.r.t. previous compiler, add test for reduced stack trace

* using on IAsyncDisposable

* remove dynamic Awaiter field from tasks

* update surface area

* add backgroundTask { ... }

* surface area test only for decalred members etc.

* fix test

* add dynamic tests for backgroundTask

* fix codegen bug

* fix build

* simplify SRTP use in task.fs/fsi

* fix build and baselines

* fix build

* fix build

* fix build

* fix pacakge

* remove RFC FS-1099 from this PR

* remove RFC FS-1099 from this PR

* backgroundTask only switches to background if necessary

* Update tasks.fs

* fix test

* clear sync context for test

* clear sync context for test

* update baseline

* code review

* fix build

* fix build

* fix clearing state machines

* fix to clearing code

* improve generated task code and debugging

* only update baselines on failure

* fix some cases of debug stepping, improve isnull codegen, add more tests

* move TaskPerf to benchmarks directory

* fix baseline

* only update baselines when things changed

* fix baselines

* update baselines

* fix baselines

* fix build

* fix some tests, add hard error on language version check

* reset unchanged files

* update baselines

* update baselines

* fix baseline

* fix comparer

* flags

* Revert "flags"

This reverts commit 5b2a0118311150cea9be567d497a917fde0b92f5.

* fix merge

* fix build

* fix build

* fix build

* update baseline

* fix build

* fix build

* update baseline

* fix baselines

* update baseline

* fix build

* fix build

* update baseline

* fix test

* code review changes
Co-authored-by: NKevin Ransom (msft) <codecutter@hotmail.com>
Co-authored-by: NPhillip Carter <pcarter@fastmail.com>
Co-authored-by: Ndotnet bot <dotnet-bot@dotnetfoundation.org>
Co-authored-by: NVlad Zarytovskii <vzaritovsky@hotmail.com>
Co-authored-by: NDon Syme <donsyme@fastmail.com>
Co-authored-by: NSteffen Forkmann <steffen.forkmann@msu-solutions.de>
Co-authored-by: NBrett V. Forsgren <brettfo@microsoft.com>

* Initial work for proper xml doc info

* Implementing IXmlDocumentationInfoLoader

* Added TryFindXmlDocumentationInfo to AssemblyLoader

* Able to get xml comments

* Minor refactor

* More refactoring

* Fixing build

* Plumbing infoReader and updating surface area

* Do not create a local entity ref here

* Removed extracting XML from resources as that is not correct

* Ignore parameter

* More cleanup

* layoutXmlDoc formats well with new-lines

* layout xml doc for values

* Setting up more layout functions

* Using new layouts

* All xml is being emitted

* fixing a few tests

* Fixing test

* Fixing a test

* fixing tests

* Fixing tests

* Better caching for xml documentation

* incorporate cleanup related to analyzers

* fix error regressions
Co-authored-by: NDon Syme <donsyme@fastmail.com>

* trim API surface area

* move Range and Pos types to FSharp.Compiler

* undo uppercae range/pos

* move Range and Pos types to FSHarp.Compiler.SourceCodeServices since they are part of the FCS API

* fix baselines

* release notes

* FIX BUILD

* fix test

* fix test

* fix test

* fix test

* fix build

* fix build

* fix build

* PrettyNaming moved to SourceCodeServices

* ISourceText moved to SourceCodeServices

* update docs

* update docs

* fix build

* fix build

* move Range, Pos to FSharp.Compiler.Text

* fix test

* fix build
Co-authored-by: NDon Syme <donsyme@fastmail.com>