连接信息写DB优化为批量写入

kafka-manager-core/src/main/java/com/xiaojukeji/kafka/manager/service/service/gateway/impl/TopicConnectionServiceImpl.java

@@ -26,21 +26,27 @@ public class TopicConnectionServiceImpl implements TopicConnectionService {
     @Autowired
     private TopicConnectionDao topicConnectionDao;
 
+    private int splitInterval = 50;
+
     @Override
     public void batchAdd(List<TopicConnectionDO> doList) {
         if (ValidateUtils.isEmptyList(doList)) {
             return;
         }
+        int allSize = doList.size();
+        int successSize = 0;
 
-        int count = 0;
-        for (TopicConnectionDO connectionDO: doList) {
-            try {
-                count += topicConnectionDao.replace(connectionDO);
-            } catch (Exception e) {
-                LOGGER.error("class=TopicConnectionServiceImpl||method=batchAdd||connectionDO={}||errMsg={}", connectionDO, e.getMessage());
-            }
+        int part = doList.size() / splitInterval;
+        for (int i = 0; i < part; ++i) {
+            List<TopicConnectionDO> subList = doList.subList(0, splitInterval);
+            successSize += topicConnectionDao.batchReplace(subList);
+            doList.subList(0, splitInterval).clear();
         }
-        LOGGER.info("class=TopicConnectionServiceImpl||method=batchAdd||allSize={}||successSize={}", doList.size(), count);
+        if (!ValidateUtils.isEmptyList(doList)) {
+            successSize += topicConnectionDao.batchReplace(doList);
+        }
+        LOGGER.info("class=TopicConnectionServiceImpl||method=batchAdd||allSize={}||successSize={}", allSize, successSize);
+
     }
 
     @Override

kafka-manager-dao/src/main/java/com/xiaojukeji/kafka/manager/dao/gateway/TopicConnectionDao.java

@@ -13,8 +13,6 @@ import java.util.List;
 public interface TopicConnectionDao {
     int batchReplace(List<TopicConnectionDO> doList);
 
-    int replace(TopicConnectionDO topicConnectionDO);
-
     List<TopicConnectionDO> getByTopicName(Long clusterId, String topicName, Date startTime, Date endTime);
 
     List<TopicConnectionDO> getByAppId(String appId, Date startTime, Date endTime);

kafka-manager-dao/src/main/java/com/xiaojukeji/kafka/manager/dao/gateway/impl/TopicConnectionDaoImpl.java

@@ -27,29 +27,12 @@ public class TopicConnectionDaoImpl implements TopicConnectionDao {
 
     @Override
     public int batchReplace(List<TopicConnectionDO> doList) {
-        int count = 0;
-        for (TopicConnectionDO elem: doList) {
-            try {
-                count += sqlSession.insert("TopicConnectionDao.replace", elem);
-            } catch (DeadlockLoserDataAccessException e1) {
-
-            } catch (Exception e) {
-                LOGGER.error("add topic connection info, clusterId:{} topicName:{}."
-                        , elem.getClusterId(), elem.getTopicName(), e);
-            }
-        }
-        return count;
-    }
-
-    @Override
-    public int replace(TopicConnectionDO topicConnectionDO) {
         try {
-            return sqlSession.insert("TopicConnectionDao.replace", topicConnectionDO);
+            return sqlSession.insert("TopicConnectionDao.batchReplace", doList);
         } catch (DeadlockLoserDataAccessException e1) {
             return 0;
         } catch (Exception e) {
-            LOGGER.error("add topic connection info, clusterId:{} topicName:{}."
-                    , topicConnectionDO.getClusterId(), topicConnectionDO.getTopicName(), e);
+            LOGGER.error("add topic connections info failed", e);
         }
         return 0;
     }

kafka-manager-dao/src/main/resources/mapper/TopicConnectionDao.xml

@@ -13,7 +13,7 @@
         <result property="createTime"       column="create_time"/>
     </resultMap>
 
-    <insert id="replace" parameterType="com.xiaojukeji.kafka.manager.common.entity.pojo.gateway.TopicConnectionDO">
+    <insert id="batchReplace" parameterType="java.util.List">
         REPLACE INTO topic_connections (
             cluster_id,
             topic_name,
@@ -22,16 +22,19 @@
             ip,
             client_version,
             create_time
-          )
-        VALUES (
-            #{clusterId},
-            #{topicName},
-            #{type},
-            #{appId},
-            #{ip},
-            #{clientVersion},
-            #{createTime}
-          )
+        )
+        VALUES
+        <foreach collection="list" item="item" index="index" separator=",">
+            (
+            #{item.clusterId},
+            #{item.topicName},
+            #{item.type},
+            #{item.appId},
+            #{item.ip},
+            #{item.clientVersion},
+            #{item.createTime}
+            )
+        </foreach>
     </insert>
 
     <select id="getByTopicName" parameterType="java.util.Map" resultMap="TopicConnectionMap">