提交 6358b3c9 编写于 作者: 8 844392610

Revert "Improve performance of expandIP, and readable"

This reverts commit 2baae144.
上级 7a6c3740
...@@ -31,12 +31,10 @@ import org.junit.Test; ...@@ -31,12 +31,10 @@ import org.junit.Test;
public class AclUtilsTest { public class AclUtilsTest {
// strArray[i] = StringUtils.leftPad(strArray[i],4, '0');
@Test @Test
public void getAddresses() { public void getAddreeStrArray() {
String address = "1.1.1.{1,2,3,4}"; String address = "1.1.1.{1,2,3,4}";
String[] addressArray = AclUtils.getAddresses(address, "{1,2,3,4}"); String[] addressArray = AclUtils.getAddreeStrArray(address, "{1,2,3,4}");
List<String> newAddressList = new ArrayList<>(); List<String> newAddressList = new ArrayList<>();
for (String a : addressArray) { for (String a : addressArray) {
newAddressList.add(a); newAddressList.add(a);
...@@ -51,7 +49,7 @@ public class AclUtilsTest { ...@@ -51,7 +49,7 @@ public class AclUtilsTest {
// IPv6 test // IPv6 test
String ipv6Address = "1:ac41:9987::bb22:666:{1,2,3,4}"; String ipv6Address = "1:ac41:9987::bb22:666:{1,2,3,4}";
String[] ipv6AddressArray = AclUtils.getAddresses(ipv6Address, "{1,2,3,4}"); String[] ipv6AddressArray = AclUtils.getAddreeStrArray(ipv6Address, "{1,2,3,4}");
List<String> newIPv6AddressList = new ArrayList<>(); List<String> newIPv6AddressList = new ArrayList<>();
for (String a : ipv6AddressArray) { for (String a : ipv6AddressArray) {
newIPv6AddressList.add(a); newIPv6AddressList.add(a);
...@@ -183,28 +181,23 @@ public class AclUtilsTest { ...@@ -183,28 +181,23 @@ public class AclUtilsTest {
public void v6ipProcessTest() { public void v6ipProcessTest() {
String remoteAddr = "5::7:6:1-200:*"; String remoteAddr = "5::7:6:1-200:*";
String[] strArray = StringUtils.split(remoteAddr, ":"); String[] strArray = StringUtils.split(remoteAddr, ":");
Assert.assertEquals(AclUtils.v6ipProcess(remoteAddr), "0005:0000:0000:0000:0007:0006"); Assert.assertEquals(AclUtils.v6ipProcess(remoteAddr, strArray, 3), "0005:0000:0000:0000:0007:0006");
// Assert.assertEquals(AclUtils.v6ipProcess(remoteAddr, strArray, 3), "0005:0000:0000:0000:0007:0006");
remoteAddr = "5::7:6:1-200"; remoteAddr = "5::7:6:1-200";
strArray = StringUtils.split(remoteAddr, ":"); strArray = StringUtils.split(remoteAddr, ":");
Assert.assertEquals(AclUtils.v6ipProcess(remoteAddr), "0005:0000:0000:0000:0000:0007:0006"); Assert.assertEquals(AclUtils.v6ipProcess(remoteAddr, strArray, 3), "0005:0000:0000:0000:0000:0007:0006");
// Assert.assertEquals(AclUtils.v6ipProcess(remoteAddr, strArray, 3), "0005:0000:0000:0000:0000:0007:0006");
remoteAddr = "5::7:6:*"; remoteAddr = "5::7:6:*";
strArray = StringUtils.split(remoteAddr, ":"); strArray = StringUtils.split(remoteAddr, ":");
Assert.assertEquals(AclUtils.v6ipProcess(remoteAddr), "0005:0000:0000:0000:0000:0007:0006"); Assert.assertEquals(AclUtils.v6ipProcess(remoteAddr, strArray, 3), "0005:0000:0000:0000:0000:0007:0006");
// Assert.assertEquals(AclUtils.v6ipProcess(remoteAddr, strArray, 3), "0005:0000:0000:0000:0000:0007:0006");
remoteAddr = "5:7:6:*"; remoteAddr = "5:7:6:*";
strArray = StringUtils.split(remoteAddr, ":"); strArray = StringUtils.split(remoteAddr, ":");
Assert.assertEquals(AclUtils.v6ipProcess(remoteAddr), "0005:0007:0006"); Assert.assertEquals(AclUtils.v6ipProcess(remoteAddr, strArray, 3), "0005:0007:0006");
// Assert.assertEquals(AclUtils.v6ipProcess(remoteAddr, strArray, 3), "0005:0007:0006");
} }
@Test @Test
public void expandIPTest() { public void expandIPTest() {
Assert.assertEquals(AclUtils.expandIP("::", 8), "0000:0000:0000:0000:0000:0000:0000:0000");
Assert.assertEquals(AclUtils.expandIP("::1", 8), "0000:0000:0000:0000:0000:0000:0000:0001"); Assert.assertEquals(AclUtils.expandIP("::1", 8), "0000:0000:0000:0000:0000:0000:0000:0001");
Assert.assertEquals(AclUtils.expandIP("3::", 8), "0003:0000:0000:0000:0000:0000:0000:0000"); Assert.assertEquals(AclUtils.expandIP("3::", 8), "0003:0000:0000:0000:0000:0000:0000:0000");
Assert.assertEquals(AclUtils.expandIP("2::2", 8), "0002:0000:0000:0000:0000:0000:0000:0002"); Assert.assertEquals(AclUtils.expandIP("2::2", 8), "0002:0000:0000:0000:0000:0000:0000:0002");
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册