This reverts commit 628e6d01 and uses
a better fix.

Before:
4483 decicycles in get_pixels_8x4_sym,  131032 runs,     40 skips

After:
2569 decicycles in get_pixels_8x4_sym,  131054 runs,     18 skips

This allows more efficient access to the array as the level and flags
are contiguous. Around 4% faster coefficient decoding.
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

This is the same test as for the 8bit case.

Dequant or encoding were trying to reverse a scan that hadn't been
applied...
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

Fixes a regression since a8ab64d2 reported by Rens Dijkshoorn, rens offlinemedia nl.

Express bitfields more simply.
Signed-off-by: NVittorio Giovara <vittorio.giovara@gmail.com>

Convert doxygen to multiline and express bitfields more simply.
Signed-off-by: NVittorio Giovara <vittorio.giovara@gmail.com>

This parameter can be used to inform the allocation code about how much
downsizing might occur, and can be used to optimize how to allocate the
packet
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

The stats are a superset of the quality factor, also allowing the picture type and encoder "PSNR" stats to be exported
This also replaces the native by fixed little endian order for the affected side data

AV_PKT_DATA_QUALITY_FACTOR is left as a synonym of AV_PKT_DATA_QUALITY_STATS
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

The rationale is that coded_frame was only used to communicate key_frame,
pict_type and quality to the caller, as well as a few other random fields,
in a non predictable, let alone consistent way.

There was agreement that there was no use case for coded_frame, as it is
a full-sized AVFrame container used for just 2-3 int-sized properties,
which shouldn't even belong into the AVCodecContext in the first place.

The appropriate AVPacket flag can be used instead of key_frame, while
quality is exported with the new AVPacketSideData quality factor.
There is no replacement for the other fields as they were unreliable,
mishandled or just not used at all.
Signed-off-by: NVittorio Giovara <vittorio.giovara@gmail.com>

This is necessary to preserve the quality information currently exported
with coded_frame. Add the new side data to every encoder that needs it,
and use it in avconv.
Signed-off-by: NVittorio Giovara <vittorio.giovara@gmail.com>

Allocating coded_frame is what most encoders do anyway, so it makes
sense to always allocate and free it in a single place. Moreover a lot
of encoders freed the frame with av_freep() instead of the correct API
av_frame_free().

This bring uniformity to encoder behaviour and prevents applications
from erroneusly accessing this field when not allocated. Additionally
this helps isolating encoders that export information with coded_frame,
and heavily simplifies its deprecation.
Signed-off-by: NVittorio Giovara <vittorio.giovara@gmail.com>

They are used by dnxhd and mpegvideo_enc exclusively, move them to codec
private options instead.
Signed-off-by: NVittorio Giovara <vittorio.giovara@gmail.com>

Reviewed-by: NMichael Niedermayer <michaelni@gmx.at>
Signed-off-by: NJames Almer <jamrial@gmail.com>

CC: libav-stable@libav.org
Bug-Id: CID 1194387 / CID 1194389 / CID 1194393 / CID 1206638

CC: libav-stable@libav.org
Bug-Id: CID 700464

Signed-off-by: NMichael Niedermayer <michaelni@gmx.at>

One step in untangling the mpegvideo code and fixing some problems in
the order that initialization is being done in h263dec and h261dec.

This will come in handy during dsputil splitting.

Signed-off-by: NMichael Niedermayer <michaelni@gmx.at>

Signed-off-by: NTimothy Gu <timothygu99@gmail.com>
Reviewed-by: N"Ronald S. Bultje" <rsbultje@gmail.com>
Signed-off-by: NMichael Niedermayer <michaelni@gmx.at>

Added libavutil/timer.h include to all files with {START,STOP}_TIMER.

Signed-off-by: NTimothy Gu <timothygu99@gmail.com>
Signed-off-by: NMichael Niedermayer <michaelni@gmx.at>

Signed-off-by: NMichael Niedermayer <michaelni@gmx.at>

Fixes out of array access with RC_VARIANCE set to 0
Signed-off-by: NMichael Niedermayer <michaelni@gmx.at>

Signed-off-by: NMichael Niedermayer <michaelni@gmx.at>