This is not an API change; the fields were explicitly declared private
before.
Signed-off-by: NAnton Khirnov <anton@khirnov.net>

analyze() is currently called both when probing and from read_header().
It determines the packet start by looking for the sync byte, followed by
unset Transport Error Indicator and valid adaptation_field_control.

This makes sense to do when probing, but once we already know the format
is MPEG-TS, it is counterproductive to be so strict -- e.g. in some
files the TEI might be set and analyze() might get called with a smaller
buffer than the one used for probing, resulting in a failure.

Nothing uses it, and it provides no public API.

Archeological finds:

Commit 101036ad added the API.
Commit a8dd8dc6 made mpegts.c use it.
Commit af8aae3f disabled it by default in mpegts.c.
Commit ae2bb52c removed all uses of this from mpegts.c.
Signed-off-by: NAnton Khirnov <anton@khirnov.net>

Reported-By: jb@videolan.org
Signed-off-by: NLuca Barbato <lu_zero@gentoo.org>

avio_tell can return a negative number.

Bug-Id: CID 1265715
CC: libav-stable@libav.org

Also propagate errors.

CC: libav-stable@libav.org
Bug-Id: CID 1238812

The frames seem to contain a higher bitrate which our decoder is
able to handle.
Signed-off-by: NVittorio Giovara <vittorio.giovara@gmail.com>

This atom typically is used for a track title. The handler name is stored
as a Pascal string in the QT specs (first byte is the length of the string),
so do not export it.

A second length check based on the first character is added to avoid
overwriting an already specified handler_name (it happens with YouTube
videos for instance, the handler_name get masked), or specifying an
empty string metadata.

The Pascal string fix and the second length check are written
by Clément Bœsch <clement.boesch@smartjog.com>.
Signed-off-by: NVittorio Giovara <vittorio.giovara@gmail.com>
Signed-off-by: NLuca Barbato <lu_zero@gentoo.org>

The ogg serial number doubles as codec id and sequence
value for concatenated samples.

CC: libav-stable@libav.org
Bug-Id: CID 1265721

Trigger a refill if the seek action moves the pointer
at the end of the buffer.

Before this patch the read action following the seek would trigger
the refill, while write action would write outside the buffer.

In the Libav codebase few muxers seek forward outside of what
already has been written so it is quite unlikely to experience
the problem with the default buffer size.

CC: libav-stable@libav.org

Avoid a division by zero.

CC: libav-stable@libav.org
Bug-Id: CID 717750

Avoid a division by zero.

CC: libav-stable@libav.org
Bug-Id: CID 717749

It is unreliable, especially when the stream codec context is not the
encoding context. Use the codec descriptor properties instead.

Handle its only existing use case internally.

CC: libav-stable@libav.org
Bug-Id: CID 1265713

Fix a memory leak.

CC: libav-stable@libav.org
Bug-Id: CID 717999

This partially reverts cf70ba37, since
it didn't take into account when rotation is 0, but there is another
valid operation (eg. translation) in the matrix.
Found-by: NMichael Niedermayer <michaelni@gmx.at>

Signed-off-by: NMartin Storsjö <martin@martin.st>

Signed-off-by: NMartin Storsjö <martin@martin.st>

Previously this always used the "lld" format for all parameters,
not only time parameters.
Signed-off-by: NMartin Storsjö <martin@martin.st>

This goto wasn't necessary originally, but it should have been
added when the write_manifest call was added in 8e276378.

CC: libav-stable@libav.org
Signed-off-by: NMartin Storsjö <martin@martin.st>

This fixes sending chunked packets (packets larger than the output
chunk size, which often can be e.g. 4096 bytes) with a timestamp delta
(or absolute timstamp, if it's a timestamp step backwards, or the
first packet of the stream) larger than 0xffffffff.

The RTMP spec explicitly says (in section 5.3.1.3.) that packets of
type 3 (continuation packets) should include this field, if the
previous non-continuation packet had it included.

The receiving code handles these packets correctly.

Pointed out by Cheolho Park.

CC: libav-stable@libav.org
Signed-off-by: NMartin Storsjö <martin@martin.st>

In v2.2, the picture type is not a zero-terminated string, but has a
constant size of 3 bytes.

Some of them are not immediately obvious.

Those functions should not ever modify it.

When the display matrix is not the identity one, but the rotation angle
is zero, there is no need to update the sample aspect ratio.

Otherwise, it is possible to obtain negative values which interferes
with transcoding in later stages. This kind of behaviour is reproducible
on mov files with "major_brand: MSNV".

CC: libav-stable@libav.org
Signed-off-by: NVittorio Giovara <vittorio.giovara@gmail.com>

Previously the image sequence was always starting from the minimum
number rather than the requested one.

CC: libav-stable@libav.org

A failure in segment_end() or segment_start() would lead to freeing
a dangling pointer and in general further calls to seg_write_packet()
or to seg_write_trailer() would have the same faulty behaviour.

CC: libav-stable@libav.org
Reported-By: luodalongde@gmail.com

Signed-off-by: NMartin Storsjö <martin@martin.st>

This was removed accidentally as part of 847bf598. This could cause
groundless warning logging.
Signed-off-by: NMartin Storsjö <martin@martin.st>

As referenced in the CoreMedia API docs.
Signed-off-by: NVittorio Giovara <vittorio.giovara@gmail.com>

Being able to write editlists properly is one of the main points
in the delay_moov flag.
Signed-off-by: NMartin Storsjö <martin@martin.st>