Signed-off-by: NPaul B Mahol <onemda@gmail.com>
Signed-off-by: NJustin Ruggles <justin.ruggles@gmail.com>

Fixes invalid writes and crashes when doing conversions such as stereo to 5.1
channels or sample rate conversion on 5.1 channels.

It may have improved cross-platform stability, but wasn't the only place in
the encoder with bitexact issues. It is no longer needed because we have FATE
tests for float encoders using fuzzy comparison.

Signed-off-by: NRonald S. Bultje <rsbultje@gmail.com>

Signed-off-by: NPaul B Mahol <onemda@gmail.com>
Signed-off-by: NRonald S. Bultje <rsbultje@gmail.com>

Calling avcodec_flush_buffers() and then avcodec_decode_video2() with
a 0-sized packet (to get remaining buffered frames) could incorrectly
return an old frame from before the avcodec_flush_buffers() call. Add
a loop in ff_thread_flush() to zero the got_frame field of each thread
to ensure the old frames will not be returned.
Signed-off-by: NRonald S. Bultje <rsbultje@gmail.com>

If the dummy frame are not created from a reference frame they could
be deleted untimely resulting in multithreaded decoder waiting on
the current frame to finish.
Noticed by Ronald S. Bultje in the RV34 decoder with a broken file.

If decoding a second complementary field, and the first was
decoded in our thread, mark decoding of that field as complete.
If decoding fails, mark the decoded field/frame as complete.
Do not allow switching between field modes or field/frame mode
between slices within the same field/frame. Ensure that two
subsequent fields cover top/bottom (rather than top/frame,
bottom/frame or such nonsense situations).

Fixes various deadlocks when decoding samples with errors in
reference frames.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org

Prevents hangs on corrupt input.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org

Fixes hangs on corrupt samples that reference self-frames.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org

Also remove some disabled code and fix a few comment typos.

Signed-off-by: NPaul B Mahol <onemda@gmail.com>
Signed-off-by: NAnton Khirnov <anton@khirnov.net>

Progressive images can have only 16 references, error out if there are
more, since the data is almost certainly corrupt, and the invalid value
will lead to random crashes or invalid writes later on.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org

Interlaced images can have 32 references (16 per field), so limiting the
array size to 16 leads to invalid writes.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org

Fixes NULL ptr dereference

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
Signed-off-by: NRonald S. Bultje <rsbultje@gmail.com>

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
Signed-off-by: NRonald S. Bultje <rsbultje@gmail.com>

Protects from overreads.
Signed-off-by: NPaul B Mahol <onemda@gmail.com>
Signed-off-by: NRonald S. Bultje <rsbultje@gmail.com>

Signed-off-by: NPaul B Mahol <onemda@gmail.com>
Signed-off-by: NRonald S. Bultje <rsbultje@gmail.com>

The safe bitstream reader broke it since the buffer size was specified
in bytes instead of bits.
Signed-off-by: NJanne Grunau <janne-libav@jannau.net>
CC: libav-stable@libav.org

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
Signed-off-by: NRonald S. Bultje <rsbultje@gmail.com>

x264 always opens the file itself with fopen, so we cannot use the
standard lavc stats mechanism.

CC: libav-stable@libav.org

CC: libav-stable@libav.org

Signed-off-by: NAnton Khirnov <anton@khirnov.net>

Signed-off-by: NAnton Khirnov <anton@khirnov.net>

Protects from overreads.
Signed-off-by: NPaul B Mahol <onemda@gmail.com>
Signed-off-by: NRonald S. Bultje <rsbultje@gmail.com>

Signed-off-by: NPaul B Mahol <onemda@gmail.com>
Signed-off-by: NRonald S. Bultje <rsbultje@gmail.com>

Parsing the entire NAL as SPS fixes decoding of some AVC bitstreams
with broken escaping. Since the size of the NAL unit is known and
checked against the buffer end we can parse it entirely without buffer
overreads.

Fixes playback of
http://streams.videolan.org/streams/mp4/Mr_MrsSmith-h264_aac.mp4Signed-off-by: NJanne Grunau <janne-libav@jannau.net>

Signed-off-by: NPaul B Mahol <onemda@gmail.com>
Signed-off-by: NJanne Grunau <janne-libav@jannau.net>

This reverts commit 729ebb2f.

There was an off-by-one error in the bit mask calculation clearing
actually the last valid bit and causing
http://bugzilla.libav.org/show_bug.cgi?id=227

The broken sample (Mr_MrsSmith-h264_aac.mp4) the commit was fixing
does not work after correcting the off-by-one error.

CC: libav-stable@libav.org

The were broken since August of 2010 without anyone noticing until
three weeks ago. Nobody cares about it anymore and hopefully Marvell
will support NEON like in the PXA978 from now on.

Signed-off-by: NPaul B Mahol <onemda@gmail.com>
Signed-off-by: NRonald S. Bultje <rsbultje@gmail.com>

Signed-off-by: NPaul B Mahol <onemda@gmail.com>
Signed-off-by: NRonald S. Bultje <rsbultje@gmail.com>

Using intreadwrite.h for this is overkill.
Signed-off-by: NPaul B Mahol <onemda@gmail.com>
Signed-off-by: NRonald S. Bultje <rsbultje@gmail.com>

Protects against overreads.
Signed-off-by: NPaul B Mahol <onemda@gmail.com>
Signed-off-by: NRonald S. Bultje <rsbultje@gmail.com>

Protects against overreads.
Signed-off-by: NPaul B Mahol <onemda@gmail.com>
Signed-off-by: NMartin Storsjö <martin@martin.st>

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org

MPC8 allows indices of mpc_CC up to -1, and mpc_SCF up to -6, thus pad
the tables by that much on the left end.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org