The function is used on unaligned buffers (such as those provided
by AVPacket), accessing them as uint16_t causes SIGBUS crashes on
architectures like SPARC.

This fixes ubsan runtime error: load of misaligned address for type
'const uint16_t', which requires 2 byte alignment
Signed-off-by: NAndreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
Signed-off-by: NLuca Barbato <lu_zero@gentoo.org>

Fixes runtime error: null pointer passed as argument 2, which is
declared to never be null
Signed-off-by: NAndreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
Signed-off-by: NAnton Khirnov <anton@khirnov.net>

This is used to check if the input buffer is larger enough, so if this
overflows it can cause a false negative leading to a segmentation fault
in bytestream2_get_bufferu.
Signed-off-by: NAndreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
Signed-off-by: NAnton Khirnov <anton@khirnov.net>

Signed-off-by: NAndreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
Signed-off-by: NAnton Khirnov <anton@khirnov.net>

More don't fit into the integer output.

Also use get_bits_long, since get_bits only supports reading up to 25
bits, while get_bits_long supports the full integer range.
Signed-off-by: NAndreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
Signed-off-by: NAnton Khirnov <anton@khirnov.net>

When there is a non-zero decoding delay due to reordering, the first dts
should be lower than the first pts (since the first packet fed to the
decoder does not produce any output).

Use the same scheme used in mpegvideo_enc (which comes from x264
originally) -- wait for first two timestamps and extrapolate linearly to
the past to produce the first dts value.

When B-frames are enabled and the encoder returns success, all currently
pending buffers immediately become valid and can be returned to the
caller. We can only return one packet at a time, so all the other
pending buffers should be transferred to a new 'ready' fifo, from where
they can be returned in subsequent calls (in which the encoder does not
produce any new output). This bug was hidden by the incorrect testing of
the encoder return value (the return value was overwritten before it was
tested).

Otherwise, closing the encoder can crash.

Change 'nvenc_<codec>' to '<codec>_nvenc', which is consistent with
other similar decoders and encoders (QSV, MMAL).

Return proper error codes and print more descriptive error messages.

This test does no encoding, setting the flag was done just to silence
the warning removed in the previous commit.

The AVStream codec context is often not (and should not be) the actual
encoding context, so this warning will be spurious in many cases.

Signed-off-by: NLuca Barbato <lu_zero@gentoo.org>

get_bit variant supporting 0-bits reads.
Signed-off-by: NLuca Barbato <lu_zero@gentoo.org>

Initialize the private class field and give the class a more
appropriate name. Add a class member to the codec context.

Signed-off-by: NVittorio Giovara <vittorio.giovara@gmail.com>

Signed-off-by: NVittorio Giovara <vittorio.giovara@gmail.com>

Signed-off-by: NLuca Barbato <lu_zero@gentoo.org>

This fixes builds with --disable-vfp.

Checking for the armv6 cpu flag is incorrect, since vfpv2 isn't
armv6 specific.
Signed-off-by: NMartin Storsjö <martin@martin.st>

This is disabled on iOS, since iOS uses a slightly different ABI
for vararg parameters.
Signed-off-by: NMartin Storsjö <martin@martin.st>

Use two separate functions, depending on whether VFP/NEON is available.

This is set to require armv5te - it uses blx, which is only available
since armv5t, but we don't have a separate configure item for that.
(It also uses ldrd, which requires armv5te, but this could be avoided
if necessary.)
Signed-off-by: NMartin Storsjö <martin@martin.st>

The previous check only caught sizes from -AV_INPUT_BUFFER_PADDING_SIZE
to -1.

This fixes ubsan runtime error: signed integer overflow: 2147483647 + 32
cannot be represented in type 'int'
Signed-off-by: NAndreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
Signed-off-by: NAnton Khirnov <anton@khirnov.net>

Signed-off-by: NAnton Khirnov <anton@khirnov.net>

Both avio_skip and detect_unknown_subobject use int64_t for the size
parameter.

This fixes a segmentation fault due to infinite recursion.
Signed-off-by: NAndreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
Signed-off-by: NAlexandra Hájková <alexandra.khirnova@gmail.com>
Signed-off-by: NAnton Khirnov <anton@khirnov.net>

Otherwise invalid values are used unchecked in the next run.
This can cause NULL pointer dereferencing.
Signed-off-by: NAndreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
Signed-off-by: NAlexandra Hájková <alexandra.khirnova@gmail.com>
Signed-off-by: NAnton Khirnov <anton@khirnov.net>

This makes sure all the frames are returned at the end.
Found-By: NMaxym Dmytrychenko <maxym.dmytrychenko@intel.com>

Same as what is done in 3b6473b4.
Signed-off-by: NAnton Khirnov <anton@khirnov.net>

EAGAIN is already managed in poll_filters().
Signed-off-by: NLuca Barbato <lu_zero@gentoo.org>

Signed-off-by: NLuca Barbato <lu_zero@gentoo.org>

Signed-off-by: NAnton Khirnov <anton@khirnov.net>

Use 8 B-frames and modify the GOP size to be a multiple of the B-frame
count.
Signed-off-by: NAnton Khirnov <anton@khirnov.net>

Before 741b494f, when the reference list
modification description was invalid, the code would substitute the
corresponding reference from the initial ("default") reference list.
After that commit, it will just return an error.

Since there are apparently invalid samples in the wild that used to play
fine with the old code, it is a good idea to re-add some sort of error
resilience here. So, when the reference list modification results in a
missing frame, substitute a previous reference frame for it. The
relevant sample again decodes fine with the same output as previously.

Signed-off-by: NJanne Grunau <janne-libav@jannau.net>

Intel's Instruction Set Reference (as of September 2015) clearly states
that cvtpi2ps switches to MMX state. Actual CPUs do not switch if the
source is a memory location. The Instruction Set Reference from 1999
(Order Number 243191) describes this behaviour but all later versions
I've seen have make no distinction whether MMX registers or memory is
used as source.
The documentation for the matching SSE2 instruction to convert to double
(cvtpi2pd) was fixed (see the valgrind bug
https://bugs.kde.org/show_bug.cgi?id=210264).

It will take time to get a clarification and fixes in place. In the
meantime it makes sense to change ff_int32_to_float_fmul_scalar_sse to
be correct according to the documentation. The vast majority of users
will have SSE2 so a change to the SSE version has little effect.

Fixes fate-checkasm on x86 valgrind targets.

Valgrind 'bug' reported as https://bugs.kde.org/show_bug.cgi?id=357059

Check the full FPU tag word instead of only the lower half and simplify
the comparison.
Use upper-case function base name as macro name to instantiate both
checked_call variants.