The change was wrong, also add a comment explaining it

Found-by: BBB
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

Signed-off-by: NKyle Swanson <k@ylo.ph>

Signed-off-by: NPaul B Mahol <onemda@gmail.com>

Commit 7404f3bd switched bitrate to 64 bits.
This triggers -Wabsolute-value on clang, e.g
http://fate.ffmpeg.org/log.cgi?time=20150917122742&log=compile&slot=x86_64-darwin-clang-3.7-O3.
Therefore, usage of abs is changed to llabs, which is available on all of the platforms.
Unfortunately, LLONG_MAX is not always available, so INT64_MAX is used instead.
Signed-off-by: NGanesh Ajjanagadde <gajjanagadde@gmail.com>
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

This silences -Wunused-variable when compiled with --disable-mmx, e.g
http://fate.ffmpeg.org/log.cgi?time=20150919094617&log=compile&slot=x86_64-archlinux-gcc-disable-mmx.
The alternative of header guards will make it far too ugly.
Signed-off-by: NGanesh Ajjanagadde <gajjanagadde@gmail.com>
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

The sample position is made weird and non-nominal to force catching
such issues as default values or specialized operations hiding
issues in corner cases.
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

For yuv420p, the chroma position is unilaterally overriden, even
if ffmpeg's command-line explicitly set it. To fix this, override
only if the value is the default one.

Regression since 1515bfb3.
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

Signed-off-by: NPaul B Mahol <onemda@gmail.com>

Signed-off-by: NTimo Rothenpieler <timo@rothenpieler.org>

Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

Signed-off-by: NPaul B Mahol <onemda@gmail.com>

Signed-off-by: NPaul B Mahol <onemda@gmail.com>

This patch modifies the encode frame function to
retry encoding the frame when the resulting bit count
is too far off target, but only adjusting lambda
in small, incremental step. It also makes the logic
more conservative - otherwise it will contend with
bit reservoir-related variations in bit allocation,
and result in artifacts when frame have to be truncated
(usually at high bit rates transitioning from low
complexity to high complexity).

Trivial change to simplify the small but hot
find_min_book function. The new form is easier to
understand and faster.

Binutils will always strip the relocation information from executable
files even if it needs it (dynamicbase/ASLR).  We can work around this
by using the pic-executable flag combined with setting the correct entry
point since apparently ld forgets what that should be.  This problem
affects both 32 and 64-bit mingw-w64.
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

This silences -Wunused-variable when compiled with --disable-mmx, e.g
http://fate.ffmpeg.org/log.cgi?time=20150919094617&log=compile&slot=x86_64-archlinux-gcc-disable-mmx.
The alternative of header guards will make it far too ugly.
Signed-off-by: NGanesh Ajjanagadde <gajjanagadde@gmail.com>
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

This silences -Wunused-variable when compiled with --disable-mmx, e.g
http://fate.ffmpeg.org/log.cgi?time=20150919094617&log=compile&slot=x86_64-archlinux-gcc-disable-mmx.
The alternative of header guards will make it far too ugly.
Signed-off-by: NGanesh Ajjanagadde <gajjanagadde@gmail.com>
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

avfilter/hermite: fix "libavfilter/hermite.h:19:15: error: no previous prototype for hermite_interpolation"

Fix build
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

Signed-off-by: NPaul B Mahol <onemda@gmail.com>

Reduces the number of times the vbv retry code is used and should have no
effect on quality
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

If there is no #EXT-X-BYTERANGE specified, there is no need to seek.
Seeking fails anyway for rtmp, because this protocol does not support
url_seek.

This fixes CNN.m3u from trac ticket 4797 (i.e. Debian bug #798189).
Reviewed-by: Nwm4 <nfxjfg@googlemail.com>
Signed-off-by: NAndreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

If cmd_pos is broken, this would just keep accumulating packets in the
reassembly buffer, until it fails and flushes the buffer on overflow.
Since packets are usually rather small, this will take a lot of subtitle
packets. The perceived effect is that subtitles are not displayed
anymore after the faulty packet was passed to the decoder.

I'm not terribly sure about this, but on the other hand this code is
active only when fragmented packets need to be reassembled.

Fixes sample file in trac issue #4872.

Assuming the first and second packets are partial, this would append the
reassembly buffer (ctx->buf) to itself with the second
append_to_cached_buf() call, because buf is set to ctx->buf.

I do not know a valid sample file which triggers this, and do not know
if packets can be split into more than 2 sub-packets, but it triggered
with a (differently) broken sample file in trac issue #4872.

Broken by commit ba12ba85. This only
happens with HLS streams which use encryption and require preserving
cookies sent by the server.

Fixes trac issue #4846.

Signed-off-by: NKyle Swanson <k@ylo.ph>

My old address no longer works.
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

Fixes ticket 4258.

(I forgot to actually merge them into the patch I just pushed.)

Signed-off-by: NJames Almer <jamrial@gmail.com>

Fixes make checkheaders
Signed-off-by: NJames Almer <jamrial@gmail.com>

Duplicates are perfectly legitimate with this format. A correct
renderer will typically show them stacked.

Some .idx files actually contain duplicate subtitle events:

timestamp: 00:07:52:600, filepos: 00004e800
timestamp: 00:07:52:600, filepos: 00004f800

The second will be dropped, because it has same pts, duration, and text
(the text is just a dummy empty string; the real data is retrieved when
actually reading vobsub subtitle packets).

Dropping this is probably not intended/safe, so avoid it.

See trac issue #4872 for a sample. This patch doesn't fix decoding of
the sample, though.

The stream ID is essentially an arbitrary number defined by the .idx
file headers. They have to match the IDs in the .sub stream. The vobsub
demuxer assumed the IDs would just start from 0, increassing by 1 for
each stream. This is not correct. In the sample I had, the IDs were
starting from 1, leading to no subtitles being displayed at all.

Fix this by using the correct stream ID.
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

If tput is not found for colorizing, error message should be squashed.
Signed-off-by: NGanesh Ajjanagadde <gajjanagadde@gmail.com>
Signed-off-by: NMichael Niedermayer <michael@niedermayer.cc>

Signed-off-by: NJames Almer <jamrial@gmail.com>