1. 17 5月, 2011 2 次提交
  2. 16 5月, 2011 1 次提交
  3. 15 5月, 2011 2 次提交
  4. 14 5月, 2011 2 次提交
  5. 13 5月, 2011 5 次提交
  6. 12 5月, 2011 3 次提交
    • B
      sfc: Always map MCDI shared memory as uncacheable · 747df225
      Ben Hutchings 提交于
      We enabled write-combining for memory-mapped registers in commit
      65f0b417, but inhibited it for the
      MCDI shared memory where this is not supported.  However,
      write-combining mappings also allow read-reordering, which may also
      be a problem.
      
      I found that when an SFC9000-family controller is connected to an
      Intel 3000 chipset, and write-combining is enabled, the controller
      stops responding to PCIe read requests during driver initialisation
      while the driver is polling for completion of an MCDI command.  This
      results in an NMI and system hang.  Adding read memory barriers
      between all reads to the shared memory area appears to reduce but not
      eliminate the probability of this.
      
      We have not yet established whether this is a bug in our BIU or in the
      PCIe bridge.  For now, work around by mapping the shared memory area
      separately.
      Signed-off-by: NBen Hutchings <bhutchings@solarflare.com>
      747df225
    • A
      ehea: Fix memory hotplug oops · 21ccc793
      Anton Blanchard 提交于
      The ehea driver oopses during memory hotplug if the ports are not
      up. A simple testcase:
      
      # ifconfig ethX down
      # echo offline > /sys/devices/system/memory/memory32/state
      
      Oops: Kernel access of bad area, sig: 11 [#1]
      last sysfs file: /sys/devices/system/memory/memory32/state
      REGS: c000000709393110 TRAP: 0300   Not tainted  (2.6.39-rc2-01385-g7ef73bca-dirty)
      DAR: 0000000000000000, DSISR: 40000000
      ...
      NIP [c000000000067c98] .__wake_up_common+0x48/0xf0
      LR [c00000000006d034] .__wake_up+0x54/0x90
      Call Trace:
      [c00000000006d034] .__wake_up+0x54/0x90
      [d000000006bb6270] .ehea_rereg_mrs+0x140/0x730 [ehea]
      [d000000006bb69c4] .ehea_mem_notifier+0x164/0x170 [ehea]
      [c0000000006fc8a8] .notifier_call_chain+0x78/0xf0
      [c0000000000b3d70] .__blocking_notifier_call_chain+0x70/0xb0
      [c000000000458d78] .memory_notify+0x28/0x40
      [c0000000001871d8] .remove_memory+0x208/0x6d0
      [c000000000458264] .memory_section_action+0x94/0x140
      [c0000000004583ec] .memory_block_change_state+0xdc/0x1d0
      [c0000000004585cc] .store_mem_state+0xec/0x160
      [c00000000044768c] .sysdev_store+0x3c/0x50
      [c00000000020b48c] .sysfs_write_file+0xec/0x1f0
      [c00000000018f86c] .vfs_write+0xec/0x1e0
      [c00000000018fa88] .SyS_write+0x58/0xd0
      
      To fix this, initialise the waitqueues during port probe instead
      of port open.
      Signed-off-by: NAnton Blanchard <anton@samba.org>
      Cc: stable@kernel.org
      Acked-by: NBreno Leitao <leitao@linux.vnet.ibm.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      21ccc793
    • D
  7. 11 5月, 2011 11 次提交
    • D
    • O
      slcan: fix ldisc->open retval · 0d4420a9
      Oliver Hartkopp 提交于
      TTY layer expects 0 if the ldisc->open operation succeeded.
      Reported-by: NMatvejchikov Ilya <matvejchikov@gmail.com>
      Signed-off-by: NOliver Hartkopp <socketcan@hartkopp.net>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      0d4420a9
    • D
      net/usb: mark LG VL600 LTE modem ethernet interface as WWAN · aae1e743
      Dan Williams 提交于
      Like other mobile broadband device ethernet interfaces, mark the LG
      VL600 with the 'wwan' devtype so userspace knows it needs additional
      configuration via the AT port before the interface can be used.
      Signed-off-by: NDan Williams <dcbw@redhat.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      aae1e743
    • S
      xfrm: Don't allow esn with disabled anti replay detection · 6fa5ddcc
      Steffen Klassert 提交于
      Unlike the standard case, disabled anti replay detection needs some
      nontrivial extra treatment on ESN. RFC 4303 states:
      
      Note: If a receiver chooses to not enable anti-replay for an SA, then
      the receiver SHOULD NOT negotiate ESN in an SA management protocol.
      Use of ESN creates a need for the receiver to manage the anti-replay
      window (in order to determine the correct value for the high-order
      bits of the ESN, which are employed in the ICV computation), which is
      generally contrary to the notion of disabling anti-replay for an SA.
      
      So return an error if an ESN state with disabled anti replay detection
      is inserted for now and add the extra treatment later if we need it.
      Signed-off-by: NSteffen Klassert <steffen.klassert@secunet.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      6fa5ddcc
    • S
      xfrm: Assign the inner mode output function to the dst entry · 43a4dea4
      Steffen Klassert 提交于
      As it is, we assign the outer modes output function to the dst entry
      when we create the xfrm bundle. This leads to two problems on interfamily
      scenarios. We might insert ipv4 packets into ip6_fragment when called
      from xfrm6_output. The system crashes if we try to fragment an ipv4
      packet with ip6_fragment. This issue was introduced with git commit
      ad0081e4 (ipv6: Fragment locally generated tunnel-mode IPSec6 packets
      as needed). The second issue is, that we might insert ipv4 packets in
      netfilter6 and vice versa on interfamily scenarios.
      
      With this patch we assign the inner mode output function to the dst entry
      when we create the xfrm bundle. So xfrm4_output/xfrm6_output from the inner
      mode is used and the right fragmentation and netfilter functions are called.
      We switch then to outer mode with the output_finish functions.
      Signed-off-by: NSteffen Klassert <steffen.klassert@secunet.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      43a4dea4
    • E
      net: dev_close() should check IFF_UP · e14a5993
      Eric Dumazet 提交于
      Commit 44345724 (factorize sync-rcu call in
      unregister_netdevice_many) mistakenly removed one test from dev_close()
      
      Following actions trigger a BUG :
      
      modprobe bonding
      modprobe dummy
      ifconfig bond0 up
      ifenslave bond0 dummy0
      rmmod dummy
      
      dev_close() must not close a non IFF_UP device.
      
      With help from Frank Blaschka and Einar EL Lueck
      Reported-by: NFrank Blaschka <blaschka@linux.vnet.ibm.com>
      Reported-by: NEinar EL Lueck <ELELUECK@de.ibm.com>
      Signed-off-by: NEric Dumazet <eric.dumazet@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      e14a5993
    • E
      vlan: fix GVRP at dismantle time · 55aee10d
      Eric Dumazet 提交于
      ip link add link eth2 eth2.103 type vlan id 103 gvrp on loose_binding on
      ip link set eth2.103 up
      rmmod tg3    # driver providing eth2
      
       BUG: unable to handle kernel NULL pointer dereference at           (null)
       IP: [<ffffffffa0030c9e>] garp_request_leave+0x3e/0xc0 [garp]
       PGD 11d251067 PUD 11b9e0067 PMD 0
       Oops: 0000 [#1] SMP
       last sysfs file: /sys/devices/virtual/net/eth2.104/ifindex
       CPU 0
       Modules linked in: tg3(-) 8021q garp nfsd lockd auth_rpcgss sunrpc libphy sg [last unloaded: x_tables]
      
       Pid: 11494, comm: rmmod Tainted: G        W   2.6.39-rc6-00261-gfd71257-dirty #580 HP ProLiant BL460c G6
       RIP: 0010:[<ffffffffa0030c9e>]  [<ffffffffa0030c9e>] garp_request_leave+0x3e/0xc0 [garp]
       RSP: 0018:ffff88007a19bae8  EFLAGS: 00010286
       RAX: 0000000000000000 RBX: ffff88011b5e2000 RCX: 0000000000000002
       RDX: 0000000000000000 RSI: 0000000000000175 RDI: ffffffffa0030d5b
       RBP: ffff88007a19bb18 R08: 0000000000000001 R09: ffff88011bd64a00
       R10: ffff88011d34ec00 R11: 0000000000000000 R12: 0000000000000002
       R13: ffff88007a19bc48 R14: ffff88007a19bb88 R15: 0000000000000001
       FS:  0000000000000000(0000) GS:ffff88011fc00000(0063) knlGS:00000000f77d76c0
       CS:  0010 DS: 002b ES: 002b CR0: 000000008005003b
       CR2: 0000000000000000 CR3: 000000011a675000 CR4: 00000000000006f0
       DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
       DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
       Process rmmod (pid: 11494, threadinfo ffff88007a19a000, task ffff8800798595c0)
       Stack:
        ffff88007a19bb36 ffff88011c84b800 ffff88011b5e2000 ffff88007a19bc48
        ffff88007a19bb88 0000000000000006 ffff88007a19bb38 ffffffffa003a5f6
        ffff88007a19bb38 670088007a19bba8 ffff88007a19bb58 ffffffffa00397e7
       Call Trace:
        [<ffffffffa003a5f6>] vlan_gvrp_request_leave+0x46/0x50 [8021q]
        [<ffffffffa00397e7>] vlan_dev_stop+0xb7/0xc0 [8021q]
        [<ffffffff8137e427>] __dev_close_many+0x87/0xe0
        [<ffffffff8137e507>] dev_close_many+0x87/0x110
        [<ffffffff8137e630>] rollback_registered_many+0xa0/0x240
        [<ffffffff8137e7e9>] unregister_netdevice_many+0x19/0x60
        [<ffffffffa00389eb>] vlan_device_event+0x53b/0x550 [8021q]
        [<ffffffff8143f448>] ? ip6mr_device_event+0xa8/0xd0
        [<ffffffff81479d03>] notifier_call_chain+0x53/0x80
        [<ffffffff81062539>] __raw_notifier_call_chain+0x9/0x10
        [<ffffffff81062551>] raw_notifier_call_chain+0x11/0x20
        [<ffffffff8137df82>] call_netdevice_notifiers+0x32/0x60
        [<ffffffff8137e69f>] rollback_registered_many+0x10f/0x240
        [<ffffffff8137e85f>] rollback_registered+0x2f/0x40
        [<ffffffff8137e8c8>] unregister_netdevice_queue+0x58/0x90
        [<ffffffff8137e9eb>] unregister_netdev+0x1b/0x30
        [<ffffffffa005d73f>] tg3_remove_one+0x6f/0x10b [tg3]
      
      We should call vlan_gvrp_request_leave() from unregister_vlan_dev(),
      not from vlan_dev_stop(), because vlan_gvrp_uninit_applicant()
      is called right after unregister_netdevice_queue(). In batch mode,
      unregister_netdevice_queue() doesn’t immediately call vlan_dev_stop().
      Signed-off-by: NEric Dumazet <eric.dumazet@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      55aee10d
    • P
      libertas: fix cmdpendingq locking · 2ae1b8b3
      Paul Fox 提交于
      We occasionally see list corruption using libertas.
      
      While we haven't been able to diagnose this precisely, we have spotted
      a possible cause: cmdpendingq is generally modified with driver_lock
      held. However, there are a couple of points where this is not the case.
      
      Fix up those operations to execute under the lock, it seems like
      the correct thing to do and will hopefully improve the situation.
      Signed-off-by: NPaul Fox <pgf@laptop.org>
      Signed-off-by: NDaniel Drake <dsd@laptop.org>
      Acked-by: NDan Williams <dcbw@redhat.com>
      Cc: stable@kernel.org
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      2ae1b8b3
    • S
      iwlegacy: fix IBSS mode crashes · eb85de3f
      Stanislaw Gruszka 提交于
      We should not switch to non-IBSS channels when working in IBSS mode,
      otherwise there are microcode errors, and after some time system
      crashes.
      
      This bug is only observable when software scan is used in IBSS mode,
      so should be considered as regression after:
      
      commit 0263aa45
      Author: Stanislaw Gruszka <sgruszka@redhat.com>
      Date:   Tue Mar 29 11:24:21 2011 +0200
      
          iwl3945: disable hw scan by default
      
      However IBSS mode check, which this patch add again, was removed by
      
      commit b2f30e8b
      Author: Johannes Berg <johannes.berg@intel.com>
      Date:   Thu Jan 21 07:32:20 2010 -0800
      
          iwlwifi: remove IBSS channel sanity check
      
      That commit claim that mac80211 will not use non-IBSS channel in IBSS
      mode, what definitely is not true. Bug probably should be fixed in
      mac80211, but that will require more work, so better to apply that patch
      temporally, and provide proper mac80211 fix latter.
      
      Resolves:
      https://bugzilla.kernel.org/show_bug.cgi?id=34452Reported-and-tested-by: NMikko Rapeli <mikko.rapeli@iki.fi>
      Cc: stable@kernel.org # 2.6.38.5+
      Signed-off-by: NStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      eb85de3f
    • M
      ath9k: Fix a warning due to a queued work during S3 state · 99aa55b6
      Mohammed Shafi Shajakhan 提交于
      during suspend/S3 state drv_flush is called from mac80211 irrespective of
      interface count. In ath9k we queue a work in ath9k_flush which we expect
      to be cancelled in the drv_stop call back. during suspend process mac80211
      calls drv_stop only when the interface count(local->count) is non-zero.
      unfortunately when the network manager is enabled, drv_flush is called
      while drv_stop is not called as local->count reaches '0'.
      	So fix this by simply checking for the device presence in the
      drv_flush call back in the driver before queueing work or anything else.
      this patch fixes the following WARNING
      
      	Call Trace:
      	[<c014c6e2>] warn_slowpath_common+0x72/0xa0
      	[<fc133f99>] ? ieee80211_can_queue_work+0x39/0x50 [mac80211]
      	[<fc133f99>] ? ieee80211_can_queue_work+0x39/0x50 [mac80211]
      	[<c014c75b>] warn_slowpath_fmt+0x2b/0x30
      	[<fc133f99>] ieee80211_can_queue_work+0x39/0x50 [mac80211]
      	[<fc134ed1>] ieee80211_queue_delayed_work+0x21/0x50 [mac80211]
      	[<fc1e5b22>] ath_tx_complete_poll_work+0xb2/0x100 [ath9k]
      	[<c016399e>] run_workqueue+0x8e/0x150
      	[<fc1e5a70>] ? ath_tx_complete_poll_work+0x0/0x100 [ath9k]
      	[<c0163ae4>] worker_thread+0x84/0xe0
      	[<c0167a60>] ? autoremove_wake_function+0x0/0x50
      	[<c0163a60>] ? worker_thread+0x0/0xe0
      	[<c01677d4>] kthread+0x74/0x80
      	[<c0167760>] ? kthread+0x0/0x80
      	[<c0104087>] kernel_thread_helper+0x7/0x10
      ---[ end trace 2aff81010df9215b ]---
      Signed-off-by: NRajkumar Manoharan <rmanoharan@atheros.com>
      Signed-off-by: NMohammed Shafi Shajakhan <mshajakhan@atheros.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      99aa55b6
    • L
      mac80211: don't start the dynamic ps timer if not associated · 5db1c07c
      Luciano Coelho 提交于
      When we are disconnecting, we set PS off, but this happens before we
      send the deauth/disassoc request.  When the deauth/disassoc frames are
      sent, we trigger the dynamic ps timer, which then times out and turns
      PS back on.  Thus, PS remains on after disconnecting, causing problems
      when associating again.
      
      This can be fixed by preventing the timer to start when we're not
      associated anymore.
      Signed-off-by: NLuciano Coelho <coelho@ti.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      5db1c07c
  8. 10 5月, 2011 14 次提交