1. 17 6月, 2007 2 次提交
    • P
      tty: restore locked ioctl file op · 38ad2ed0
      Paul Fulghum 提交于
      Restore tty locked ioctl handler which was replaced with
      an unlocked ioctl handler in hung_up_tty_fops by the patch:
      
      commit e10cc1df
      Author: Paul Fulghum <paulkf@microgate.com>
      Date:   Thu May 10 22:22:50 2007 -0700
      
          tty: add compat_ioctl
      
      This was reported in:
      [Bug 8473] New: Oops: 0010 [1] SMP
      
      The bug is caused by switching to hung_up_tty_fops in do_tty_hangup.  An
      ioctl call can be waiting on BLK after testing for existence of the locked
      ioctl handler in the normal tty fops, but before calling the locked ioctl
      handler.  If a hangup occurs at that point, the locked ioctl fop is NULL
      and an oops occurs.
      
      (akpm: we can remove my debugging code from do_ioctl() now, but it'll be OK to
      do that for 2.6.23)
      Signed-off-by: NPaul Fulghum <paulkf@microgate.com>
      Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      38ad2ed0
    • D
      fix radeon setparam on 32/64 systems, harder. · f4d27817
      David Woodhouse 提交于
      Commit 9b01bd5b introduced a
      compat_ioctl handler for RADEON_SETPARAM, the sole purpose of which was
      to handle the fact that on i386, alignof(uint64_t)==4.
      
      Unfortunately, this handler was installed for _all_ 64-bit
      architectures, instead of only x86_64 and ia64.  And thus it breaks
      32-bit compatibility on every other arch, where 64-bit integers are
      aligned to 8 bytes in 32-bit mode just the same as in 64-bit mode.
      
      Arnd has a cunning plan to use 'compat_u64' with appropriate alignment
      attributes according to the 32-bit ABI, but for now let's just make the
      compat_radeon_cp_setparam routine entirely disappear on 64-bit machines
      whose 32-bit compat support isn't for i386.  It would be a no-op with
      compat_u64 anyway.
      Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>
      Acked-by: NArnd Bergmann <arnd@arndb.de>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Dave Airlie <airlied@gmail.com>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      f4d27817
  2. 16 6月, 2007 14 次提交
  3. 15 6月, 2007 23 次提交
  4. 14 6月, 2007 1 次提交