提交 80322143 编写于 作者: J Julia Lawall 提交者: Benjamin Herrenschmidt

i2c/i2c-pasemi.c: Fix unsigned return type

The function has an unsigned return type, but returns a negative constant
to indicate an error condition.  The result of calling the function is
always stored in a variable of type (signed) int, and thus unsigned can be
dropped from the return type.

A sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@exists@
identifier f;
constant C;
@@

 unsigned f(...)
 { <+...
*  return -C;
 ...+> }
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Acked-by: NOlof Johansson <olof@lixom.net>
Signed-off-by: NBenjamin Herrenschmidt <benh@kernel.crashing.org>
上级 a655237f
...@@ -88,7 +88,7 @@ static void pasemi_smb_clear(struct pasemi_smbus *smbus) ...@@ -88,7 +88,7 @@ static void pasemi_smb_clear(struct pasemi_smbus *smbus)
reg_write(smbus, REG_SMSTA, status); reg_write(smbus, REG_SMSTA, status);
} }
static unsigned int pasemi_smb_waitready(struct pasemi_smbus *smbus) static int pasemi_smb_waitready(struct pasemi_smbus *smbus)
{ {
int timeout = 10; int timeout = 10;
unsigned int status; unsigned int status;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册