提交 3c5b2673 编写于 作者: C Carlos Palminha 提交者: Daniel Vetter

drm: fixes crct set_mode when encoder mode_fixup is null.

Avoids null crash when encoders don't implement mode_fixup.
Signed-off-by: NCarlos Palminha <palminha@synopsys.com>
[danvet: Also update kerneldoc.]
Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1455106522-32307-1-git-send-email-palminha@synopsys.com
上级 71dfb744
...@@ -337,10 +337,12 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc, ...@@ -337,10 +337,12 @@ bool drm_crtc_helper_set_mode(struct drm_crtc *crtc,
} }
encoder_funcs = encoder->helper_private; encoder_funcs = encoder->helper_private;
if (!(ret = encoder_funcs->mode_fixup(encoder, mode, if (encoder_funcs->mode_fixup) {
adjusted_mode))) { if (!(ret = encoder_funcs->mode_fixup(encoder, mode,
DRM_DEBUG_KMS("Encoder fixup failed\n"); adjusted_mode))) {
goto done; DRM_DEBUG_KMS("Encoder fixup failed\n");
goto done;
}
} }
} }
......
...@@ -439,7 +439,7 @@ struct drm_encoder_helper_funcs { ...@@ -439,7 +439,7 @@ struct drm_encoder_helper_funcs {
* can be modified by this callback and does not need to match mode. * can be modified by this callback and does not need to match mode.
* *
* This function is used by both legacy CRTC helpers and atomic helpers. * This function is used by both legacy CRTC helpers and atomic helpers.
* With atomic helpers it is optional. * This hook is optional.
* *
* NOTE: * NOTE:
* *
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册