rc80211_pid_algo.c 17.0 KB
Newer Older
1 2 3 4
/*
 * Copyright 2002-2005, Instant802 Networks, Inc.
 * Copyright 2005, Devicescape Software, Inc.
 * Copyright 2007, Mattias Nissler <mattias.nissler@gmx.de>
5
 * Copyright 2007-2008, Stefano Brivio <stefano.brivio@polimi.it>
6 7 8 9 10 11 12 13 14
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License version 2 as
 * published by the Free Software Foundation.
 */

#include <linux/netdevice.h>
#include <linux/types.h>
#include <linux/skbuff.h>
15
#include <linux/debugfs.h>
16 17
#include <net/mac80211.h>
#include "ieee80211_rate.h"
18
#include "mesh.h"
M
Mattias Nissler 已提交
19 20
#include "rc80211_pid.h"

21 22 23 24 25 26 27

/* This is an implementation of a TX rate control algorithm that uses a PID
 * controller. Given a target failed frames rate, the controller decides about
 * TX rate changes to meet the target failed frames rate.
 *
 * The controller basically computes the following:
 *
28
 * adj = CP * err + CI * err_avg + CD * (err - last_err) * (1 + sharpening)
29 30 31 32 33 34
 *
 * where
 * 	adj	adjustment value that is used to switch TX rate (see below)
 * 	err	current error: target vs. current failed frames percentage
 * 	last_err	last error
 * 	err_avg	average (i.e. poor man's integral) of recent errors
35 36 37
 *	sharpening	non-zero when fast response is needed (i.e. right after
 *			association or no frames sent for a long time), heading
 * 			to zero over time
38 39 40 41 42 43 44 45 46 47
 * 	CP	Proportional coefficient
 * 	CI	Integral coefficient
 * 	CD	Derivative coefficient
 *
 * CP, CI, CD are subject to careful tuning.
 *
 * The integral component uses a exponential moving average approach instead of
 * an actual sliding window. The advantage is that we don't need to keep an
 * array of the last N error values and computation is easier.
 *
48 49 50 51 52 53 54 55 56 57 58 59
 * Once we have the adj value, we map it to a rate by means of a learning
 * algorithm. This algorithm keeps the state of the percentual failed frames
 * difference between rates. The behaviour of the lowest available rate is kept
 * as a reference value, and every time we switch between two rates, we compute
 * the difference between the failed frames each rate exhibited. By doing so,
 * we compare behaviours which different rates exhibited in adjacent timeslices,
 * thus the comparison is minimally affected by external conditions. This
 * difference gets propagated to the whole set of measurements, so that the
 * reference is always the same. Periodically, we normalize this set so that
 * recent events weigh the most. By comparing the adj value with this set, we
 * avoid pejorative switches to lower rates and allow for switches to higher
 * rates if they behaved well.
60 61 62 63 64 65 66
 *
 * Note that for the computations we use a fixed-point representation to avoid
 * floating point arithmetic. Hence, all values are shifted left by
 * RC_PID_ARITH_SHIFT.
 */


67 68 69 70
/* Adjust the rate while ensuring that we won't switch to a lower rate if it
 * exhibited a worse failed frames behaviour and we'll choose the highest rate
 * whose failed frames behaviour is not worse than the one of the original rate
 * target. While at it, check that the new rate is valid. */
71
static void rate_control_pid_adjust_rate(struct ieee80211_local *local,
72 73
					 struct sta_info *sta, int adj,
					 struct rc_pid_rateinfo *rinfo)
74 75
{
	struct ieee80211_sub_if_data *sdata;
76
	struct ieee80211_supported_band *sband;
77 78
	int cur_sorted, new_sorted, probe, tmp, n_bitrates, band;
	int cur = sta->txrate_idx;
79 80

	sdata = IEEE80211_DEV_TO_SUB_IF(sta->dev);
81
	sband = local->hw.wiphy->bands[local->hw.conf.channel->band];
82 83
	band = sband->band;
	n_bitrates = sband->n_bitrates;
84

85 86 87
	/* Map passed arguments to sorted values. */
	cur_sorted = rinfo[cur].rev_index;
	new_sorted = cur_sorted + adj;
88

89 90 91 92 93 94 95
	/* Check limits. */
	if (new_sorted < 0)
		new_sorted = rinfo[0].rev_index;
	else if (new_sorted >= n_bitrates)
		new_sorted = rinfo[n_bitrates - 1].rev_index;

	tmp = new_sorted;
96

97 98 99 100 101 102 103 104 105 106 107 108
	if (adj < 0) {
		/* Ensure that the rate decrease isn't disadvantageous. */
		for (probe = cur_sorted; probe >= new_sorted; probe--)
			if (rinfo[probe].diff <= rinfo[cur_sorted].diff &&
			    rate_supported(sta, band, rinfo[probe].index))
				tmp = probe;
	} else {
		/* Look for rate increase with zero (or below) cost. */
		for (probe = new_sorted + 1; probe < n_bitrates; probe++)
			if (rinfo[probe].diff <= rinfo[new_sorted].diff &&
			    rate_supported(sta, band, rinfo[probe].index))
				tmp = probe;
109
	}
M
Mattias Nissler 已提交
110

111 112 113 114 115 116 117 118 119 120 121 122
	/* Fit the rate found to the nearest supported rate. */
	do {
		if (rate_supported(sta, band, rinfo[tmp].index)) {
			sta->txrate_idx = rinfo[tmp].index;
			break;
		}
		if (adj < 0)
			tmp--;
		else
			tmp++;
	} while (tmp < n_bitrates && tmp >= 0);

M
Mattias Nissler 已提交
123 124 125
#ifdef CONFIG_MAC80211_DEBUGFS
	rate_control_pid_event_rate_change(
		&((struct rc_pid_sta_info *)sta->rate_ctrl_priv)->events,
126
		sta->txrate_idx, sband->bitrates[sta->txrate_idx].bitrate);
M
Mattias Nissler 已提交
127
#endif
128 129
}

130
/* Normalize the failed frames per-rate differences. */
131
static void rate_control_pid_normalize(struct rc_pid_info *pinfo, int l)
132
{
133 134
	int i, norm_offset = pinfo->norm_offset;
	struct rc_pid_rateinfo *r = pinfo->rinfo;
135

136 137 138 139
	if (r[0].diff > norm_offset)
		r[0].diff -= norm_offset;
	else if (r[0].diff < -norm_offset)
		r[0].diff += norm_offset;
140
	for (i = 0; i < l - 1; i++)
141 142
		if (r[i + 1].diff > r[i].diff + norm_offset)
			r[i + 1].diff -= norm_offset;
143
		else if (r[i + 1].diff <= r[i].diff)
144
			r[i + 1].diff += norm_offset;
145 146
}

147 148 149 150
static void rate_control_pid_sample(struct rc_pid_info *pinfo,
				    struct ieee80211_local *local,
				    struct sta_info *sta)
{
151 152 153
#ifdef CONFIG_MAC80211_MESH
	struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(sta->dev);
#endif
154
	struct rc_pid_sta_info *spinfo = sta->rate_ctrl_priv;
155
	struct rc_pid_rateinfo *rinfo = pinfo->rinfo;
156
	struct ieee80211_supported_band *sband;
157 158
	u32 pf;
	s32 err_avg;
159 160 161
	u32 err_prop;
	u32 err_int;
	u32 err_der;
162
	int adj, i, j, tmp;
163
	unsigned long period;
164

165
	sband = local->hw.wiphy->bands[local->hw.conf.channel->band];
166
	spinfo = sta->rate_ctrl_priv;
167 168 169

	/* In case nothing happened during the previous control interval, turn
	 * the sharpening factor on. */
170 171 172 173 174
	period = (HZ * pinfo->sampling_period + 500) / 1000;
	if (!period)
		period = 1;
	if (jiffies - spinfo->last_sample > 2 * period)
		spinfo->sharp_cnt = pinfo->sharpen_duration;
175

176 177
	spinfo->last_sample = jiffies;

178
	/* This should never happen, but in case, we assume the old sample is
179
	 * still a good measurement and copy it. */
180
	if (unlikely(spinfo->tx_num_xmit == 0))
181 182 183
		pf = spinfo->last_pf;
	else {
		pf = spinfo->tx_num_failed * 100 / spinfo->tx_num_xmit;
184 185 186 187 188
#ifdef CONFIG_MAC80211_MESH
		if (pf == 100 &&
		    sdata->vif.type == IEEE80211_IF_TYPE_MESH_POINT)
			mesh_plink_broken(sta);
#endif
189
		pf <<= RC_PID_ARITH_SHIFT;
190 191
		sta->fail_avg = ((pf + (spinfo->last_pf << 3)) / 9)
					>> RC_PID_ARITH_SHIFT;
192 193
	}

194 195 196
	spinfo->tx_num_xmit = 0;
	spinfo->tx_num_failed = 0;

197
	/* If we just switched rate, update the rate behaviour info. */
198
	if (pinfo->oldrate != sta->txrate_idx) {
199 200

		i = rinfo[pinfo->oldrate].rev_index;
201
		j = rinfo[sta->txrate_idx].rev_index;
202 203 204 205 206

		tmp = (pf - spinfo->last_pf);
		tmp = RC_PID_DO_ARITH_RIGHT_SHIFT(tmp, RC_PID_ARITH_SHIFT);

		rinfo[j].diff = rinfo[i].diff + tmp;
207
		pinfo->oldrate = sta->txrate_idx;
208
	}
209
	rate_control_pid_normalize(pinfo, sband->n_bitrates);
210

211
	/* Compute the proportional, integral and derivative errors. */
212
	err_prop = (pinfo->target << RC_PID_ARITH_SHIFT) - pf;
213

214
	err_avg = spinfo->err_avg_sc >> pinfo->smoothing_shift;
215
	spinfo->err_avg_sc = spinfo->err_avg_sc - err_avg + err_prop;
216
	err_int = spinfo->err_avg_sc >> pinfo->smoothing_shift;
217

218 219
	err_der = (pf - spinfo->last_pf) *
		  (1 + pinfo->sharpen_factor * spinfo->sharp_cnt);
220
	spinfo->last_pf = pf;
221 222
	if (spinfo->sharp_cnt)
			spinfo->sharp_cnt--;
223

M
Mattias Nissler 已提交
224 225 226 227 228
#ifdef CONFIG_MAC80211_DEBUGFS
	rate_control_pid_event_pf_sample(&spinfo->events, pf, err_prop, err_int,
					 err_der);
#endif

229 230 231
	/* Compute the controller output. */
	adj = (err_prop * pinfo->coeff_p + err_int * pinfo->coeff_i
	      + err_der * pinfo->coeff_d);
232
	adj = RC_PID_DO_ARITH_RIGHT_SHIFT(adj, 2 * RC_PID_ARITH_SHIFT);
233 234 235

	/* Change rate. */
	if (adj)
236
		rate_control_pid_adjust_rate(local, sta, adj, rinfo);
237 238 239 240 241 242 243 244
}

static void rate_control_pid_tx_status(void *priv, struct net_device *dev,
				       struct sk_buff *skb,
				       struct ieee80211_tx_status *status)
{
	struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
	struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
245
	struct ieee80211_sub_if_data *sdata;
246 247 248
	struct rc_pid_info *pinfo = priv;
	struct sta_info *sta;
	struct rc_pid_sta_info *spinfo;
249
	unsigned long period;
250
	struct ieee80211_supported_band *sband;
251 252

	sta = sta_info_get(local, hdr->addr1);
253
	sband = local->hw.wiphy->bands[local->hw.conf.channel->band];
254 255 256 257

	if (!sta)
		return;

258 259 260
	/* Don't update the state if we're not controlling the rate. */
	sdata = IEEE80211_DEV_TO_SUB_IF(sta->dev);
	if (sdata->bss && sdata->bss->force_unicast_rateidx > -1) {
261
		sta->txrate_idx = sdata->bss->max_ratectrl_rateidx;
262 263 264
		return;
	}

265 266
	/* Ignore all frames that were sent with a different rate than the rate
	 * we currently advise mac80211 to use. */
267
	if (status->control.tx_rate != &sband->bitrates[sta->txrate_idx])
268
		goto ignore;
269 270 271 272

	spinfo = sta->rate_ctrl_priv;
	spinfo->tx_num_xmit++;

M
Mattias Nissler 已提交
273 274 275 276
#ifdef CONFIG_MAC80211_DEBUGFS
	rate_control_pid_event_tx_status(&spinfo->events, status);
#endif

277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299
	/* We count frames that totally failed to be transmitted as two bad
	 * frames, those that made it out but had some retries as one good and
	 * one bad frame. */
	if (status->excessive_retries) {
		spinfo->tx_num_failed += 2;
		spinfo->tx_num_xmit++;
	} else if (status->retry_count) {
		spinfo->tx_num_failed++;
		spinfo->tx_num_xmit++;
	}

	if (status->excessive_retries) {
		sta->tx_retry_failed++;
		sta->tx_num_consecutive_failures++;
		sta->tx_num_mpdu_fail++;
	} else {
		sta->tx_num_consecutive_failures = 0;
		sta->tx_num_mpdu_ok++;
	}
	sta->tx_retry_count += status->retry_count;
	sta->tx_num_mpdu_fail += status->retry_count;

	/* Update PID controller state. */
300 301 302 303
	period = (HZ * pinfo->sampling_period + 500) / 1000;
	if (!period)
		period = 1;
	if (time_after(jiffies, spinfo->last_sample + period))
304 305
		rate_control_pid_sample(pinfo, local, sta);

306
ignore:
307 308 309 310
	sta_info_put(sta);
}

static void rate_control_pid_get_rate(void *priv, struct net_device *dev,
311
				      struct ieee80211_supported_band *sband,
312 313 314 315 316
				      struct sk_buff *skb,
				      struct rate_selection *sel)
{
	struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
	struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
317
	struct ieee80211_sub_if_data *sdata;
318 319
	struct sta_info *sta;
	int rateidx;
320
	u16 fc;
321 322 323

	sta = sta_info_get(local, hdr->addr1);

324 325 326 327 328
	/* Send management frames and broadcast/multicast data using lowest
	 * rate. */
	fc = le16_to_cpu(hdr->frame_control);
	if ((fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA ||
	    is_multicast_ether_addr(hdr->addr1) || !sta) {
329
		sel->rate = rate_lowest(local, sband, sta);
330 331
		if (sta)
			sta_info_put(sta);
332 333 334
		return;
	}

335 336 337
	/* If a forced rate is in effect, select it. */
	sdata = IEEE80211_DEV_TO_SUB_IF(dev);
	if (sdata->bss && sdata->bss->force_unicast_rateidx > -1)
338
		sta->txrate_idx = sdata->bss->force_unicast_rateidx;
339

340
	rateidx = sta->txrate_idx;
341

342 343
	if (rateidx >= sband->n_bitrates)
		rateidx = sband->n_bitrates - 1;
344

345
	sta->last_txrate_idx = rateidx;
346

347 348
	sta_info_put(sta);

349
	sel->rate = &sband->bitrates[rateidx];
M
Mattias Nissler 已提交
350 351 352 353

#ifdef CONFIG_MAC80211_DEBUGFS
	rate_control_pid_event_tx_rate(
		&((struct rc_pid_sta_info *) sta->rate_ctrl_priv)->events,
354
		rateidx, sband->bitrates[rateidx].bitrate);
M
Mattias Nissler 已提交
355
#endif
356 357 358 359 360 361 362 363 364 365
}

static void rate_control_pid_rate_init(void *priv, void *priv_sta,
					  struct ieee80211_local *local,
					  struct sta_info *sta)
{
	/* TODO: This routine should consider using RSSI from previous packets
	 * as we need to have IEEE 802.1X auth succeed immediately after assoc..
	 * Until that method is implemented, we will use the lowest supported
	 * rate as a workaround. */
366 367 368 369
	struct ieee80211_supported_band *sband;

	sband = local->hw.wiphy->bands[local->hw.conf.channel->band];
	sta->txrate_idx = rate_lowest_index(local, sband, sta);
370
	sta->fail_avg = 0;
371 372 373 374 375
}

static void *rate_control_pid_alloc(struct ieee80211_local *local)
{
	struct rc_pid_info *pinfo;
376
	struct rc_pid_rateinfo *rinfo;
377
	struct ieee80211_supported_band *sband;
378 379
	int i, j, tmp;
	bool s;
380 381 382
#ifdef CONFIG_MAC80211_DEBUGFS
	struct rc_pid_debugfs_entries *de;
#endif
383

384 385
	sband = local->hw.wiphy->bands[local->hw.conf.channel->band];

386
	pinfo = kmalloc(sizeof(*pinfo), GFP_ATOMIC);
387 388 389
	if (!pinfo)
		return NULL;

390
	/* We can safely assume that sband won't change unless we get
391
	 * reinitialized. */
392
	rinfo = kmalloc(sizeof(*rinfo) * sband->n_bitrates, GFP_ATOMIC);
393 394 395 396 397 398 399 400
	if (!rinfo) {
		kfree(pinfo);
		return NULL;
	}

	/* Sort the rates. This is optimized for the most common case (i.e.
	 * almost-sorted CCK+OFDM rates). Kind of bubble-sort with reversed
	 * mapping too. */
401
	for (i = 0; i < sband->n_bitrates; i++) {
402 403
		rinfo[i].index = i;
		rinfo[i].rev_index = i;
404
		if (pinfo->fast_start)
405 406
			rinfo[i].diff = 0;
		else
407
			rinfo[i].diff = i * pinfo->norm_offset;
408
	}
409
	for (i = 1; i < sband->n_bitrates; i++) {
410
		s = 0;
411 412 413
		for (j = 0; j < sband->n_bitrates - i; j++)
			if (unlikely(sband->bitrates[rinfo[j].index].bitrate >
				     sband->bitrates[rinfo[j + 1].index].bitrate)) {
414 415 416 417 418 419 420 421 422 423
				tmp = rinfo[j].index;
				rinfo[j].index = rinfo[j + 1].index;
				rinfo[j + 1].index = tmp;
				rinfo[rinfo[j].index].rev_index = j;
				rinfo[rinfo[j + 1].index].rev_index = j + 1;
				s = 1;
			}
		if (!s)
			break;
	}
424 425

	pinfo->target = RC_PID_TARGET_PF;
426
	pinfo->sampling_period = RC_PID_INTERVAL;
427 428 429
	pinfo->coeff_p = RC_PID_COEFF_P;
	pinfo->coeff_i = RC_PID_COEFF_I;
	pinfo->coeff_d = RC_PID_COEFF_D;
430 431 432 433 434
	pinfo->smoothing_shift = RC_PID_SMOOTHING_SHIFT;
	pinfo->sharpen_factor = RC_PID_SHARPENING_FACTOR;
	pinfo->sharpen_duration = RC_PID_SHARPENING_DURATION;
	pinfo->norm_offset = RC_PID_NORM_OFFSET;
	pinfo->fast_start = RC_PID_FAST_START;
435 436
	pinfo->rinfo = rinfo;
	pinfo->oldrate = 0;
437

438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469
#ifdef CONFIG_MAC80211_DEBUGFS
	de = &pinfo->dentries;
	de->dir = debugfs_create_dir("rc80211_pid",
				     local->hw.wiphy->debugfsdir);
	de->target = debugfs_create_u32("target_pf", S_IRUSR | S_IWUSR,
					de->dir, &pinfo->target);
	de->sampling_period = debugfs_create_u32("sampling_period",
						 S_IRUSR | S_IWUSR, de->dir,
						 &pinfo->sampling_period);
	de->coeff_p = debugfs_create_u32("coeff_p", S_IRUSR | S_IWUSR,
					 de->dir, &pinfo->coeff_p);
	de->coeff_i = debugfs_create_u32("coeff_i", S_IRUSR | S_IWUSR,
					 de->dir, &pinfo->coeff_i);
	de->coeff_d = debugfs_create_u32("coeff_d", S_IRUSR | S_IWUSR,
					 de->dir, &pinfo->coeff_d);
	de->smoothing_shift = debugfs_create_u32("smoothing_shift",
						 S_IRUSR | S_IWUSR, de->dir,
						 &pinfo->smoothing_shift);
	de->sharpen_factor = debugfs_create_u32("sharpen_factor",
					       S_IRUSR | S_IWUSR, de->dir,
					       &pinfo->sharpen_factor);
	de->sharpen_duration = debugfs_create_u32("sharpen_duration",
						  S_IRUSR | S_IWUSR, de->dir,
						  &pinfo->sharpen_duration);
	de->norm_offset = debugfs_create_u32("norm_offset",
					     S_IRUSR | S_IWUSR, de->dir,
					     &pinfo->norm_offset);
	de->fast_start = debugfs_create_bool("fast_start",
					     S_IRUSR | S_IWUSR, de->dir,
					     &pinfo->fast_start);
#endif

470 471 472 473 474 475
	return pinfo;
}

static void rate_control_pid_free(void *priv)
{
	struct rc_pid_info *pinfo = priv;
476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491
#ifdef CONFIG_MAC80211_DEBUGFS
	struct rc_pid_debugfs_entries *de = &pinfo->dentries;

	debugfs_remove(de->fast_start);
	debugfs_remove(de->norm_offset);
	debugfs_remove(de->sharpen_duration);
	debugfs_remove(de->sharpen_factor);
	debugfs_remove(de->smoothing_shift);
	debugfs_remove(de->coeff_d);
	debugfs_remove(de->coeff_i);
	debugfs_remove(de->coeff_p);
	debugfs_remove(de->sampling_period);
	debugfs_remove(de->target);
	debugfs_remove(de->dir);
#endif

492
	kfree(pinfo->rinfo);
493 494 495 496 497 498 499 500 501 502 503 504
	kfree(pinfo);
}

static void rate_control_pid_clear(void *priv)
{
}

static void *rate_control_pid_alloc_sta(void *priv, gfp_t gfp)
{
	struct rc_pid_sta_info *spinfo;

	spinfo = kzalloc(sizeof(*spinfo), gfp);
M
Mattias Nissler 已提交
505 506 507
	if (spinfo == NULL)
		return NULL;

508 509
	spinfo->last_sample = jiffies;

M
Mattias Nissler 已提交
510 511 512 513
#ifdef CONFIG_MAC80211_DEBUGFS
	spin_lock_init(&spinfo->events.lock);
	init_waitqueue_head(&spinfo->events.waitqueue);
#endif
514 515 516 517 518 519 520 521 522 523

	return spinfo;
}

static void rate_control_pid_free_sta(void *priv, void *priv_sta)
{
	struct rc_pid_sta_info *spinfo = priv_sta;
	kfree(spinfo);
}

524
static struct rate_control_ops mac80211_rcpid = {
525 526 527 528 529 530 531 532 533
	.name = "pid",
	.tx_status = rate_control_pid_tx_status,
	.get_rate = rate_control_pid_get_rate,
	.rate_init = rate_control_pid_rate_init,
	.clear = rate_control_pid_clear,
	.alloc = rate_control_pid_alloc,
	.free = rate_control_pid_free,
	.alloc_sta = rate_control_pid_alloc_sta,
	.free_sta = rate_control_pid_free_sta,
M
Mattias Nissler 已提交
534 535 536 537
#ifdef CONFIG_MAC80211_DEBUGFS
	.add_sta_debugfs = rate_control_pid_add_sta_debugfs,
	.remove_sta_debugfs = rate_control_pid_remove_sta_debugfs,
#endif
538
};
539 540 541 542 543 544 545 546 547 548 549

MODULE_DESCRIPTION("PID controller based rate control algorithm");
MODULE_AUTHOR("Stefano Brivio");
MODULE_AUTHOR("Mattias Nissler");
MODULE_LICENSE("GPL");

int __init rc80211_pid_init(void)
{
	return ieee80211_rate_control_register(&mac80211_rcpid);
}

550
void rc80211_pid_exit(void)
551 552 553 554 555 556 557 558
{
	ieee80211_rate_control_unregister(&mac80211_rcpid);
}

#ifdef CONFIG_MAC80211_RC_PID_MODULE
module_init(rc80211_pid_init);
module_exit(rc80211_pid_exit);
#endif