提交 ef1ed411 编写于 作者: T Tomas Mraz 提交者: Todd Short

Coverity 1528486: Avoid assignment of unused value of bags

It is used only within the loop and always initialized
上级 265920f2
......@@ -899,7 +899,6 @@ int dump_certs_keys_p12(BIO *out, const PKCS12 *p12, const char *pass,
const EVP_CIPHER *enc)
{
STACK_OF(PKCS7) *asafes = NULL;
STACK_OF(PKCS12_SAFEBAG) *bags;
int i, bagnid;
int ret = 0;
PKCS7 *p7;
......@@ -907,6 +906,8 @@ int dump_certs_keys_p12(BIO *out, const PKCS12 *p12, const char *pass,
if ((asafes = PKCS12_unpack_authsafes(p12)) == NULL)
return 0;
for (i = 0; i < sk_PKCS7_num(asafes); i++) {
STACK_OF(PKCS12_SAFEBAG) *bags;
p7 = sk_PKCS7_value(asafes, i);
bagnid = OBJ_obj2nid(p7->type);
if (bagnid == NID_pkcs7_data) {
......@@ -922,7 +923,7 @@ int dump_certs_keys_p12(BIO *out, const PKCS12 *p12, const char *pass,
} else {
continue;
}
if (!bags)
if (bags == NULL)
goto err;
if (!dump_certs_pkeys_bags(out, bags, pass, passlen,
options, pempass, enc)) {
......@@ -930,7 +931,6 @@ int dump_certs_keys_p12(BIO *out, const PKCS12 *p12, const char *pass,
goto err;
}
sk_PKCS12_SAFEBAG_pop_free(bags, PKCS12_SAFEBAG_free);
bags = NULL;
}
ret = 1;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册