CONTRIBUTING 2.5 KB
Newer Older
B
Benjamin Kaduk 已提交
1
HOW TO CONTRIBUTE PATCHES TO OpenSSL
R
Rich Salz 已提交
2
------------------------------------
3

M
Matt Caswell 已提交
4
(Please visit https://www.openssl.org/community/getting-started.html for
R
Rich Salz 已提交
5
other ideas about how to contribute.)
6

R
Rich Salz 已提交
7
Development is coordinated on the openssl-dev mailing list (see the
M
Matt Caswell 已提交
8
above link or https://mta.openssl.org for information on subscribing).
9
If you are unsure as to whether a feature will be useful for the general
R
Rich Salz 已提交
10 11 12
OpenSSL community you might want to discuss it on the openssl-dev mailing
list first.  Someone may be already working on the same thing or there
may be a good reason as to why that feature isn't implemented.
13

R
Rich Salz 已提交
14 15 16
To submit a patch, make a pull request on GitHub.  If you think the patch
could use feedback from the community, please start a thread on openssl-dev
to discuss it.
R
Rich Salz 已提交
17

R
Rich Salz 已提交
18 19
Having addressed the following items before the PR will help make the
acceptance and review process faster:
R
Rich Salz 已提交
20 21 22

    1. Anything other than trivial contributions will require a contributor
    licensing agreement, giving us permission to use your code. See
M
Matt Caswell 已提交
23
    https://www.openssl.org/policies/cla.html for details.
R
Rich Salz 已提交
24 25 26 27 28 29 30 31 32 33 34 35

    2.  All source files should start with the following text (with
    appropriate comment characters at the start of each line and the
    year(s) updated):

        Copyright 20xx-20yy The OpenSSL Project Authors. All Rights Reserved.

        Licensed under the OpenSSL license (the "License").  You may not use
        this file except in compliance with the License.  You can obtain a copy
        in the file LICENSE in the source distribution or at
        https://www.openssl.org/source/license.html

R
Rich Salz 已提交
36 37 38
    3.  Patches should be as current as possible; expect to have to rebase
    often. We do not accept merge commits; You will be asked to remove
    them before a patch is considered acceptable.
R
Rich Salz 已提交
39

M
Matt Caswell 已提交
40
    4.  Patches should follow our coding style (see
R
Rich Salz 已提交
41
    https://www.openssl.org/policies/codingstyle.html) and compile without
F
FdaSilvaYY 已提交
42
    warnings. Where gcc or clang is available you should use the
M
Matt Caswell 已提交
43 44
    --strict-warnings Configure option.  OpenSSL compiles on many varied
    platforms: try to ensure you only use portable features.
R
Rich Salz 已提交
45 46
    Clean builds via Travis and AppVeyor are expected, and done whenever
    a PR is created or updated.
R
Rich Salz 已提交
47

R
Rich Salz 已提交
48 49 50
    5.  When at all possible, patches should include tests. These can
    either be added to an existing test, or completely new.  Please see
    test/README for information on the test framework.
51

R
Rich Salz 已提交
52
    6.  New features or changed functionality must include
B
Beat Bolli 已提交
53 54
    documentation. Please look at the "pod" files in doc/man[1357]
    for examples of our style.