BootManagement: Improved consistency of OC_ATTR naming

Docs/Configuration.tex

@@ -3219,7 +3219,7 @@ the default boot entry choice will remain changed until the next manual reconfig
   \item \texttt{0x0010} --- \texttt{OC\_ATTR\_USE\_POINTER\_CONTROL}, enables pointer control
   in the OpenCore picker when available. For example, this could make use of mouse or trackpad to
   control UI elements.
-  \item \texttt{0x0020} --- \texttt{OC\_ATTR\_DEBUG\_DISPLAY}, enable display of additional
+  \item \texttt{0x0020} --- \texttt{OC\_ATTR\_SHOW\_DEBUG\_DISPLAY}, enable display of additional
   timing and debug information, in Builtin picker in \texttt{DEBUG} and \texttt{NOOPT}
   builds only.
   \end{itemize}

Include/Acidanthera/Library/OcBootManagementLib.h

@@ -69,11 +69,11 @@ typedef struct OC_HOTKEY_CONTEXT_ OC_HOTKEY_CONTEXT;
 #define OC_ATTR_USE_GENERIC_LABEL_IMAGE  BIT2
 #define OC_ATTR_HIDE_THEMED_ICONS        BIT3
 #define OC_ATTR_USE_POINTER_CONTROL      BIT4
-#define OC_ATTR_DEBUG_DISPLAY            BIT5
+#define OC_ATTR_SHOW_DEBUG_DISPLAY            BIT5
 #define OC_ATTR_ALL_BITS (\
   OC_ATTR_USE_VOLUME_ICON         | OC_ATTR_USE_DISK_LABEL_FILE | \
   OC_ATTR_USE_GENERIC_LABEL_IMAGE | OC_ATTR_HIDE_THEMED_ICONS   | \
-  OC_ATTR_USE_POINTER_CONTROL     | OC_ATTR_DEBUG_DISPLAY )
+  OC_ATTR_USE_POINTER_CONTROL     | OC_ATTR_SHOW_DEBUG_DISPLAY )
 
 /**
   Default timeout for IDLE timeout during menu picker navigation

Library/OcBootManagementLib/BuiltinPicker.c

@@ -351,7 +351,7 @@ OcShowSimpleBootMenu (
   PlayChosen     = FALSE;
 
   DEBUG_CODE_BEGIN ();
-  if ((BootContext->PickerContext->PickerAttributes & OC_ATTR_DEBUG_DISPLAY) != 0) {
+  if ((BootContext->PickerContext->PickerAttributes & OC_ATTR_SHOW_DEBUG_DISPLAY) != 0) {
     DEBUG ((DEBUG_INFO, "OCB: Init builtin picker debug\n"));
     InitKbDebugDisplay();
     BootContext->PickerContext->KbDebug = &mSimplePickerKbDebug;
@@ -413,7 +413,7 @@ OcShowSimpleBootMenu (
       }
 
       DEBUG_CODE_BEGIN ();
-      if ((BootContext->PickerContext->PickerAttributes & OC_ATTR_DEBUG_DISPLAY) != 0) {
+      if ((BootContext->PickerContext->PickerAttributes & OC_ATTR_SHOW_DEBUG_DISPLAY) != 0) {
         //
         // Varying part of milliseconds display
         //
@@ -440,7 +440,7 @@ OcShowSimpleBootMenu (
       }
 
       DEBUG_CODE_BEGIN ();
-      if ((BootContext->PickerContext->PickerAttributes & OC_ATTR_DEBUG_DISPLAY) != 0) {
+      if ((BootContext->PickerContext->PickerAttributes & OC_ATTR_SHOW_DEBUG_DISPLAY) != 0) {
         //
         // Fixed part of milliseconds display
         //
@@ -503,7 +503,7 @@ OcShowSimpleBootMenu (
 #endif
 
       DEBUG_CODE_BEGIN ();
-      if ((BootContext->PickerContext->PickerAttributes & OC_ATTR_DEBUG_DISPLAY) != 0) {
+      if ((BootContext->PickerContext->PickerAttributes & OC_ATTR_SHOW_DEBUG_DISPLAY) != 0) {
         //
         // Parts of main debug display which do not need to reprint every frame
         // TODO: Could do more here