ocvalidate: Fix checks for `LoadEarly`

Utilities/ocvalidate/README.md

@@ -125,8 +125,7 @@ Utility to validate whether a `config.plist` matches requirements and convention
 - `OpenUsbKbDxe.efi` and `Ps2KeyboardDxe.efi` should never co-exist.
 - When HFS+ filesystem driver or `AudioDxe.efi` is in use, `ConnectDrivers` should be enabled altogether.
 - When `OpenCanopy.efi` is in use, `PickerMode` in `Misc->Boot` should be set to `External`.
-- When `OpenVariableRuntimeDxe.efi` is in use, its `LoadEarly` option must be set to `TRUE`.
-- When `OpenVariableRuntimeDxe.efi` is NOT in use, `LoadEarly` for any driver must be set to `FALSE`.
+- When `OpenVariableRuntimeDxe.efi` is in use, its `LoadEarly` option must be set to `TRUE`; `LoadEarly` for any other driver must be set to `FALSE`.
 #### Input
 - KeySupportMode: Only `Auto`, `V1`, `V2`, or `AMI` are accepted.
 - When `PointerSupport` is enabled, the value of `PointerSupportMode` should only be `ASUS`.

Utilities/ocvalidate/ValidateUefi.c

@@ -364,6 +364,21 @@ CheckUefiDrivers (
       continue;
     }
 
+    //
+    // For all drivers but OpenVariableRuntimeDxe.efi, LoadEarly must be FALSE.
+    //
+    if (AsciiStrCmp (Driver, "OpenVariableRuntimeDxe.efi") != 0) {
+      if (DriverEntry->LoadEarly) {
+        DEBUG ((DEBUG_WARN, "%a at UEFI->Drivers[%u] must have LoadEarly set to FALSE", Driver, Index));
+        ++ErrorCount;
+      }
+    } else {
+      if (!DriverEntry->LoadEarly) {
+        DEBUG ((DEBUG_WARN, "OpenVariableRuntimeDxe at UEFI->Drivers[%u] must have LoadEarly set to TRUE!\n", Index));
+        ++ErrorCount;
+      }
+    }
+
     if (AsciiStrCmp (Driver, "OpenRuntime.efi") == 0) {
       HasOpenRuntimeEfiDriver = TRUE;
     }