OpenCoreDevProps: Move ReinstallProtocol out of quirks

Docs/Configuration.tex

@@ -825,24 +825,13 @@ ioreg -lw0 -p IODeviceTree -n efi -r -x | grep device-properties |
   of deivce paths to an array (\texttt{plist\ array}) of variable names in
   \texttt{plist\ string} format.
 
-\item
-  \texttt{Quirks}\\
-  \textbf{Type}: \texttt{plist\ dict}\\
-  \textbf{Description}: Apply individual device property quirks described
-  in \hyperref[devpropsquirks]{Quirks Properties} section below.
-
-\end{enumerate}
-
-\subsection{Quirks Properties}\label{devpropsquirks}
-
-\begin{enumerate}
-
 \item
   \texttt{ReinstallProtocol}\\
   \textbf{Type}: \texttt{plist\ boolean}\\
   \textbf{Default value}: \texttt{false}\\
-  \textbf{Description}: Reinstalls device property protocol (and drops all previous
-  properties) if it was already installed.
+  \textbf{Description}: Reinstalls device property protocol with a builtin
+  version. This will drop all previous properties if it was already installed.
+  This may be used to ensure full compatibility on VMs or legacy Macs.
 
 \end{enumerate}
 

Docs/Sample.plist

@@ -143,11 +143,8 @@
 				<string>MaximumBootBeepVolume</string>
 			</array>
 		</dict>
-		<key>Quirks</key>
-		<dict>
-			<key>ReinstallProtocol</key>
-			<false/>
-		</dict>
+		<key>ReinstallProtocol</key>
+		<false/>
 	</dict>
 	<key>Kernel</key>
 	<dict>

OpenCorePkg.dsc

@@ -32,6 +32,7 @@
   DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
   PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
   DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
+  FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
   UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
   HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
   MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf

Platform/OpenCore/OpenCoreDevProps.c

@@ -45,7 +45,7 @@ OcLoadDevPropsSupport (
   UINTN                                       OriginalSize;
 
   PropertyDatabase = OcDevicePathPropertyInstallProtocol (
-    Config->DeviceProperties.Quirks.ReinstallProtocol
+    Config->DeviceProperties.ReinstallProtocol
     );
   if (PropertyDatabase == NULL) {
     DEBUG ((DEBUG_ERROR, "OC: Device property database protocol is missing\n"));