#225 更新Sonar规则集，与Sonar 3.5.1 同步

modules/core/src/main/java/org/springside/modules/utils/DateProvider.java

@@ -11,8 +11,11 @@ public interface DateProvider {
 
 	Date getDate();
 
-	public static final DateProvider DEFAULT = new CurrentDateProvider();
+	static final DateProvider DEFAULT = new CurrentDateProvider();
 
+	/**
+	 * 返回当前的时间。
+	 */
 	public static class CurrentDateProvider implements DateProvider {
 
 		@Override
@@ -21,6 +24,9 @@ public interface DateProvider {
 		}
 	}
 
+	/**
+	 * 返回设定的时间.
+	 */
 	public static class ConfigurableDateProvider implements DateProvider {
 
 		private final Date date;

modules/test/src/main/java/org/springside/modules/test/benchmark/ConcurrentBenchmark.java

@@ -103,5 +103,5 @@ public abstract class ConcurrentBenchmark {
 	 * 
 	 * @param taskSequence the sequence number of the task.
 	 */
-	abstract protected BenchmarkTask createTask(int taskSequence);
+	protected abstract BenchmarkTask createTask(int taskSequence);
 }

support/sonar/springside-checkstyle.xml

-<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd"><!-- Generated by Sonar --><module name="Checker"><module name="SuppressionCommentFilter"/><module name="TreeWalker"><module name="FileContentsHolder"/> <module name="CyclomaticComplexity"><property name="severity" value="warning"/><property name="max" value="10"/></module><module name="NestedIfDepth"><property name="severity" value="warning"/><property name="max" value="3"/></module><module name="DoubleCheckedLocking"><property name="severity" value="warning"/></module><module name="HiddenField"><property name="severity" value="warning"/><property name="tokens" value="VARIABLE_DEF"/><property name="ignoreConstructorParameter" value="true"/><property name="ignoreSetter" value="true"/><property name="ignoreAbstractMethods" value="true"/></module><module name="StringLiteralEquality"><property name="severity" value="warning"/></module><module name="LocalVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="JavaNCSS"><property name="severity" value="warning"/><property name="classMaximum" value="500"/><property name="fileMaximum" value="600"/></module><module name="IllegalThrows"><property name="severity" value="warning"/></module><module name="RedundantModifier"><property name="severity" value="info"/></module><module name="AnonInnerLength"><property name="severity" value="warning"/></module><module name="StaticVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="DeclarationOrder"><property name="severity" value="info"/></module><module name="MethodName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="allowClassName" value="false"/></module><module name="ParameterName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="OneStatementPerLine"><property name="severity" value="warning"/></module><module name="ParameterNumber"><property name="severity" value="warning"/><property name="max" value="5"/></module><module name="DefaultComesLast"><property name="severity" value="warning"/></module><module name="LocalFinalVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="MemberName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="EqualsHashCode"><property name="severity" value="error"/></module><module name="EmptyStatement"><property name="severity" value="info"/></module><module name="PackageName"><property name="severity" value="warning"/><property name="format" value="^[a-z]+(\.[a-zA-Z_][a-zA-Z0-9_]*)*$"/></module><module name="ConstantName"><property name="severity" value="info"/><property name="format" value="^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="RedundantThrows"><property name="severity" value="info"/><property name="allowUnchecked" value="true"/><property name="suppressLoadErrors" value="true"/></module><module name="ParameterAssignment"><property name="severity" value="warning"/></module><module name="UnusedImports"><property name="severity" value="info"/><property name="processJavadoc" value="false"/></module><module name="SimplifyBooleanExpression"><property name="severity" value="warning"/></module><module name="SimplifyBooleanReturn"><property name="severity" value="warning"/></module><module name="ModifierOrder"><property name="severity" value="info"/></module><module name="BooleanExpressionComplexity"><property name="severity" value="warning"/></module><module name="InnerAssignment"><property name="severity" value="warning"/></module><module name="MagicNumber"><property name="severity" value="info"/><property name="ignoreHashCodeMethod" value="false"/><property name="ignoreAnnotation" value="false"/></module></module></module>
\ No newline at end of file
+<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd"><!-- Generated by Sonar --><module name="Checker"><module name="SuppressionCommentFilter"/><module name="TreeWalker"><module name="FileContentsHolder"/> <module name="CyclomaticComplexity"><property name="severity" value="warning"/><property name="max" value="10"/></module><module name="NestedIfDepth"><property name="severity" value="warning"/><property name="max" value="3"/></module><module name="HiddenField"><property name="severity" value="warning"/><property name="tokens" value="VARIABLE_DEF"/><property name="ignoreConstructorParameter" value="true"/><property name="ignoreSetter" value="true"/><property name="ignoreAbstractMethods" value="true"/></module><module name="StringLiteralEquality"><property name="severity" value="warning"/></module><module name="LocalVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="JavaNCSS"><property name="severity" value="warning"/><property name="classMaximum" value="500"/><property name="fileMaximum" value="600"/></module><module name="IllegalThrows"><property name="severity" value="warning"/></module><module name="RedundantModifier"><property name="severity" value="info"/></module><module name="AnonInnerLength"><property name="severity" value="warning"/></module><module name="StaticVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="DeclarationOrder"><property name="severity" value="info"/></module><module name="MethodName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="allowClassName" value="false"/></module><module name="ParameterName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="MethodTypeParameterName"><property name="severity" value="warning"/><property name="format" value="^[A-Z]$"/></module><module name="OneStatementPerLine"><property name="severity" value="warning"/></module><module name="ParameterNumber"><property name="severity" value="warning"/><property name="max" value="5"/></module><module name="DefaultComesLast"><property name="severity" value="warning"/></module><module name="LocalFinalVariableName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/></module><module name="MemberName"><property name="severity" value="warning"/><property name="format" value="^[a-z][a-zA-Z0-9]*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="EqualsHashCode"><property name="severity" value="error"/></module><module name="EmptyStatement"><property name="severity" value="info"/></module><module name="PackageName"><property name="severity" value="warning"/><property name="format" value="^[a-z]+(\.[a-zA-Z_][a-zA-Z0-9_]*)*$"/></module><module name="ConstantName"><property name="severity" value="info"/><property name="format" value="^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"/><property name="applyToPublic" value="true"/><property name="applyToProtected" value="true"/><property name="applyToPackage" value="true"/><property name="applyToPrivate" value="true"/></module><module name="RedundantThrows"><property name="severity" value="info"/><property name="allowUnchecked" value="true"/><property name="suppressLoadErrors" value="true"/></module><module name="ParameterAssignment"><property name="severity" value="warning"/></module><module name="UnusedImports"><property name="severity" value="info"/><property name="processJavadoc" value="false"/></module><module name="ClassTypeParameterName"><property name="severity" value="warning"/><property name="format" value="^[A-Z]$"/></module><module name="SimplifyBooleanExpression"><property name="severity" value="warning"/></module><module name="SimplifyBooleanReturn"><property name="severity" value="warning"/></module><module name="ModifierOrder"><property name="severity" value="info"/></module><module name="BooleanExpressionComplexity"><property name="severity" value="warning"/></module><module name="InnerAssignment"><property name="severity" value="warning"/></module><module name="MagicNumber"><property name="severity" value="info"/><property name="ignoreHashCodeMethod" value="false"/><property name="ignoreAnnotation" value="false"/></module></module></module>
\ No newline at end of file

support/sonar/springside-findbugs.xml

@@ -1180,4 +1180,22 @@
   <Match>
     <Bug pattern="DLS_OVERWRITTEN_INCREMENT"/>
   </Match>
+  <Match>
+    <Bug pattern="PT_ABSOLUTE_PATH_TRAVERSAL"/>
+  </Match>
+  <Match>
+    <Bug pattern="TQ_COMPARING_VALUES_WITH_INCOMPATIBLE_TYPE_QUALIFIERS"/>
+  </Match>
+  <Match>
+    <Bug pattern="MS_SHOULD_BE_REFACTORED_TO_BE_FINAL"/>
+  </Match>
+  <Match>
+    <Bug pattern="NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/>
+  </Match>
+  <Match>
+    <Bug pattern="PT_RELATIVE_PATH_TRAVERSAL"/>
+  </Match>
+  <Match>
+    <Bug pattern="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE"/>
+  </Match>
 </FindBugsFilter>
\ No newline at end of file

support/sonar/springside-pmd.xml

@@ -195,9 +195,6 @@
   <rule ref="rulesets/migrating.xml/AvoidAssertAsIdentifier">
     <priority>3</priority>
   </rule>
-  <rule ref="rulesets/design.xml/UnnecessaryLocalBeforeReturn">
-    <priority>3</priority>
-  </rule>
   <rule ref="rulesets/finalizers.xml/AvoidCallingFinalize">
     <priority>3</priority>
   </rule>