1. 27 10月, 2018 1 次提交
    • P
      Hexagonal pattern fixes (#814) · 4446e743
      Paweł Matejko 提交于
      * Fixed wrong else condition
      
      * Simplified creating Set of numbers
      
      * Deleted unused imports
      
      * Replaced 'for' loop with 'foreach' one
      
      * Replaced explicit type with diamond
      
      * Removed unnecesary brackets from lambda
      
      * Removed unnecesary contains check before adding element to Set
      
      * Fixed typo and changed non-english constant names
      4446e743
  2. 25 10月, 2018 2 次提交
  3. 23 10月, 2018 1 次提交
    • N
      Minor refactorings and code style changes (#807) · 2aa9e78d
      Narendra Pathai 提交于
      * Made minor changes in some patterns such as removed throws clause where not needed, changed incorrect order of arguments in assertEquals
      
      * Minor refactorings and code style changes. 1) Removed several use of raw types 2) Removed unnecessary throws clauses 3) Used lambda expressions wherever applicable 4) Used apt assertion methods for readability 5) Use of try with resources wherever applicable 6) Corrected incorrect order of assertXXX arguments
      
      * Removed unused import from Promise
      
      * Addressed review comments
      
      * Addressed checkstyle issue
      2aa9e78d
  4. 22 10月, 2018 3 次提交
    • N
      Refactored Event Queue (#806) · 25ed7c09
      Narendra Pathai 提交于
      * 1) Test cases were not stopping AudioService before ending test case 2) Changed Audio to be a good singleton, previously because of Audio being bad singleton, test cases which were using static methods could have caused intermittent failures. 3) Made some other refactorings as well
      
      * Removed sonar issue and converted Audio to eager singleton for simplicity
      
      * Updated class diagram PNG
      25ed7c09
    • N
      Resolves #643, test cases failed due to global state in CallsCount (#803) · 922fd62d
      Narendra Pathai 提交于
      * Resolves #643, test cases failed due to presence of global state in CallsCount. Because AppTest was executed before B2BServiceTest, it scheduled 1 sec timer using ThrottleTimerImpl class. While resetting it used that global CallCount class reset() method, which reset all counters. So that causes thread safety issue because of unintended sharing of application state between test cases, which is not a good practice.
      
      * Updated class diagram png and added UCLS file
      922fd62d
    • N
      Refactoring changes in Ambassador Pattern (#805) · 9e7a5007
      Narendra Pathai 提交于
      * 1) Updated test cases to use Junit Assert method as compared to assert keyword 2) Proper testing of RemoteService using RandomProvider interface. Introduced RandomProvider interface so that randomness can be controlled from test cases. 3) For readability used constant for representing FAILURE
      
      * Addressing review comments, Deleting unintentional file and used FAILURE constant in ClientTest as well
      9e7a5007
  5. 21 10月, 2018 3 次提交
  6. 15 10月, 2018 6 次提交
  7. 13 10月, 2018 2 次提交
  8. 01 10月, 2018 3 次提交
  9. 26 9月, 2018 2 次提交
  10. 24 9月, 2018 1 次提交
    • L
      Delete & Ignore output.txt & error.txt · 8f53df91
      Lyndon Armitage 提交于
      Both output.txt and error.txt are produced by tests.
      Each file contained a header that was overridden upon executing said
      tests causing tracked files to be changed.
      
      Added them to a local .gitignore file for this module.
      8f53df91
  11. 11 9月, 2018 3 次提交
  12. 09 9月, 2018 2 次提交
  13. 08 9月, 2018 2 次提交
  14. 04 9月, 2018 1 次提交
  15. 01 9月, 2018 2 次提交
  16. 30 8月, 2018 2 次提交
  17. 29 8月, 2018 1 次提交
  18. 28 8月, 2018 2 次提交
  19. 27 8月, 2018 1 次提交