- 23 10月, 2018 1 次提交
-
-
由 Narendra Pathai 提交于
* Made minor changes in some patterns such as removed throws clause where not needed, changed incorrect order of arguments in assertEquals * Minor refactorings and code style changes. 1) Removed several use of raw types 2) Removed unnecessary throws clauses 3) Used lambda expressions wherever applicable 4) Used apt assertion methods for readability 5) Use of try with resources wherever applicable 6) Corrected incorrect order of assertXXX arguments * Removed unused import from Promise * Addressed review comments * Addressed checkstyle issue
-
- 22 10月, 2018 3 次提交
-
-
由 Narendra Pathai 提交于
* 1) Test cases were not stopping AudioService before ending test case 2) Changed Audio to be a good singleton, previously because of Audio being bad singleton, test cases which were using static methods could have caused intermittent failures. 3) Made some other refactorings as well * Removed sonar issue and converted Audio to eager singleton for simplicity * Updated class diagram PNG
-
由 Narendra Pathai 提交于
* Resolves #643, test cases failed due to presence of global state in CallsCount. Because AppTest was executed before B2BServiceTest, it scheduled 1 sec timer using ThrottleTimerImpl class. While resetting it used that global CallCount class reset() method, which reset all counters. So that causes thread safety issue because of unintended sharing of application state between test cases, which is not a good practice. * Updated class diagram png and added UCLS file
-
由 Narendra Pathai 提交于
* 1) Updated test cases to use Junit Assert method as compared to assert keyword 2) Proper testing of RemoteService using RandomProvider interface. Introduced RandomProvider interface so that randomness can be controlled from test cases. 3) For readability used constant for representing FAILURE * Addressing review comments, Deleting unintentional file and used FAILURE constant in ClientTest as well
-
- 21 10月, 2018 3 次提交
-
-
由 Ilkka Seppälä 提交于
Minor refactorings in Hexagonal architecture
-
由 Ilkka Seppälä 提交于
Resolves #699 Intermittent failure was due to Thread.sleep in the code
-
由 Ilkka Seppälä 提交于
Fix small points in Strategy and Decorator pattern.
-
- 15 10月, 2018 6 次提交
-
-
由 Narendra Pathai 提交于
Intermittent failure was due to Thread.sleep in the code. While performing unit test cases there was race condition between two threads, so it was not guaranteed to work every time. Used an interface DelayProvider for simulating delay, and while unit testing fake delay provider is used that eradicates the use of Threads in unit test cases, which is not a good practice.
-
由 Narendra Pathai 提交于
-
由 Narendra Pathai 提交于
1) Refactored LotteryNumbers to use Joiner from guava library to join lottery numbers. 2) Solved potential thread safety issue in LotteryTicketId class, where it was using raw primitive value and incrementing it which is not thread-safe. So used AtomicInteger for brevity 3) assertEquals arguments were in incorrect order at many places, so changed order of those 4) Replaced assertFalse and assertTrue at some places with assertEquals and assertNotEquals for reducing complexity of code 5) Removed public modifiers from test cases, as they are no more needed by JUnit 5
-
由 hoangNam 提交于
-
由 hoangNam 提交于
- Remove redundant Exception from throws list in unit tests.
-
由 hoangNam 提交于
-
- 13 10月, 2018 2 次提交
-
-
由 Ilkka Seppälä 提交于
-
由 Ilkka Seppälä 提交于
Fix redundant list alloc in LotteryNumbers
-
- 01 10月, 2018 3 次提交
-
-
由 Ilkka Seppälä 提交于
-
由 Ilkka Seppälä 提交于
-
由 Ilkka Seppälä 提交于
-
- 26 9月, 2018 2 次提交
-
-
由 Ilkka Seppälä 提交于
Delete & Ignore output.txt & error.txt
-
由 Ilkka Seppälä 提交于
#781 Resolved ClasscastException from Acyclic Visitor
-
- 24 9月, 2018 1 次提交
-
-
由 Lyndon Armitage 提交于
Both output.txt and error.txt are produced by tests. Each file contained a header that was overridden upon executing said tests causing tracked files to be changed. Added them to a local .gitignore file for this module.
-
- 11 9月, 2018 3 次提交
-
-
由 Narendra Pathai 提交于
-
由 Narendra Pathai 提交于
-
由 Nick Andrievsky 提交于
-
- 09 9月, 2018 2 次提交
-
-
由 Narendra Pathai 提交于
Execute Around - use lambda
-
由 Narendra Pathai 提交于
#564: Collection Pipeline pattern
-
- 08 9月, 2018 2 次提交
-
-
由 nikhilbarar 提交于
-
由 Eric Riese 提交于
-
- 04 9月, 2018 1 次提交
-
-
由 nikhilbarar 提交于
-
- 01 9月, 2018 2 次提交
-
-
由 nikhilbarar 提交于
-
由 nikhilbarar 提交于
-
- 30 8月, 2018 2 次提交
-
-
由 Narendra Pathai 提交于
#778: Binary Search Tree Iterator
-
由 nikhilbarar 提交于
-
- 29 8月, 2018 1 次提交
-
-
由 mxi1809 提交于
-
- 28 8月, 2018 2 次提交
-
-
由 Mitchell Irvin 提交于
-
由 Narendra Pathai 提交于
Use try-with-resources
-
- 27 8月, 2018 3 次提交
-
-
由 nikhilbarar 提交于
-
由 nikhilbarar 提交于
-
由 nikhilbarar 提交于
-
- 26 8月, 2018 1 次提交
-
-
由 Mitchell Irvin 提交于
Refactored App.java to remove duplicate code and elegantly demonstrate each implementation of the Iterator interface. Removed the redundant ItemIterator interface. Added insert() method to TreeNode class to allow for more elegant construction of BSTs.
-