reformat(pip/_internal): Resolve lint errors

src/pip/_internal/exceptions.py

@@ -9,9 +9,10 @@ from pip._vendor.six import iteritems
 from pip._internal.utils.typing import MYPY_CHECK_RUNNING
 
 if MYPY_CHECK_RUNNING:
-    from typing import Any, Optional, List, Dict
+    from typing import Any, Optional, List, Dict, Text
 
     from pip._vendor.pkg_resources import Distribution
+    from pip._vendor.requests.models import Response, Request
     from pip._vendor.six import PY3
     from pip._vendor.six.moves import configparser
 
@@ -102,18 +103,24 @@ class PreviousBuildDirError(PipError):
 class NetworkConnectionError(PipError):
     """HTTP connection error"""
 
-    def __init__(self, *args, **kwargs):
+    def __init__(self, error_msg, response=None, request=None):
+        # type: (Text, Response, Request) -> None
         """
         Initialize NetworkConnectionError with  `request` and `response`
         objects.
         """
-        response = kwargs.pop('response', None)
         self.response = response
-        self.request = kwargs.pop('request', None)
-        if (response is not None and not self.request and
+        self.request = request
+        self.error_msg = error_msg
+        if (self.response is not None and not self.request and
                 hasattr(response, 'request')):
             self.request = self.response.request
-        super(NetworkConnectionError, self).__init__(*args, **kwargs)
+        super(NetworkConnectionError, self).__init__(
+            error_msg, response, request)
+
+    def __str__(self):
+        # type: () -> str
+        return str(self.error_msg)
 
 
 class InvalidWheelFilename(InstallationError):

src/pip/_internal/network/download.py

@@ -11,7 +11,11 @@ from pip._internal.cli.progress_bars import DownloadProgressProvider
 from pip._internal.exceptions import NetworkConnectionError
 from pip._internal.models.index import PyPI
 from pip._internal.network.cache import is_from_cache
-from pip._internal.network.utils import HEADERS, raise_for_status, response_chunks
+from pip._internal.network.utils import (
+    HEADERS,
+    raise_for_status,
+    response_chunks,
+)
 from pip._internal.utils.misc import (
     format_size,
     redact_auth_from_url,
@@ -165,6 +169,7 @@ class Downloader(object):
         try:
             resp = _http_get_download(self._session, link)
         except NetworkConnectionError as e:
+            assert e.response is not None
             logger.critical(
                 "HTTP error %s while getting %s", e.response.status_code, link
             )

src/pip/_internal/network/lazy_wheel.py

@@ -10,7 +10,11 @@ from zipfile import BadZipfile, ZipFile
 from pip._vendor.requests.models import CONTENT_CHUNK_SIZE
 from pip._vendor.six.moves import range
 
-from pip._internal.network.utils import HEADERS, response_chunks
+from pip._internal.network.utils import (
+    HEADERS,
+    raise_for_status,
+    response_chunks,
+)
 from pip._internal.utils.typing import MYPY_CHECK_RUNNING
 from pip._internal.utils.wheel import pkg_resources_distribution_for_wheel
 
@@ -51,7 +55,7 @@ class LazyZipOverHTTP(object):
     def __init__(self, url, session, chunk_size=CONTENT_CHUNK_SIZE):
         # type: (str, PipSession, int) -> None
         head = session.head(url, headers=HEADERS)
-        head.raise_for_status()
+        raise_for_status(head)
         assert head.status_code == 200
         self._session, self._url, self._chunk_size = session, url, chunk_size
         self._length = int(head.headers['Content-Length'])

src/pip/_internal/network/xmlrpc.py

@@ -44,6 +44,7 @@ class PipXmlrpcTransport(xmlrpc_client.Transport):
             self.verbose = verbose
             return self.parse_response(response.raw)
         except NetworkConnectionError as exc:
+            assert exc.response
             logger.critical(
                 "HTTP error %s while getting %s",
                 exc.response.status_code, url,

tests/lib/requests_mocks.py

@@ -25,6 +25,7 @@ class MockResponse(object):
         self.raw = FakeStream(contents)
         self.content = contents
         self.request = None
+        self.reason = None
         self.status_code = 200
         self.connection = None
         self.url = None