提交 db77463b 编写于 作者: H huzongtang

[ISSUE#1429]Update Broker's Topic Read or Write Perm failed.

上级 74ffae6d
...@@ -16,12 +16,16 @@ ...@@ -16,12 +16,16 @@
*/ */
package org.apache.rocketmq.tools.command.topic; package org.apache.rocketmq.tools.command.topic;
import java.util.HashMap;
import java.util.List; import java.util.List;
import java.util.Map;
import java.util.Set; import java.util.Set;
import org.apache.commons.cli.CommandLine; import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.Option; import org.apache.commons.cli.Option;
import org.apache.commons.cli.Options; import org.apache.commons.cli.Options;
import org.apache.rocketmq.common.MixAll;
import org.apache.rocketmq.common.TopicConfig; import org.apache.rocketmq.common.TopicConfig;
import org.apache.rocketmq.common.protocol.route.BrokerData;
import org.apache.rocketmq.common.protocol.route.QueueData; import org.apache.rocketmq.common.protocol.route.QueueData;
import org.apache.rocketmq.common.protocol.route.TopicRouteData; import org.apache.rocketmq.common.protocol.route.TopicRouteData;
import org.apache.rocketmq.remoting.RPCHook; import org.apache.rocketmq.remoting.RPCHook;
...@@ -67,46 +71,91 @@ public class UpdateTopicPermSubCommand implements SubCommand { ...@@ -67,46 +71,91 @@ public class UpdateTopicPermSubCommand implements SubCommand {
@Override @Override
public void execute(final CommandLine commandLine, final Options options, public void execute(final CommandLine commandLine, final Options options,
RPCHook rpcHook) throws SubCommandException { RPCHook rpcHook) throws SubCommandException {
DefaultMQAdminExt defaultMQAdminExt = new DefaultMQAdminExt(rpcHook); DefaultMQAdminExt defaultMQAdminExt = new DefaultMQAdminExt(rpcHook);
defaultMQAdminExt.setInstanceName(Long.toString(System.currentTimeMillis())); defaultMQAdminExt.setInstanceName(Long.toString(System.currentTimeMillis()));
try { try {
defaultMQAdminExt.start(); defaultMQAdminExt.start();
TopicConfig topicConfig = new TopicConfig();
String topic = commandLine.getOptionValue('t').trim(); TopicConfig topicConfig = new TopicConfig();
String topic;
if (commandLine.hasOption('t')) {
topic = commandLine.getOptionValue('t').trim();
} else {
System.out.printf("topic paramter value must be need.%n");
return;
}
TopicRouteData topicRouteData = defaultMQAdminExt.examineTopicRouteInfo(topic); TopicRouteData topicRouteData = defaultMQAdminExt.examineTopicRouteInfo(topic);
assert topicRouteData != null; assert topicRouteData != null;
List<QueueData> queueDatas = topicRouteData.getQueueDatas(); List<QueueData> queueDatas = topicRouteData.getQueueDatas();
assert queueDatas != null && queueDatas.size() > 0; assert queueDatas != null && queueDatas.size() > 0;
QueueData queueData = queueDatas.get(0); QueueData queueData = queueDatas.get(0);
topicConfig.setTopicName(topic); topicConfig.setTopicName(topic);
topicConfig.setWriteQueueNums(queueData.getWriteQueueNums()); topicConfig.setWriteQueueNums(queueData.getWriteQueueNums());
topicConfig.setReadQueueNums(queueData.getReadQueueNums()); topicConfig.setReadQueueNums(queueData.getReadQueueNums());
topicConfig.setPerm(queueData.getPerm());
topicConfig.setTopicSysFlag(queueData.getTopicSynFlag()); topicConfig.setTopicSysFlag(queueData.getTopicSynFlag());
//new perm //new perm
int perm = Integer.parseInt(commandLine.getOptionValue('p').trim()); int perm;
int oldPerm = topicConfig.getPerm(); if (commandLine.hasOption('p')) {
if (perm == oldPerm) { perm = Integer.parseInt(commandLine.getOptionValue('p').trim());
System.out.printf("new perm equals to the old one!%n"); } else {
System.out.printf("perm paramter value must be need.%n");
return; return;
} }
topicConfig.setPerm(perm); topicConfig.setPerm(perm);
if (commandLine.hasOption('b')) { if (commandLine.hasOption('b')) {
String addr = commandLine.getOptionValue('b').trim(); String brokerAddr = commandLine.getOptionValue('b').trim();
defaultMQAdminExt.createAndUpdateTopicConfig(addr, topicConfig); List<BrokerData> brokerDatas = topicRouteData.getBrokerDatas();
System.out.printf("update topic perm from %s to %s in %s success.%n", oldPerm, perm, addr); boolean isBrokerLegal = false;
System.out.printf("%s%n", topicConfig); String brokerName = null;
return; for (BrokerData data : brokerDatas) {
HashMap<Long, String> brokerAddrs = data.getBrokerAddrs();
if (brokerAddrs == null || brokerAddrs.size() == 0) {
continue;
}
for (Map.Entry<Long, String> entry : brokerAddrs.entrySet()) {
if (brokerAddr.equals(entry.getValue()) && MixAll.MASTER_ID == entry.getKey()) {
isBrokerLegal = true;
brokerName = data.getBrokerName();
break;
}
}
if (isBrokerLegal) {
break;
}
}
if (isBrokerLegal && brokerName != null) {
List<QueueData> queueDataList = topicRouteData.getQueueDatas();
assert queueDataList != null && queueDataList.size() > 0;
int oldPerm = 0;
for (QueueData data : queueDataList) {
if (brokerName.equals(data.getBrokerName())) {
oldPerm = data.getPerm();
if (perm == oldPerm) {
System.out.printf("new perm equals to the old one!%n");
return;
}
break;
}
}
defaultMQAdminExt.createAndUpdateTopicConfig(brokerAddr, topicConfig);
System.out.printf("update topic perm from %s to %s in %s success.%n", oldPerm, perm, brokerAddr);
System.out.printf("%s.%n", topicConfig);
return;
} else {
System.out.printf("updateTopicPerm error broker not exit or broker is not master!.%n");
return;
}
} else if (commandLine.hasOption('c')) { } else if (commandLine.hasOption('c')) {
String clusterName = commandLine.getOptionValue('c').trim(); String clusterName = commandLine.getOptionValue('c').trim();
Set<String> masterSet = Set<String> masterSet =
CommandUtil.fetchMasterAddrByClusterName(defaultMQAdminExt, clusterName); CommandUtil.fetchMasterAddrByClusterName(defaultMQAdminExt, clusterName);
for (String addr : masterSet) { for (String addr : masterSet) {
defaultMQAdminExt.createAndUpdateTopicConfig(addr, topicConfig); defaultMQAdminExt.createAndUpdateTopicConfig(addr, topicConfig);
System.out.printf("update topic perm from %s to %s in %s success.%n", oldPerm, perm, addr); System.out.printf("update topic perm from %s to %s in %s success.%n", queueData.getPerm(), perm, addr);
} }
return; return;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册