提交 ffb712a9 编写于 作者: T terrymanu

for checkstyle

上级 d576af60
......@@ -5,6 +5,8 @@ import com.dangdang.ddframe.rdb.common.jaxb.SQLStatements;
import com.dangdang.ddframe.rdb.integrate.jaxb.helper.SQLAssertJAXBHelper;
import com.dangdang.ddframe.rdb.sharding.constant.DatabaseType;
import com.google.common.collect.Sets;
import lombok.AccessLevel;
import lombok.NoArgsConstructor;
import javax.xml.bind.JAXBContext;
import javax.xml.bind.JAXBException;
......@@ -17,15 +19,16 @@ import java.util.HashSet;
import java.util.Map;
import java.util.Set;
public class SQLStatementHelper {
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class SQLStatementHelper {
private static final Map<String, SQLStatement> statementMap;
private static final Map<String, SQLStatement> STATEMENT_MAP;
private static final Map<String, SQLStatement> unsuppportedStatementMap;
private static final Map<String, SQLStatement> UNSUPPORTED_STATEMENT_MAP;
static {
statementMap = loadSqlStatements("sql");
unsuppportedStatementMap = loadSqlStatements("sql/unsupported");
STATEMENT_MAP = loadSqlStatements("sql");
UNSUPPORTED_STATEMENT_MAP = loadSqlStatements("sql/unsupported");
}
private static Map<String, SQLStatement> loadSqlStatements(final String directory) {
......@@ -59,18 +62,18 @@ public class SQLStatementHelper {
}
public static Collection<SQLStatement> getUnsupportedSqlStatements() {
return unsuppportedStatementMap.values();
return UNSUPPORTED_STATEMENT_MAP.values();
}
public static String getSql(final String sqlId) {
return statementMap.get(sqlId).getSql();
return STATEMENT_MAP.get(sqlId).getSql();
}
public static Set<DatabaseType> getTypes(final String sqlId) {
if (null == sqlId || !statementMap.containsKey(sqlId)) {
if (null == sqlId || !STATEMENT_MAP.containsKey(sqlId)) {
return Collections.emptySet();
}
SQLStatement statement = statementMap.get(sqlId);
SQLStatement statement = STATEMENT_MAP.get(sqlId);
if (null == statement.getTypes()) {
return Sets.newHashSet(DatabaseType.values());
}
......
package com.dangdang.ddframe.rdb.sharding.parsing;
/**
* Created by caohao on 2017/8/10.
*/
public class ParameterTestUnit {
}
......@@ -44,7 +44,7 @@ public final class UnsupportedSQLParsingEngineTest {
private Set<DatabaseType> types;
public UnsupportedSQLParsingEngineTest(final String testCaseName, final String sql, Set<DatabaseType> types) {
public UnsupportedSQLParsingEngineTest(final String testCaseName, final String sql, final Set<DatabaseType> types) {
this.testcaseName = testCaseName;
this.sql = sql;
this.types = types;
......
......@@ -123,7 +123,6 @@ public abstract class AbstractBaseParseSQLTest extends AbstractBaseParseTest {
return result;
}
private void assertOrderBy(final SelectStatement actual) {
Iterator<OrderItem> orderByColumns = getExpectedOrderByColumns().iterator();
for (OrderItem each : actual.getOrderByItems()) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册