refactor

sharding-jdbc-core/src/main/java/com/dangdang/ddframe/rdb/sharding/merger/component/reducer/MemoryOrderByReducerResultSet.java

@@ -17,13 +17,14 @@
 
 package com.dangdang.ddframe.rdb.sharding.merger.component.reducer;
 
+import java.sql.ResultSet;
+import java.util.List;
+
 import com.dangdang.ddframe.rdb.sharding.jdbc.adapter.AbstractDelegateResultSetAdapter;
 import com.dangdang.ddframe.rdb.sharding.merger.component.ReducerResultSet;
 import com.dangdang.ddframe.rdb.sharding.merger.component.other.MemoryOrderByResultSet;
 import com.dangdang.ddframe.rdb.sharding.parser.result.merger.OrderByColumn;
-
-import java.sql.ResultSet;
-import java.util.List;
+import lombok.RequiredArgsConstructor;
 
 /**
  * 根据排序列进行内存中排序.
@@ -31,18 +32,13 @@ import java.util.List;
  * @author gaohongtao
  */
 // TODO 和MemoryOrderByResultSet能否合二为一
+@RequiredArgsConstructor
 public class MemoryOrderByReducerResultSet extends AbstractDelegateResultSetAdapter implements ReducerResultSet {
     
     private final List<OrderByColumn> orderByColumns;
     
-    // TODO 使用lombok?
-    public MemoryOrderByReducerResultSet(final List<OrderByColumn> orderByColumns) {
-        this.orderByColumns = orderByColumns;
-    }
-    
     @Override
     public void init(final List<ResultSet> preResultSet) {
         setDelegatedResultSet(new MemoryOrderByResultSet(preResultSet, orderByColumns));
     }
-    
 }

sharding-jdbc-core/src/main/java/com/dangdang/ddframe/rdb/sharding/merger/component/reducer/StreamingOrderByReducerResultSet.java

@@ -17,6 +17,12 @@
 
 package com.dangdang.ddframe.rdb.sharding.merger.component.reducer;
 
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Queue;
+
 import com.dangdang.ddframe.rdb.sharding.exception.ShardingJdbcException;
 import com.dangdang.ddframe.rdb.sharding.jdbc.adapter.AbstractResultSetAdapter;
 import com.dangdang.ddframe.rdb.sharding.merger.component.ReducerResultSet;
@@ -26,12 +32,6 @@ import com.google.common.base.Predicate;
 import com.google.common.collect.Collections2;
 import lombok.extern.slf4j.Slf4j;
 
-import java.sql.ResultSet;
-import java.sql.SQLException;
-import java.util.LinkedList;
-import java.util.List;
-import java.util.Queue;
-
 /**
  * 流式排序.
  *
@@ -55,7 +55,7 @@ public class StreamingOrderByReducerResultSet extends AbstractResultSetAdapter i
     
     @Override
     // TODO preResultSet什么意思, 如果是复数需要加s
-    public void init(final List<ResultSet> preResultSet) throws SQLException {
+    public void init(final List<ResultSet> preResultSet) {
         // TODO 以下两步可否通过构造器
         setResultSets(preResultSet);
         setCurrentResultSet(preResultSet.get(0));