remove useless TransactionType.find

sharding-core/src/main/java/io/shardingsphere/core/constant/transaction/TransactionType.java

@@ -24,20 +24,5 @@ package io.shardingsphere.core.constant.transaction;
  */
 public enum TransactionType {
     
-    LOCAL, XA, BASE;
-    
-    /**
-     * Find transaction type by name.
-     *
-     * @param name name of transaction type
-     * @return transaction type
-     */
-    public static TransactionType find(final String name) {
-        for (TransactionType each : TransactionType.values()) {
-            if (name.equals(each.name())) {
-                return each;
-            }
-        }
-        throw new UnsupportedOperationException(String.format("Cannot find transaction type of [%s]", name));
-    }
+    LOCAL, XA, BASE
 }

sharding-core/src/main/java/io/shardingsphere/spi/transaction/ShardingTransactionHandlerRegistry.java

@@ -40,6 +40,15 @@ public final class ShardingTransactionHandlerRegistry {
     
     private static final ShardingTransactionHandlerRegistry INSTANCE = new ShardingTransactionHandlerRegistry();
     
+    /**
+     * Get instance of sharding transaction handler registry.
+     *
+     * @return sharding transaction handler registry
+     */
+    public static ShardingTransactionHandlerRegistry getInstance() {
+        return INSTANCE;
+    }
+    
     /**
      * Load sharding transaction handler.
      */
@@ -55,15 +64,6 @@ public final class ShardingTransactionHandlerRegistry {
         }
     }
     
-    /**
-     * Get instance of sharding transaction handler registry.
-     *
-     * @return sharding transaction handler registry
-     */
-    public static ShardingTransactionHandlerRegistry getInstance() {
-        return INSTANCE;
-    }
-    
     /**
      * Get transaction handler by type.
      *

sharding-jdbc/sharding-jdbc-core/src/main/java/io/shardingsphere/shardingjdbc/jdbc/adapter/AbstractConnectionAdapter.java

@@ -84,7 +84,7 @@ public abstract class AbstractConnectionAdapter extends AbstractUnsupportedOpera
         rootInvokeHook.start();
         this.transactionType = transactionType;
         shardingTransactionHandler = ShardingTransactionHandlerRegistry.getInstance().getHandler(transactionType);
-        if (transactionType != TransactionType.LOCAL) {
+        if (TransactionType.LOCAL != transactionType) {
             Preconditions.checkNotNull(shardingTransactionHandler, String.format("Cannot find transaction manager of [%s]", transactionType));
         }
     }

sharding-jdbc/sharding-jdbc-core/src/main/java/io/shardingsphere/shardingjdbc/jdbc/core/datasource/ShardingDataSource.java

@@ -69,7 +69,7 @@ public class ShardingDataSource extends AbstractDataSourceAdapter {
     @Override
     public final ShardingConnection getConnection() {
         if (TransactionType.XA == TransactionTypeHolder.get()) {
-            if (null != getXaDataSourceMap() && getXaDataSourceMap().isEmpty()) {
+            if (null != getXaDataSourceMap() && !getXaDataSourceMap().isEmpty()) {
                 return new ShardingConnection(getXaDataSourceMap(), shardingContext, TransactionType.XA);
             }
             log.warn("XA transaction resource have not load, using Local transaction instead!");

sharding-jdbc/sharding-jdbc-core/src/test/java/io/shardingsphere/shardingjdbc/jdbc/core/datasource/ShardingDataSourceTest.java

@@ -179,7 +179,6 @@ public final class ShardingDataSourceTest {
         assertThat(shardingConnection.getDataSourceMap().size(), is(1));
         assertThat(shardingConnection.getTransactionType(), is(TransactionType.XA));
         assertThat(shardingConnection.getShardingTransactionHandler(), instanceOf(FixedXAShardingTransactionHandler.class));
-        
         TransactionTypeHolder.set(TransactionType.LOCAL);
         shardingConnection = shardingDataSource.getConnection();
         assertThat(shardingConnection.getConnection("ds"), is(dataSource.getConnection()));

sharding-proxy/src/main/java/io/shardingsphere/shardingproxy/backend/sctl/ShardingCTLSetBackendHandler.java

@@ -49,7 +49,7 @@ public final class ShardingCTLSetBackendHandler extends AbstractBackendHandler {
         }
         switch (shardingTCLStatement.get().getKey()) {
             case "TRANSACTION_TYPE":
-                backendConnection.setTransactionType(TransactionType.find(shardingTCLStatement.get().getValue()));
+                backendConnection.setTransactionType(TransactionType.valueOf(shardingTCLStatement.get().getValue()));
                 break;
             default:
                 return new CommandResponsePackets(new ErrPacket(String.format(" could not support this sctl grammar [%s].", sql)));