提交 8180bc5e 编写于 作者: T terrymanu

for #1941, refactor PostgreSQLCommandPacket

上级 86c04995
......@@ -23,7 +23,7 @@ import org.apache.shardingsphere.shardingproxy.transport.mysql.packet.MySQLPacke
import org.apache.shardingsphere.shardingproxy.transport.mysql.payload.MySQLPacketPayload;
/**
* MySQL command packet.
* Command packet for MySQL.
*
* @author zhangliang
*/
......
......@@ -21,9 +21,9 @@ import org.apache.shardingsphere.shardingproxy.transport.api.packet.CommandPacke
import org.apache.shardingsphere.shardingproxy.transport.postgresql.packet.PostgreSQLPacket;
/**
* PostgreSQL command packet.
* Command packet for PostgreSQL.
*
* @author zhangyonglun
*/
public interface PostgreSQLCommandPacket extends PostgreSQLPacket, CommandPacket {
public abstract class PostgreSQLCommandPacket implements PostgreSQLPacket, CommandPacket {
}
......@@ -28,7 +28,7 @@ import org.apache.shardingsphere.shardingproxy.transport.postgresql.payload.Post
* @author zhangyonglun
*/
@RequiredArgsConstructor
public final class PostgreSQLUnsupportedCommandPacket implements PostgreSQLCommandPacket {
public final class PostgreSQLUnsupportedCommandPacket extends PostgreSQLCommandPacket {
@Getter
private final char messageType;
......
......@@ -28,21 +28,22 @@ import org.apache.shardingsphere.shardingproxy.transport.postgresql.payload.Post
import java.sql.SQLException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
/**
* PostgreSQL command bind packet.
* Command bind packet for PostgreSQL.
*
* @author zhangyonglun
*/
@Getter
public final class PostgreSQLComBindPacket implements PostgreSQLCommandPacket {
public final class PostgreSQLComBindPacket extends PostgreSQLCommandPacket {
private final String statementId;
private final PostgreSQLBinaryStatement binaryStatement;
private List<Object> parameters;
private final List<Object> parameters;
private final boolean binaryRowData;
......@@ -57,6 +58,8 @@ public final class PostgreSQLComBindPacket implements PostgreSQLCommandPacket {
binaryStatement = BinaryStatementRegistry.getInstance().get(connectionId).getBinaryStatement(statementId);
if (null != binaryStatement && null != binaryStatement.getSql()) {
parameters = getParameters(payload);
} else {
parameters = Collections.emptyList();
}
int resultFormatsLength = payload.readInt2();
binaryRowData = resultFormatsLength > 0;
......
......@@ -46,7 +46,7 @@ import java.util.LinkedList;
import java.util.List;
/**
* PostgreSQL command bind packet executor.
* Command bind packet executor for PostgreSQL.
*
* @author zhangyonglun
* @author zhangliang
......
......@@ -23,12 +23,12 @@ import org.apache.shardingsphere.shardingproxy.transport.postgresql.packet.comma
import org.apache.shardingsphere.shardingproxy.transport.postgresql.payload.PostgreSQLPacketPayload;
/**
* PostgreSQL command describe packet.
* Command describe packet for PostgreSQL.
*
* @author zhangyonglun
*/
@Getter
public final class PostgreSQLComDescribePacket implements PostgreSQLCommandPacket {
public final class PostgreSQLComDescribePacket extends PostgreSQLCommandPacket {
public PostgreSQLComDescribePacket(final PostgreSQLPacketPayload payload) {
payload.readInt4();
......
......@@ -26,7 +26,7 @@ import java.util.Collection;
import java.util.Collections;
/**
* PostgreSQL command describe packet executor.
* Command describe packet executor for PostgreSQL.
*
* @author zhangyonglun
* @author zhangliang
......
......@@ -22,11 +22,11 @@ import org.apache.shardingsphere.shardingproxy.transport.postgresql.packet.comma
import org.apache.shardingsphere.shardingproxy.transport.postgresql.payload.PostgreSQLPacketPayload;
/**
* PostgreSQL command execute packet.
* Command execute packet for PostgreSQL.
*
* @author zhangyonglun
*/
public final class PostgreSQLComExecutePacket implements PostgreSQLCommandPacket {
public final class PostgreSQLComExecutePacket extends PostgreSQLCommandPacket {
public PostgreSQLComExecutePacket(final PostgreSQLPacketPayload payload) {
payload.readInt4();
......
......@@ -26,7 +26,7 @@ import java.util.Collection;
import java.util.Collections;
/**
* PostgreSQL command execute packet executor.
* Command execute packet executor for PostgreSQL.
*
* @author zhangyonglun
* @author zhangliang
......
......@@ -30,12 +30,12 @@ import java.util.ArrayList;
import java.util.List;
/**
* PostgreSQL command parse packet.
* Command parse packet for PostgreSQL.
*
* @author zhangyonglun
*/
@Getter
public final class PostgreSQLComParsePacket implements PostgreSQLCommandPacket {
public final class PostgreSQLComParsePacket extends PostgreSQLCommandPacket {
private final ConnectionScopeBinaryStatementRegistry binaryStatementRegistry;
......
......@@ -22,11 +22,11 @@ import org.apache.shardingsphere.shardingproxy.transport.postgresql.packet.comma
import org.apache.shardingsphere.shardingproxy.transport.postgresql.payload.PostgreSQLPacketPayload;
/**
* PostgreSQL command sync packet.
* Command sync packet for PostgreSQL.
*
* @author zhangyonglun
*/
public final class PostgreSQLComSyncPacket implements PostgreSQLCommandPacket {
public final class PostgreSQLComSyncPacket extends PostgreSQLCommandPacket {
public PostgreSQLComSyncPacket(final PostgreSQLPacketPayload payload) {
payload.readInt4();
......
......@@ -26,7 +26,7 @@ import java.util.Collection;
import java.util.Collections;
/**
* PostgreSQL command sync packet executor.
* Command sync packet executor for PostgreSQL.
*
* @author zhangyonglun
* @author zhangliang
......
......@@ -23,12 +23,12 @@ import org.apache.shardingsphere.shardingproxy.transport.postgresql.packet.comma
import org.apache.shardingsphere.shardingproxy.transport.postgresql.payload.PostgreSQLPacketPayload;
/**
* PostgreSQL command query packet.
* Command query packet for PostgreSQL.
*
* @author zhangyonglun
*/
@Getter
public final class PostgreSQLComQueryPacket implements PostgreSQLCommandPacket {
public final class PostgreSQLComQueryPacket extends PostgreSQLCommandPacket {
private final String sql;
......
......@@ -42,7 +42,7 @@ import java.util.LinkedList;
import java.util.List;
/**
* PostgreSQL command query packet executor.
* Command query packet executor for PostgreSQL.
*
* @author zhangyonglun
* @author zhangliang
......
......@@ -22,11 +22,11 @@ import org.apache.shardingsphere.shardingproxy.transport.postgresql.packet.comma
import org.apache.shardingsphere.shardingproxy.transport.postgresql.payload.PostgreSQLPacketPayload;
/**
* PostgreSQL command termination packet.
* Command termination packet for PostgreSQL.
*
* @author zhangyonglun
*/
public final class PostgreSQLComTerminationPacket implements PostgreSQLCommandPacket {
public final class PostgreSQLComTerminationPacket extends PostgreSQLCommandPacket {
public PostgreSQLComTerminationPacket(final PostgreSQLPacketPayload payload) {
payload.readInt4();
......
......@@ -26,7 +26,7 @@ import java.util.Collection;
import java.util.Collections;
/**
* PostgreSQL command termination packet executor.
* Command termination packet executor for PostgreSQL.
*
* @author zhangliang
*/
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册