未验证 提交 6f9294f0 编写于 作者: J Juan Pan(Trista) 提交者: GitHub

review parsing integrated tests (#4792)

上级 c873a3a2
......@@ -94,7 +94,7 @@ public final class ExpressionAssert {
* @param actual actual subquery segment
* @param expected expected subquery expression
*/
public static void assertSubquery(final SQLCaseAssertContext assertContext, final SubqueryExpressionSegment actual, final ExpectedSubquery expected) {
public static void assertSubqueryExpression(final SQLCaseAssertContext assertContext, final SubqueryExpressionSegment actual, final ExpectedSubquery expected) {
// TODO assert start index, stop index and sub select statement.
SelectStatementAssert.assertIs(assertContext, actual.getSubquery().getSelect(), expected.getSelectTestCases());
// SQLSegmentAssert.assertIs(assertContext, actual, expected);
......
......@@ -60,7 +60,5 @@ public final class InsertValuesClauseAssert {
AssignmentValueAssert.assertIs(assertContext, each, expected.getAssignmentValues().get(count));
count++;
}
// TODO assert start index and stop index
// SQLSegmentAssert.assertIs(assertContext, actual, expected);
}
}
......@@ -120,7 +120,7 @@ public final class WhereClauseAssert {
} else if (actual.getExpression() instanceof CommonExpressionSegment) {
ExpressionAssert.assertCommonExpression(assertContext, (ComplexExpressionSegment) actual.getExpression(), expected.getCommonExpression());
} else if (actual.getExpression() instanceof SubqueryExpressionSegment) {
ExpressionAssert.assertSubquery(assertContext, (SubqueryExpressionSegment) actual.getExpression(), expected.getSubquery());
ExpressionAssert.assertSubqueryExpression(assertContext, (SubqueryExpressionSegment) actual.getExpression(), expected.getSubquery());
}
// TODO assert start index and stop index
// SQLSegmentAssert.assertIs(assertContext, actual, expected);
......@@ -170,7 +170,7 @@ public final class WhereClauseAssert {
int count = 0;
for (ExpressionSegment each : actual.getSqlExpressions()) {
if (each instanceof SubqueryExpressionSegment) {
ExpressionAssert.assertSubquery(assertContext, (SubqueryExpressionSegment) each, expected.getSubqueries().get(count));
ExpressionAssert.assertSubqueryExpression(assertContext, (SubqueryExpressionSegment) each, expected.getSubqueries().get(count));
count++;
}
}
......@@ -192,7 +192,7 @@ public final class WhereClauseAssert {
} else if (actual instanceof CommonExpressionSegment) {
ExpressionAssert.assertCommonExpression(assertContext, (ComplexExpressionSegment) actual, expected.getBetweenCommonExpression());
} else if (actual instanceof SubqueryExpressionSegment) {
ExpressionAssert.assertSubquery(assertContext, (SubqueryExpressionSegment) actual, expected.getBetweenSubquery());
ExpressionAssert.assertSubqueryExpression(assertContext, (SubqueryExpressionSegment) actual, expected.getBetweenSubquery());
}
}
......@@ -204,7 +204,7 @@ public final class WhereClauseAssert {
} else if (actual instanceof CommonExpressionSegment) {
ExpressionAssert.assertCommonExpression(assertContext, (ComplexExpressionSegment) actual, expected.getAndCommonExpression());
} else if (actual instanceof SubqueryExpressionSegment) {
ExpressionAssert.assertSubquery(assertContext, (SubqueryExpressionSegment) actual, expected.getAndSubquery());
ExpressionAssert.assertSubqueryExpression(assertContext, (SubqueryExpressionSegment) actual, expected.getAndSubquery());
}
}
}
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册