未验证 提交 665fd5ff 编写于 作者: X xiaoyu 提交者: GitHub

rename database PropertyAlias to database PropertySynonym (#7026)

上级 127a0374
......@@ -103,7 +103,7 @@ public final class TestOrchestrationSchemaContexts extends OrchestrationSchemaCo
}
private DataSourceParameter createDataSourceParameter(final DataSourceConfiguration dataSourceConfig) {
bindAlias(dataSourceConfig);
bindSynonym(dataSourceConfig);
DataSourceParameter result = new DataSourceParameter();
for (Field each : result.getClass().getDeclaredFields()) {
try {
......@@ -117,8 +117,8 @@ public final class TestOrchestrationSchemaContexts extends OrchestrationSchemaCo
return result;
}
private static void bindAlias(final DataSourceConfiguration dataSourceConfiguration) {
dataSourceConfiguration.addPropertyAlias("url", "jdbcUrl");
dataSourceConfiguration.addPropertyAlias("user", "username");
private static void bindSynonym(final DataSourceConfiguration dataSourceConfiguration) {
dataSourceConfiguration.addPropertySynonym("url", "jdbcUrl");
dataSourceConfiguration.addPropertySynonym("user", "username");
}
}
......@@ -127,18 +127,18 @@ public final class DataSourceConfiguration {
}
/**
* Add property alias to shared configuration.
* Add property synonym to shared configuration.
*
* @param originalName original key for data source configuration property
* @param alias property alias for configuration
* @param synonym property synonym for configuration
*/
public void addPropertyAlias(final String originalName, final String alias) {
public void addPropertySynonym(final String originalName, final String synonym) {
if (props.containsKey(originalName)) {
props.put(alias, props.get(originalName));
props.put(synonym, props.get(originalName));
}
// TODO fixes by #6709
if (props.containsKey(alias)) {
props.put(originalName, props.get(alias));
if (props.containsKey(synonym)) {
props.put(originalName, props.get(synonym));
}
}
......
......@@ -73,15 +73,15 @@ public final class DataSourceConfigurationTest {
}
@Test
public void assertAddAlias() {
public void assertAddSynonym() {
HikariDataSource actualDataSource = new HikariDataSource();
actualDataSource.setDriverClassName("org.h2.Driver");
actualDataSource.setJdbcUrl("jdbc:h2:mem:test;DB_CLOSE_DELAY=-1;DATABASE_TO_UPPER=false;MODE=MySQL");
actualDataSource.setUsername("root");
actualDataSource.setPassword("root");
DataSourceConfiguration actual = DataSourceConfiguration.getDataSourceConfiguration(actualDataSource);
actual.addPropertyAlias("url", "jdbcUrl");
actual.addPropertyAlias("user", "username");
actual.addPropertySynonym("url", "jdbcUrl");
actual.addPropertySynonym("user", "username");
assertThat(actual.getDataSourceClassName(), is(HikariDataSource.class.getName()));
assertThat(actual.getProps().get("driverClassName").toString(), is("org.h2.Driver"));
assertThat(actual.getProps().get("jdbcUrl").toString(), is("jdbc:h2:mem:test;DB_CLOSE_DELAY=-1;DATABASE_TO_UPPER=false;MODE=MySQL"));
......
......@@ -75,7 +75,7 @@ public final class DataSourceConverter {
}
private static DataSourceParameter createDataSourceParameter(final DataSourceConfiguration dataSourceConfig) {
bindAlias(dataSourceConfig);
bindSynonym(dataSourceConfig);
DataSourceParameter result = new DataSourceParameter();
for (Field each : result.getClass().getDeclaredFields()) {
try {
......@@ -89,12 +89,12 @@ public final class DataSourceConverter {
return result;
}
private static void bindAlias(final DataSourceConfiguration dataSourceConfiguration) {
dataSourceConfiguration.addPropertyAlias("url", "jdbcUrl");
dataSourceConfiguration.addPropertyAlias("user", "username");
dataSourceConfiguration.addPropertyAlias("connectionTimeout", "connectionTimeoutMilliseconds");
dataSourceConfiguration.addPropertyAlias("maxLifetime", "maxLifetimeMilliseconds");
dataSourceConfiguration.addPropertyAlias("idleTimeout", "idleTimeoutMilliseconds");
private static void bindSynonym(final DataSourceConfiguration dataSourceConfiguration) {
dataSourceConfiguration.addPropertySynonym("url", "jdbcUrl");
dataSourceConfiguration.addPropertySynonym("user", "username");
dataSourceConfiguration.addPropertySynonym("connectionTimeout", "connectionTimeoutMilliseconds");
dataSourceConfiguration.addPropertySynonym("maxLifetime", "maxLifetimeMilliseconds");
dataSourceConfiguration.addPropertySynonym("idleTimeout", "idleTimeoutMilliseconds");
}
/**
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册