提交 c648981c 编写于 作者: S Sergii Zhevzhyk 提交者: Sijie Guo

Remove duplicated lombok annotations in the pulsar-io modules (#5911)

### Motivation

Most of the configuration classes of the connectors had the following annotations:

```
@data
@Setter	
@Getter	
@EqualsAndHashCode	
@ToString
```

The [@data](https://projectlombok.org/features/Data) annotation includes all other annotations:

> All together now: A shortcut for @ToString, @EqualsAndHashCode, @Getter on all fields, @Setter on all non-final fields, and @RequiredArgsConstructor!


### Modifications

Removed `@Setter`, `@Getter`, `@EqualsAndHashCode`, and '@ToString' if the `@data` annotation was also present
上级 1aa32994
......@@ -21,7 +21,7 @@ package org.apache.pulsar.io.aerospike;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import lombok.*;
import lombok.Data;
import lombok.experimental.Accessors;
import java.io.File;
......@@ -30,10 +30,6 @@ import java.io.Serializable;
import java.util.Map;
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class AerospikeSinkConfig implements Serializable {
......
......@@ -20,7 +20,7 @@ package org.apache.pulsar.io.canal;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import lombok.*;
import lombok.Data;
import lombok.experimental.Accessors;
import java.io.File;
......@@ -34,10 +34,6 @@ import org.apache.pulsar.io.core.annotations.FieldDoc;
* Canal source config.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class CanalSourceConfig implements Serializable{
......
......@@ -21,7 +21,7 @@ package org.apache.pulsar.io.cassandra;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import lombok.*;
import lombok.Data;
import lombok.experimental.Accessors;
import java.io.File;
......@@ -31,10 +31,6 @@ import java.util.Map;
import org.apache.pulsar.io.core.annotations.FieldDoc;
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class CassandraSinkConfig implements Serializable {
......
......@@ -25,10 +25,6 @@ import java.io.IOException;
import java.io.Serializable;
import java.util.Map;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.commons.lang3.StringUtils;
import org.apache.pulsar.io.core.annotations.FieldDoc;
......@@ -37,10 +33,6 @@ import org.apache.pulsar.io.core.annotations.FieldDoc;
* Configuration class for the ElasticSearch Sink Connector.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class ElasticSearchConfig implements Serializable {
......
......@@ -33,10 +33,6 @@ import java.util.regex.Pattern;
import java.util.regex.PatternSyntaxException;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.commons.lang3.StringUtils;
......@@ -44,10 +40,6 @@ import org.apache.commons.lang3.StringUtils;
* Configuration class for the File Source Connector.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class FileSourceConfig implements Serializable {
......
......@@ -20,7 +20,7 @@ package org.apache.pulsar.io.flume;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import lombok.*;
import lombok.Data;
import lombok.experimental.Accessors;
import org.apache.pulsar.io.core.annotations.FieldDoc;
......@@ -32,10 +32,6 @@ import java.util.Map;
* Flume general config.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class FlumeConfig {
......
......@@ -21,10 +21,6 @@ package org.apache.pulsar.io.hbase;
import com.google.common.base.Preconditions;
import java.io.Serializable;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.pulsar.io.core.annotations.FieldDoc;
......@@ -32,10 +28,6 @@ import org.apache.pulsar.io.core.annotations.FieldDoc;
* Configuration object for all Hbase Sink components.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class HbaseAbstractConfig implements Serializable {
......
......@@ -21,10 +21,6 @@ package org.apache.pulsar.io.hbase.sink;
import com.google.common.base.Preconditions;
import com.google.common.collect.Lists;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.lang.StringUtils;
......@@ -56,10 +52,6 @@ import java.util.concurrent.TimeUnit;
public abstract class HbaseAbstractSink<T> implements Sink<T> {
@Data(staticConstructor = "of")
@Setter
@Getter
@EqualsAndHashCode
@ToString
public static class TableDefinition {
private final String rowKeyName;
private final String familyName;
......
......@@ -23,9 +23,6 @@ import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import com.google.common.base.Preconditions;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.pulsar.io.core.annotations.FieldDoc;
import org.apache.pulsar.io.hbase.HbaseAbstractConfig;
......@@ -36,10 +33,7 @@ import java.util.List;
import java.util.Map;
@Data
@Setter
@Getter
@EqualsAndHashCode(callSuper = false)
@ToString
@Accessors(chain = true)
public class HbaseSinkConfig extends HbaseAbstractConfig {
......
......@@ -19,8 +19,6 @@
package org.apache.pulsar.io.hbase.sink;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.ToString;
import lombok.extern.slf4j.Slf4j;
import org.apache.hadoop.hbase.client.Get;
import org.apache.hadoop.hbase.client.Result;
......@@ -66,8 +64,6 @@ public class HbaseGenericRecordSinkTest {
* A Simple class to test hbase class
*/
@Data
@ToString
@EqualsAndHashCode
public static class Foo {
private String rowKey;
private String name;
......
......@@ -21,10 +21,6 @@ package org.apache.pulsar.io.hdfs2;
import java.io.Serializable;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.commons.lang.StringUtils;
......@@ -33,10 +29,6 @@ import org.apache.commons.lang.StringUtils;
* Configuration object for all HDFS components.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public abstract class AbstractHdfsConfig implements Serializable {
......
......@@ -28,9 +28,6 @@ import java.util.Map;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.commons.lang.StringUtils;
......@@ -40,10 +37,7 @@ import org.apache.pulsar.io.hdfs2.AbstractHdfsConfig;
* Configuration object for all HDFS Sink components.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode(callSuper = false)
@ToString
@Accessors(chain = true)
public class HdfsSinkConfig extends AbstractHdfsConfig implements Serializable {
......
......@@ -21,10 +21,6 @@ package org.apache.pulsar.io.hdfs3;
import java.io.Serializable;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.commons.lang.StringUtils;
......@@ -33,10 +29,6 @@ import org.apache.commons.lang.StringUtils;
* Configuration object for all HDFS components.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public abstract class AbstractHdfsConfig implements Serializable {
......
......@@ -28,9 +28,6 @@ import java.util.Map;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.commons.lang.StringUtils;
......@@ -40,10 +37,7 @@ import org.apache.pulsar.io.hdfs3.AbstractHdfsConfig;
* Configuration object for all HDFS Sink components.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode(callSuper = false)
@ToString
@Accessors(chain = true)
public class HdfsSinkConfig extends AbstractHdfsConfig implements Serializable {
......
......@@ -22,10 +22,6 @@ import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import com.google.common.base.Preconditions;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.pulsar.io.core.annotations.FieldDoc;
......@@ -38,10 +34,6 @@ import java.util.Map;
* Configuration class for the InfluxDB Sink Connector.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class InfluxDBSinkConfig implements Serializable {
......
......@@ -63,8 +63,6 @@ public class InfluxDBGenericRecordSinkTest {
* A Simple class to test InfluxDB class
*/
@Data
@ToString
@EqualsAndHashCode
public static class Cpu {
private String measurement;
private String model;
......
......@@ -21,7 +21,7 @@ package org.apache.pulsar.io.jdbc;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import lombok.*;
import lombok.Data;
import lombok.experimental.Accessors;
import java.io.File;
......@@ -31,10 +31,6 @@ import java.util.Map;
import org.apache.pulsar.io.core.annotations.FieldDoc;
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class JdbcSinkConfig implements Serializable {
......
......@@ -28,7 +28,6 @@ import java.sql.DriverManager;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.Arrays;
import java.util.List;
import java.util.Properties;
import java.util.StringJoiner;
......@@ -47,10 +46,6 @@ import lombok.extern.slf4j.Slf4j;
public class JdbcUtils {
@Data(staticConstructor = "of")
@Setter
@Getter
@EqualsAndHashCode
@ToString
public static class TableId {
private final String catalogName;
private final String schemaName;
......@@ -58,10 +53,6 @@ public class JdbcUtils {
}
@Data(staticConstructor = "of")
@Setter
@Getter
@EqualsAndHashCode
@ToString
public static class ColumnId {
private final TableId tableId;
private final String name;
......
......@@ -27,8 +27,6 @@ import java.util.concurrent.CompletableFuture;
import java.util.concurrent.TimeUnit;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.ToString;
import lombok.extern.slf4j.Slf4j;
import org.apache.pulsar.client.api.Message;
import org.apache.pulsar.client.api.schema.GenericRecord;
......@@ -61,8 +59,6 @@ public class JdbcSinkTest {
* A Simple class to test jdbc class
*/
@Data
@ToString
@EqualsAndHashCode
public static class Foo {
private String field1;
private String field2;
......
......@@ -21,7 +21,7 @@ package org.apache.pulsar.io.kafka;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import lombok.*;
import lombok.Data;
import lombok.experimental.Accessors;
import java.io.File;
......@@ -31,10 +31,6 @@ import java.util.Map;
import org.apache.pulsar.io.core.annotations.FieldDoc;
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class KafkaSinkConfig implements Serializable {
......
......@@ -21,7 +21,7 @@ package org.apache.pulsar.io.kafka;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import lombok.*;
import lombok.Data;
import lombok.experimental.Accessors;
import java.io.File;
......@@ -31,10 +31,6 @@ import java.util.Map;
import org.apache.pulsar.io.core.annotations.FieldDoc;
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class KafkaSourceConfig implements Serializable {
......
......@@ -21,7 +21,7 @@ package org.apache.pulsar.io.mongodb;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import com.google.common.base.Preconditions;
import lombok.*;
import lombok.Data;
import lombok.experimental.Accessors;
import org.apache.commons.lang3.StringUtils;
import org.apache.pulsar.io.core.annotations.FieldDoc;
......@@ -35,10 +35,6 @@ import java.util.Map;
* Configuration class for the MongoDB Connectors.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class MongoConfig implements Serializable {
......
......@@ -27,10 +27,6 @@ import java.io.Serializable;
import java.util.Map;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.pulsar.io.core.annotations.FieldDoc;
......@@ -38,10 +34,6 @@ import org.apache.pulsar.io.core.annotations.FieldDoc;
* Netty Source Connector Config.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class NettySourceConfig implements Serializable {
......
......@@ -22,10 +22,6 @@ package org.apache.pulsar.io.rabbitmq;
import com.google.common.base.Preconditions;
import com.rabbitmq.client.ConnectionFactory;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.pulsar.io.core.annotations.FieldDoc;
......@@ -35,10 +31,6 @@ import java.io.Serializable;
* Configuration object for all RabbitMQ components.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class RabbitMQAbstractConfig implements Serializable {
......
......@@ -23,9 +23,6 @@ import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import com.google.common.base.Preconditions;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.pulsar.io.core.annotations.FieldDoc;
......@@ -35,10 +32,7 @@ import java.io.Serializable;
import java.util.Map;
@Data
@Setter
@Getter
@EqualsAndHashCode(callSuper = false)
@ToString
@Accessors(chain = true)
public class RabbitMQSinkConfig extends RabbitMQAbstractConfig implements Serializable {
......
......@@ -23,9 +23,6 @@ import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import com.google.common.base.Preconditions;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.pulsar.io.core.annotations.FieldDoc;
......@@ -35,10 +32,7 @@ import java.io.Serializable;
import java.util.Map;
@Data
@Setter
@Getter
@EqualsAndHashCode(callSuper = false)
@ToString
@Accessors(chain = true)
public class RabbitMQSourceConfig extends RabbitMQAbstractConfig implements Serializable {
......
......@@ -22,10 +22,6 @@ import com.google.common.base.Preconditions;
import com.google.common.collect.Lists;
import com.google.common.net.HostAndPort;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.commons.lang3.StringUtils;
import org.apache.pulsar.io.core.annotations.FieldDoc;
......@@ -37,10 +33,6 @@ import java.util.List;
* Configuration object for all Redis Sink components.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class RedisAbstractConfig implements Serializable {
......
......@@ -23,9 +23,6 @@ import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import com.google.common.base.Preconditions;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.pulsar.io.core.annotations.FieldDoc;
import org.apache.pulsar.io.redis.RedisAbstractConfig;
......@@ -36,10 +33,7 @@ import java.io.Serializable;
import java.util.Map;
@Data
@Setter
@Getter
@EqualsAndHashCode(callSuper = false)
@ToString
@Accessors(chain = true)
public class RedisSinkConfig extends RedisAbstractConfig implements Serializable {
......
......@@ -22,10 +22,6 @@ import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import com.google.common.base.Preconditions;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.pulsar.io.core.annotations.FieldDoc;
......@@ -38,10 +34,6 @@ import java.util.Map;
* Configuration class for the Solr Sink Connector.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class SolrSinkConfig implements Serializable {
......
......@@ -19,8 +19,6 @@
package org.apache.pulsar.io.solr;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.ToString;
import lombok.extern.slf4j.Slf4j;
import org.apache.pulsar.client.api.Message;
import org.apache.pulsar.client.api.schema.GenericRecord;
......@@ -55,8 +53,6 @@ public class SolrGenericRecordSinkTest {
* A Simple class to test solr class
*/
@Data
@ToString
@EqualsAndHashCode
public static class Foo {
private String field1;
private String field2;
......
......@@ -33,10 +33,6 @@ import java.util.List;
import java.util.Map;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import lombok.experimental.Accessors;
import org.apache.commons.collections.CollectionUtils;
......@@ -47,10 +43,6 @@ import org.apache.pulsar.io.core.annotations.FieldDoc;
* Configuration object for the Twitter Firehose Connector.
*/
@Data
@Setter
@Getter
@EqualsAndHashCode
@ToString
@Accessors(chain = true)
public class TwitterFireHoseConfig implements Serializable {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册