Fixed BestPix to always return the highest resolution available, even if a lower bit depth than the original

Use lept_free to free memory allocated by Leptonica

Delete unused code in PangoFontInfo

This fixes problems on Windows when Tesseract and Leptonica use different
C runtime libraries.
Signed-off-by: NStefan Weil <sw@weilnetz.de>

Signed-off-by: NStefan Weil <sw@weilnetz.de>

Signed-off-by: NStefan Weil <sw@weilnetz.de>

Signed-off-by: NStefan Weil <sw@weilnetz.de>

Remove also some macros which are no longer needed.
Signed-off-by: NStefan Weil <sw@weilnetz.de>

That restores commit 25e0c1ac and
partially revert commit 4907a23f
which added the now unused Shlwapi library.
Signed-off-by: NStefan Weil <sw@weilnetz.de>

Fix compiler warnings

This fixes these compiler warnings:

    ccmain/equationdetect.cpp:1519:2: warning: extra ‘;’ [-Wpedantic]
    ccstruct/blobs.cpp:65:17: warning: extra ‘;’ [-Wpedantic]
    ccstruct/blobs.h:178:18: warning: extra ‘;’ [-Wpedantic]
    ccstruct/ratngs.cpp:36:22: warning: extra ‘;’ [-Wpedantic]
    ccstruct/ratngs.cpp:37:22: warning: extra ‘;’ [-Wpedantic]
    ccutil/ambigs.cpp:46:20: warning: extra ‘;’ [-Wpedantic]
    ccutil/ambigs.h:137:21: warning: extra ‘;’ [-Wpedantic]
    cutil/structures.cpp:36:45: warning: extra ‘;’ [-Wpedantic]
    textord/equationdetectbase.cpp:65:2: warning: extra ‘;’ [-Wpedantic]
    textord/equationdetectbase.h:57:2: warning: extra ‘;’ [-Wpedantic]
    wordrec/lm_state.cpp:25:28: warning: extra ‘;’ [-Wpedantic]
    wordrec/lm_state.h:190:29: warning: extra ‘;’ [-Wpedantic]
Signed-off-by: NStefan Weil <sw@weilnetz.de>

Compiler warning:

    ccutil/unicharcompress.cpp:76:76: warning: format ‘%x’ expects argument of type ‘unsigned int*’, but argument 3 has type ‘int*’ [-Wformat=]
    ccutil/unicharcompress.cpp:80:31: warning: format ‘%x’ expects argument of type ‘unsigned int*’, but argument 3 has type ‘int*’ [-Wformat=]
Signed-off-by: NStefan Weil <sw@weilnetz.de>

A single bit cannot represent a signed integer value, so it must be an
unsigned integer. This fixes a compiler warning:

    In file included from ../ccutil/clst.h:24:0,
                     from ../ccstruct/blobbox.h:23,
                     from workingpartset.h:24,
                     from workingpartset.cpp:21:
    ../ccstruct/blobbox.h: In member function ‘void BLOBNBOX::set_reduced_box(TBOX)’:
    ../ccutil/host.h:79:25: warning: overflow in conversion from ‘int’ to ‘signed char:1’ changes value from ‘1’ to ‘-1’ [-Woverflow]
     #define TRUE            1
                             ^
    ../ccstruct/blobbox.h:236:17: note: in expansion of macro ‘TRUE’
           reduced = TRUE;
                     ^~~~
Signed-off-by: NStefan Weil <sw@weilnetz.de>

Move LSTM unicharset and recoder to traineddata with version string part1. Backwards compatible - maybe.

Added script-specific validation and normalization for virama-using scripts and updated normalization for others

Fixes from pull of cleanups: clang tidied, reviewed, fixed new bugs, undeleted needed code. Probably breaks the build, due to some inclusion of changes in utf8/32 conversion

fix filenames in comments (trivial)

Add new line to a few error messages.

Download the leptonica source from github

1.74.2 is no longer available from the leptonica website. But anyway, it seems safer going forward to download it from github. It's https, and it won't disappear as easily. Also, this is the same source used by travis, so there's less chance of shipping something untested.

LSTMTrainer: Catch empty vectors

Remove portability code which is no longer needed

It was only needed for MS Visual Studio 2012 and older.
Those compilers are not supported for Tesseract.
Signed-off-by: NStefan Weil <sw@weilnetz.de>

MS Visual Studio does not provide that function, but can use strtok_s
which does exactly the same.
Signed-off-by: NStefan Weil <sw@weilnetz.de>

Update from Leptonica 1.74.1 to 1.74.2

Signed-off-by: NStefan Weil <sw@weilnetz.de>

The newer version contains fixes for the pixUnsharpMaskingGray*
functions which are relevant for Tesseract (used in ImageData::PreScale
which calls pixScale).
Signed-off-by: NStefan Weil <sw@weilnetz.de>

The new test in LSTMTrainer::UpdateErrorGraph fixes an assertion
(see issues #644, #792).

The new test in LSTMTrainer::ReadTrainingDump was added to improve
the robustness of the code.
Signed-off-by: NStefan Weil <sw@weilnetz.de>

Clean OpenCL code

Remove several unused variables and fix some signed / unsigned mismatches.
Signed-off-by: NStefan Weil <sw@weilnetz.de>

Signed-off-by: NStefan Weil <sw@weilnetz.de>