未验证 提交 6a374b45 编写于 作者: B Boris Sekachev 提交者: GitHub

Fixed area checking for skeleton in case with two points (#6156)

<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
上级 4eb333e7
......@@ -33,12 +33,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Image scaling when moving between images with different resolution (<https://github.com/opencv/cvat/pull/6081>)
- Invalid completed job count reporting (<https://github.com/opencv/cvat/issues/6098>)
- OpenVINO-based Nuclio functions can now be deployed to Kubernetes
(<https://github.com/opencv/cvat/pull/6129>).
(<https://github.com/opencv/cvat/pull/6129>)
- Adjusted skeleton size checking after drawing (<https://github.com/opencv/cvat/pull/6156>)
- HRNet CPU serverless function
(<https://github.com/opencv/cvat/pull/6150>)
- Sending empty list of events
(<https://github.com/opencv/cvat/pull/6154>)
### Security
- TDB
......
{
"name": "cvat-canvas",
"version": "2.16.5",
"version": "2.16.6",
"description": "Part of Computer Vision Annotation Tool which presents its canvas library",
"main": "src/canvas.ts",
"scripts": {
......
......@@ -72,6 +72,11 @@ function checkConstraint(shapeType: string, points: number[], box: Box | null =
(points.length === 2 * 2 && (points[2] - points[0]) * (points[3] - points[1]) >= consts.AREA_THRESHOLD);
}
if (shapeType === 'skeleton') {
const [xtl, ytl, xbr, ybr] = points;
return (xbr - xtl >= 1 || ybr - ytl >= 1);
}
return false;
}
......@@ -762,7 +767,7 @@ export class DrawHandlerImpl implements DrawHandler {
this.release();
if (this.canceled) return;
if (checkConstraint('rectangle', [xtl, ytl, xbr, ybr])) {
if (checkConstraint('skeleton', [xtl, ytl, xbr, ybr])) {
this.onDrawDone({
clientID,
shapeType,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册