1. 13 2月, 2019 1 次提交
    • G
      Clang build fixes (#15628) · da9c94da
      Gabor Buella 提交于
      * Remove some superfluous std::move calls
      
      The std:move triggered a build error (with -Werror):
      ```
      [  9%] Building CXX object paddle/fluid/memory/allocation/CMakeFiles/allocator_facade.dir/allocator_facade.cc.o
      /home/tej/code/gbuella_paddle/paddle/fluid/memory/allocation/allocator_facade.cc:86:29: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
                  [this] { return std::move(CreateAllocatorWithChunk()); }, capacity);
                                  ^
      /home/tej/code/gbuella_paddle/paddle/fluid/memory/allocation/allocator_facade.cc:86:29: note: remove std::move call here
                  [this] { return std::move(CreateAllocatorWithChunk()); }, capacity);
                                  ^~~~~~~~~~                          ~
      1 error generated.
      ```
      
      See: https://reviews.llvm.org/D7633
      
      * Remove a superfluous lambda capture from framework/operator.h
      
      ```
      [ 10%] Building CXX object paddle/fluid/platform/CMakeFiles/device_context.dir/init.cc.o
      In file included from /home/tej/code/gbuella_paddle/paddle/fluid/platform/init.cc:19:
      /home/tej/code/gbuella_paddle/paddle/fluid/framework/operator.h:229:21: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]
                         [this](Variable* var) { return var; });
                          ^~~~
      1 error generated.
      ```
      
      Changing it to `return it->second;`, as is in the function below.
      
      * Rethrow an exception (instead of copying it)
      
      ```
      [ 11%] Building CXX object paddle/fluid/framework/CMakeFiles/operator.dir/operator.cc.o
      /home/tej/code/gbuella_paddle/paddle/fluid/framework/operator.cc:191:13: error: local variable 'exception' will be copied despite being thrown by name [-Werror,-Wreturn-std-move]
            throw exception;
                  ^~~~~~~~~
      /home/tej/code/gbuella_paddle/paddle/fluid/framework/operator.cc:191:13: note: call 'std::move' explicitly to avoid copying
            throw exception;
                  ^~~~~~~~~
                  std::move(exception)
      
      ```
      
      See https://reviews.llvm.org/D43322 for an explanation of this diagnostic message.
      
      * Remove an unused variable
      
      ```
      /home/tej/code/gbuella_paddle/paddle/fluid/framework/operator.cc:884:16: error: private field 'scope_' is not used [-Werror,-Wunused-private-field]
        const Scope& scope_;
                     ^
      ```
      
      * struct ComputationOpHandle -> class ComputationOpHandle
      
      ```
      [ 13%] Building CXX object paddle/fluid/framework/details/CMakeFiles/memory_early_delete_pass.dir/memory_early_delete_pass.cc.o
      In file included from /home/tej/code/gbuella_paddle/paddle/fluid/framework/details/memory_early_delete_pass.cc:21:
      /home/tej/code/gbuella_paddle/paddle/fluid/framework/details/reference_count_pass_helper.h:30:1: error: class 'ComputationOpHandle' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
      class ComputationOpHandle;
      ^
      /home/tej/code/gbuella_paddle/paddle/fluid/framework/details/computation_op_handle.h:29:8: note: previous use is here
      struct ComputationOpHandle : public OpHandleBase {
             ^
      /home/tej/code/gbuella_paddle/paddle/fluid/framework/details/reference_count_pass_helper.h:30:1: note: did you mean struct here?
      class ComputationOpHandle;
      ^~~~~
      struct
      1 error generated.
      ```
      
      * Fix name() methods under fluid/operators
      
      ```
      In file included from /home/tej/code/gbuella_paddle/paddle/fluid/operators/jit/gen/act.cc:15:
      In file included from /home/tej/code/gbuella_paddle/paddle/fluid/operators/jit/gen/act.h:19:
      /home/tej/code/gbuella_paddle/paddle/fluid/operators/jit/gen/jitcode.h:71:23: error: 'name' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        virtual const char* name() const = 0;
                            ^
      /home/tej/code/gbuella_paddle/paddle/fluid/operators/jit/gen_base.h:31:23: note: overridden virtual function is here
        virtual const char* name() const = 0;
                            ^
      ```
      
      test=develop
      da9c94da
  2. 14 1月, 2019 2 次提交
  3. 11 1月, 2019 2 次提交
    • C
      Revert "Remove workspace_handle in conv_cudnn (#15186)" · 358e657f
      chengduozh 提交于
      test=develop
      This reverts commit 064512aa.
      358e657f
    • C
      Remove workspace_handle in conv_cudnn (#15186) · 064512aa
      chengduo 提交于
      * remove workspace_handle in conv2d_cudnn
      test=develop
      
      * remove workspace_handle
      test=develop
      
      * fix bug
      test=develop
      
      * make test_conv2d_op SERIAL
      test=develop
      
      * save memory in conv_cudnn
      test=develop
      
      * enhance thread safety
      test=develop
      
      * enhance temporary allocator
      test=develop
      
      * Add excess fraction
      test=develop
      
      * follow comments
      test=develop
      
      * fix bug and code refine
      test=develop
      
      * fix memory size check
      test=develop
      
      * rename reuse_tmp_allocation_excess_fraction
      test=develop
      064512aa
  4. 09 1月, 2019 1 次提交
  5. 08 1月, 2019 1 次提交
  6. 07 1月, 2019 2 次提交
  7. 02 1月, 2019 1 次提交
  8. 29 12月, 2018 1 次提交
  9. 28 12月, 2018 2 次提交
  10. 27 12月, 2018 4 次提交
  11. 25 12月, 2018 1 次提交
  12. 20 12月, 2018 1 次提交
  13. 19 12月, 2018 1 次提交
  14. 18 12月, 2018 4 次提交
  15. 17 12月, 2018 1 次提交
  16. 13 12月, 2018 1 次提交
  17. 29 11月, 2018 4 次提交
  18. 27 11月, 2018 1 次提交
  19. 26 11月, 2018 1 次提交
  20. 25 11月, 2018 1 次提交
  21. 22 11月, 2018 1 次提交
    • W
      Windows/online (#14474) · d9a1f3e5
      wopeizl 提交于
      * add recordio support
      
      * disable the openblas multi-thread on windows since no support
      adjust the python script
      
      * code style
      
      * code style
      test=develop
      
      * add create_recordio_file_reader back
      
      * fix code style
      test=develop
      
      * fix the gtest.cmake on windows
      
      * fix cc_test on windows
      
      * fix the win build
      test=develop
      
      * remove fused compile support on windows
      test=develop
      
      * add the jit support
      test=develop
      
      * add the jit support, test=develop
      
      * add the jit support, test=develop
      
      * add the jit back
      fix compile error on windows
      
      * rollback test=develop
      
      * test case fix
      
      * disable DSO by default on windows
      
      * exclude warpctc_op on windows
      
      * exclude the dynload_warpctc out on windows
      test=develop
      
      * fix the scripts error
      test=develop
      
      * disable avx on windows by default
      test=develop
      
      * re-organize the cmake file
      
      * disable mkl on windows by default
      
      * add warp_ctc back
      
      * fix the dependency
      
      * fix the dependency
      
      * fix the build issue on windows
      
      * remove unsupported flag on windows
      
      * code style
      
      * code style
      test=develop
      
      * fix issue
      
      * add profiler, parallel_executor back
      
      * clean up the pre-definitions on windows
      
      * fix build issue
      
      * test=develop
      d9a1f3e5
  22. 21 11月, 2018 1 次提交
  23. 16 11月, 2018 1 次提交
  24. 08 11月, 2018 1 次提交
    • C
      Fix input<tensor> (#14208) · c5b6573a
      chengduo 提交于
      * fix input<tensor>
      test=develop
      
      * fix split_ids
      test=develop
      
      * ElementwiseMul should not support SelectedRows
      
      * fix scale op
      test=develop
      
      * change GetTensorFromVar() method to GetTensorOrSelectedRowsFromVar()
      
      * fix operator
      
      * refine MultiOutput
      
      * fix MultiOutput
      test=develop
      
      * disable test_dist_save_load
      test=develop
      
      * fix elementwise_op
      test=develop
      
      * add get_sparse_as_op
      test=develop
      
      * add info for check
      test=develop
      
      * rename get_sparse_as_op with extract_rows_as_op.
      test=develop
      
      * elementwise doesn't support selected_rows
      
      * fix regularizer
      
      * remove extract_rows_as
      test=develop
      
      * fix ci
      test=develop
      
      * add test for sum_op
      
      * fix regularizer
      test=develop
      
      *  test=develop
      
      * fix pserver weight decay multi inputs test=develop
      c5b6573a
  25. 01 11月, 2018 1 次提交
  26. 30 10月, 2018 1 次提交
  27. 24 9月, 2018 1 次提交