Reference: http://bugs.debian.org/717851

Many version checks fail because the uploaded version is identical to the one
already present. Make the message correct for that case as well.

Reference: <http://bugs.debian.org/710086#15>

Return the binary package name for the error message and not the package
object.

Give a proper error message if a source package includes an upstream
tarball, but doesn't have a Debian revision.

By default dpkg-source -x requires a valid signature, but uses different
keyrings than configured in dak. So this check can fail for signatures dak has
just verified as valid a bit earlier.

With this patch lintian will pass --no-check to dpkg-source to skip signature
(and checksum) verification.

As dak/examine_package.py is also used by process-new we cannot run
lintian unconditionally as the unprivileged user. Therefore move the
Unpriv{User,Group} setting from the database to a (group-specific)
dak.conf.

When moving the hash validation in e6b1c633
one occurrence of "what" was not changed to "filename".

drop usage of the DMUA flag, only use the new ACL set, as announced in
https://lists.debian.org/debian-devel-announce/2012/09/msg00012.html
and
https://lists.debian.org/debian-devel-announce/2012/09/msg00008.htmlSigned-off-by: NJoerg Jaspert <joerg@debian.org>

For now packages that use DMUA in the source package are still accepted.

There was one extra closing parens in a call to raise
RejectStupidMaintainerException (oops, stupid me), lets remove it.
Signed-off-by: NGergely Nagy <algernon@madhouse-project.org>

The external_files table is to be used by - for example -
security.d.o: we should export the files table to debian-security
under the disguised name of external_files.

We also introduce the use_extfiles setting, and a new check:
check.ExternalHashesCheck, which will compare the uploaded files
hashes to the external_files table, if that holds an entry for them.

It will only do that though, if the use_extfiles setting is on.
Signed-off-by: NGergely Nagy <algernon@madhouse-project.org>

Instead of setting the source within a for loop, set it outside, so it
does what it is supposed to do, instead of accidentally working
because self has a source field set too.
Signed-off-by: NGergely Nagy <algernon@madhouse-project.org>

allow our tempfile/tempdir generating function to chmod/chgrp the created
files/directories
use that to have the processed uploads and the lintian tagfile readable by
the dak-unpriv user/group
run lintian sudo-ed to dak-unpriv
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

This way suite mappings will also be evaluated for the DM checks.

Bug: http://bugs.debian.org/685807

Reintroduce the check that all source files for the used format are
actually included.

version_compare returns values less than, equal to or greater than zero.
This value is not always -1, 0 or 2(!) as the documentation claims.

Reference: http://bugs.debian.org/680891

DMs may upload to all suites, but only the highest version currently in
unstable, experimental or *-backports will be considered for DM-U-A.

If a package has architecture-specific packages or a buildd uploads only
architecture-dependant packages and there are also arch-indep packages,
the upload does not include all binaries from the Binary field.
Signed-off-by: NAnsgar Burchardt <ansgar@debian.org>

Uploads that do not include source would trigger an exception when
remove is used.  discard does not raise an exception when the element
does not exist.
Signed-off-by: NAnsgar Burchardt <ansgar@debian.org>