Newer SQLAlchemy versions seem to track the `binary` attribute of
`BinaryMetadata`.  This means the association proxy in `DBBinary`
would first create a `BinaryMetadata` with `binary` set to `None`,
flush this to the database and then set the actual value of `binary`
we want.  However the flush fails, as `NULL` is not allowed for the
`binary_id` column.

The problem can be avoided by not setting `binary` to `None`.  This is
treated as an "undefined value" by SQLAlchemy and changing it later
means the database row never sees `NULL`.

The same applies to the `source` attribute of `SourceMetadata`.

The orig tarball regexes match also the orig tarball detached
signatures because they are not anchored at the end, and the loop
short-circuits on first match. So we have to move them before their
more general counterparts.

Fixes commit 84f230b6.

Calling `f.read()` would read the entire file at once which is
wasteful. It's also not intended given the read loop.

Also replace a use of `readline()` with `read(65536)` as well where we
want to read the entire file and not only single lines.

We should only allow upstream tarballs with detached signatures, but not
native tarballs, «<source>_<version>.orig.asc» or «<source>_<version>.asc»
filenames. We also need to allow this on all relevant regexes. This commit
fixes and refactors the regexes to implement the above, and to make it
easier to modify a single place in the future.

Fixes commit 4911282c.

Closes: #759401

When there's an unknown file in a source package, the function spits
this:

  ,---
  Processing raised an exception: global name 'reject' is not defined.
  Traceback (most recent call last):
    File "/srv/ftp-master.debian.org/dak/dak/daklib/archive.py", line 966, in check
      chk().check(self)
    File "/srv/ftp-master.debian.org/dak/dak/daklib/checks.py", line 497, in check
      rejects = utils.check_dsc_files(dsc_fn, control, source.files.keys())
    File "/srv/ftp-master.debian.org/dak/dak/daklib/utils.py", line 343, in check_dsc_files
      reject("%s: unexpected source file '%s'" % (dsc_filename, f))
  NameError: global name 'reject' is not defined
  `---

Just set the reject message and break from the loop.

We used the remaining parameters before which is somewhat confusing.

This reverts commit 196b3433.

This should prevent changes to the {src,bin}_contents tables and result
in all helper processes seeing the same data.

This makes it less error-prone to switch compression methods: the files
that are no longer generated are automatically removed. Before they had
to be removed manually.

which is helpful when there are no .gz/.bz2 ones around to
look at.

* juliank/master:
  Only generate binary checksum fields for the requested ones
  Only generate fields in Sources for requested checksums
Signed-off-by: NJoerg Jaspert <joerg@debian.org>

This is the second step. As we are simply concatenating things,
we can just concatenate an empty string if we do not want a
checksum.

We make use of the fact that STRING_AGG ignores NULL values
when joining the values, so we do not get empty lines in there.

Mind, its still configured and exists, need to remove that, but this
should stop pushing the mirrors and changing it around.

Which makes running it inside a while loop a pain.
(Its ssh could use a -n,but this works too)

This just prepares the mirror tree and pushes the changes to the
mirrors.  It is intended to be used for point releases or in other
situations where a manual mirror push is needed.

Upstream tarballs usually come with detached signatures, which would be
useful to have in the source package, as an additional check that could
be performed to verify its integrity and provenance.

dpkg-source supports this since 1.17.20.

Closes: #759401

To: debian-dak@lists.debian.org
Cc: kibi@debian.org, Julien Cristau <jcristau@debian.org>
Date: Tue, 19 Jan 2016 11:40:01 +0100 (12 hours, 2 minutes, 47 seconds ago)
Resent-From: debian-dak@lists.debian.org

stable-proposed-updates is called "proposed-updates" in projectb, so
that's what we pass to the byhand script.  It shouldn't be turned into
"proposed-updates-proposed-updates".
Signed-off-by: NJulien Cristau <jcristau@debian.org>