queue.py 111.9 KB
Newer Older
J
New.  
James Troup 已提交
1
#!/usr/bin/env python
2
# vim:set et sw=4:
J
New.  
James Troup 已提交
3

J
Joerg Jaspert 已提交
4 5 6 7 8 9 10 11
"""
Queue utility functions for dak

@contact: Debian FTP Master <ftpmaster@debian.org>
@copyright: 2001 - 2006 James Troup <james@nocrew.org>
@copyright: 2009  Joerg Jaspert <joerg@debian.org>
@license: GNU General Public License version 2 or later
"""
J
New.  
James Troup 已提交
12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28

# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.

# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.

# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

###############################################################################

J
Joerg Jaspert 已提交
29 30 31 32 33 34 35 36
import errno
import os
import stat
import sys
import time
import apt_inst
import apt_pkg
import utils
M
Mark Hymers 已提交
37 38
import commands
import shutil
39
import textwrap
40
from types import *
F
Frank Lichtenheld 已提交
41
from sqlalchemy.sql.expression import desc
42

43 44
import yaml

J
Joerg Jaspert 已提交
45
from dak_exceptions import *
46
from changes import *
47
from regexes import *
48
from config import Config
49
from holding import Holding
50
from dbconn import *
51
from summarystats import SummaryStats
52
from utils import parse_changes, check_dsc_files
53
from textutils import fix_maintainer
M
Mark Hymers 已提交
54
from binary import Binary
J
New.  
James Troup 已提交
55 56

###############################################################################
57

M
Mark Hymers 已提交
58
def get_type(f, session):
59 60 61 62 63 64
    """
    Get the file type of C{f}

    @type f: dict
    @param f: file entry from Changes object

M
Mark Hymers 已提交
65 66 67
    @type session: SQLA Session
    @param session: SQL Alchemy session object

68 69 70 71 72 73
    @rtype: string
    @return: filetype

    """
    # Determine the type
    if f.has_key("dbtype"):
M
Mark Hymers 已提交
74
        file_type = f["dbtype"]
75
    elif re_source_ext.match(f["type"]):
76 77 78 79 80 81 82 83 84 85 86 87 88
        file_type = "dsc"
    else:
        utils.fubar("invalid type (%s) for new.  Dazed, confused and sure as heck not continuing." % (file_type))

    # Validate the override type
    type_id = get_override_type(file_type, session)
    if type_id is None:
        utils.fubar("invalid type (%s) for new.  Say wha?" % (file_type))

    return file_type

################################################################################

89 90
# Determine what parts in a .changes are NEW

91
def determine_new(changes, files, warn=1):
J
Joerg Jaspert 已提交
92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107
    """
    Determine what parts in a C{changes} file are NEW.

    @type changes: Upload.Pkg.changes dict
    @param changes: Changes dictionary

    @type files: Upload.Pkg.files dict
    @param files: Files dictionary

    @type warn: bool
    @param warn: Warn if overrides are added for (old)stable

    @rtype: dict
    @return: dictionary of NEW components.

    """
108 109
    new = {}

110 111
    session = DBConn().session()

112
    # Build up a list of potentially new things
113
    for name, f in files.items():
114 115 116 117 118 119
        # Skip byhand elements
        if f["type"] == "byhand":
            continue
        pkg = f["package"]
        priority = f["priority"]
        section = f["section"]
M
Mark Hymers 已提交
120
        file_type = get_type(f, session)
121 122
        component = f["component"]

J
Joerg Jaspert 已提交
123
        if file_type == "dsc":
124
            priority = "source"
125

126 127 128 129
        if not new.has_key(pkg):
            new[pkg] = {}
            new[pkg]["priority"] = priority
            new[pkg]["section"] = section
J
Joerg Jaspert 已提交
130
            new[pkg]["type"] = file_type
131 132 133 134
            new[pkg]["component"] = component
            new[pkg]["files"] = []
        else:
            old_type = new[pkg]["type"]
J
Joerg Jaspert 已提交
135
            if old_type != file_type:
136 137 138 139
                # source gets trumped by deb or udeb
                if old_type == "dsc":
                    new[pkg]["priority"] = priority
                    new[pkg]["section"] = section
J
Joerg Jaspert 已提交
140
                    new[pkg]["type"] = file_type
141
                    new[pkg]["component"] = component
142 143 144

        new[pkg]["files"].append(name)

145 146 147 148 149
        if f.has_key("othercomponents"):
            new[pkg]["othercomponents"] = f["othercomponents"]

    for suite in changes["suite"].keys():
        for pkg in new.keys():
150 151
            ql = get_override(pkg, suite, new[pkg]["component"], new[pkg]["type"], session)
            if len(ql) > 0:
J
Joerg Jaspert 已提交
152 153 154
                for file_entry in new[pkg]["files"]:
                    if files[file_entry].has_key("new"):
                        del files[file_entry]["new"]
155 156 157
                del new[pkg]

    if warn:
158 159 160
        for s in ['stable', 'oldstable']:
            if changes["suite"].has_key(s):
                print "WARNING: overrides will be added for %s!" % s
161 162 163 164
        for pkg in new.keys():
            if new[pkg].has_key("othercomponents"):
                print "WARNING: %s already present in %s distribution." % (pkg, new[pkg]["othercomponents"])

M
Mark Hymers 已提交
165 166
    session.close()

167 168 169 170 171
    return new

################################################################################

def check_valid(new):
J
Joerg Jaspert 已提交
172 173 174 175 176 177 178 179 180 181 182
    """
    Check if section and priority for NEW packages exist in database.
    Additionally does sanity checks:
      - debian-installer packages have to be udeb (or source)
      - non debian-installer packages can not be udeb
      - source priority can only be assigned to dsc file types

    @type new: dict
    @param new: Dict of new packages with their section, priority and type.

    """
183
    for pkg in new.keys():
184 185
        section_name = new[pkg]["section"]
        priority_name = new[pkg]["priority"]
J
Joerg Jaspert 已提交
186
        file_type = new[pkg]["type"]
187 188 189 190 191 192 193 194 195 196 197 198 199

        section = get_section(section_name)
        if section is None:
            new[pkg]["section id"] = -1
        else:
            new[pkg]["section id"] = section.section_id

        priority = get_priority(priority_name)
        if priority is None:
            new[pkg]["priority id"] = -1
        else:
            new[pkg]["priority id"] = priority.priority_id

200
        # Sanity checks
201 202 203 204 205
        di = section_name.find("debian-installer") != -1

        # If d-i, we must be udeb and vice-versa
        if     (di and file_type not in ("udeb", "dsc")) or \
           (not di and file_type == "udeb"):
206
            new[pkg]["section id"] = -1
207 208

        # If dsc we need to be source and vice-versa
J
Joerg Jaspert 已提交
209 210
        if (priority == "source" and file_type != "dsc") or \
           (priority != "source" and file_type == "dsc"):
211 212
            new[pkg]["priority id"] = -1

J
New.  
James Troup 已提交
213 214
###############################################################################

M
Mark Hymers 已提交
215 216 217 218 219 220 221 222
def check_status(files):
    new = byhand = 0
    for f in files.keys():
        if files[f]["type"] == "byhand":
            byhand = 1
        elif files[f].has_key("new"):
            new = 1
    return (new, byhand)
223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244

###############################################################################

# Used by Upload.check_timestamps
class TarTime(object):
    def __init__(self, future_cutoff, past_cutoff):
        self.reset()
        self.future_cutoff = future_cutoff
        self.past_cutoff = past_cutoff

    def reset(self):
        self.future_files = {}
        self.ancient_files = {}

    def callback(self, Kind, Name, Link, Mode, UID, GID, Size, MTime, Major, Minor):
        if MTime > self.future_cutoff:
            self.future_files[Name] = MTime
        if MTime < self.past_cutoff:
            self.ancient_files[Name] = MTime

###############################################################################

245
class Upload(object):
J
Joerg Jaspert 已提交
246 247
    """
    Everything that has to do with an upload processed.
J
New.  
James Troup 已提交
248

J
Joerg Jaspert 已提交
249
    """
250
    def __init__(self):
M
Mark Hymers 已提交
251
        self.logger = None
252 253
        self.pkg = Changes()
        self.reset()
J
New.  
James Troup 已提交
254 255 256

    ###########################################################################

257 258
    def reset (self):
        """ Reset a number of internal variables."""
259

260
        # Initialize the substitution template map
261 262 263 264 265 266
        cnf = Config()
        self.Subst = {}
        self.Subst["__ADMIN_ADDRESS__"] = cnf["Dinstall::MyAdminAddress"]
        self.Subst["__BUG_SERVER__"] = cnf["Dinstall::BugServer"]
        self.Subst["__DISTRO__"] = cnf["Dinstall::MyDistribution"]
        self.Subst["__DAK_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
267

268 269 270 271
        self.rejects = []
        self.warnings = []
        self.notes = []

272
        self.pkg.reset()
J
New.  
James Troup 已提交
273

274
    def package_info(self):
C
Chris Lamb 已提交
275 276 277
        """
        Format various messages from this Upload to send to the maintainer.
        """
278

C
Chris Lamb 已提交
279 280 281 282 283
        msgs = (
            ('Reject Reasons', self.rejects),
            ('Warnings', self.warnings),
            ('Notes', self.notes),
        )
284

C
Chris Lamb 已提交
285
        msg = ''
286
        for title, messages in msgs:
C
Chris Lamb 已提交
287 288
            if messages:
                msg += '\n\n%s:\n%s' % (title, '\n'.join(messages))
289 290 291

        return msg

J
New.  
James Troup 已提交
292
    ###########################################################################
293
    def update_subst(self):
J
Joerg Jaspert 已提交
294 295
        """ Set up the per-package template substitution mappings """

296 297
        cnf = Config()

298
        # If 'dak process-unchecked' crashed out in the right place, architecture may still be a string.
299
        if not self.pkg.changes.has_key("architecture") or not \
300
           isinstance(self.pkg.changes["architecture"], dict):
301 302
            self.pkg.changes["architecture"] = { "Unknown" : "" }

303
        # and maintainer2047 may not exist.
304 305
        if not self.pkg.changes.has_key("maintainer2047"):
            self.pkg.changes["maintainer2047"] = cnf["Dinstall::MyEmailAddress"]
J
New.  
James Troup 已提交
306

307 308 309
        self.Subst["__ARCHITECTURE__"] = " ".join(self.pkg.changes["architecture"].keys())
        self.Subst["__CHANGES_FILENAME__"] = os.path.basename(self.pkg.changes_file)
        self.Subst["__FILE_CONTENTS__"] = self.pkg.changes.get("filecontents", "")
J
New.  
James Troup 已提交
310 311

        # For source uploads the Changed-By field wins; otherwise Maintainer wins.
312 313 314 315 316
        if self.pkg.changes["architecture"].has_key("source") and \
           self.pkg.changes["changedby822"] != "" and \
           (self.pkg.changes["changedby822"] != self.pkg.changes["maintainer822"]):

            self.Subst["__MAINTAINER_FROM__"] = self.pkg.changes["changedby2047"]
M
Mark Hymers 已提交
317
            self.Subst["__MAINTAINER_TO__"] = "%s, %s" % (self.pkg.changes["changedby2047"], self.pkg.changes["maintainer2047"])
318
            self.Subst["__MAINTAINER__"] = self.pkg.changes.get("changed-by", "Unknown")
J
New.  
James Troup 已提交
319
        else:
320 321 322
            self.Subst["__MAINTAINER_FROM__"] = self.pkg.changes["maintainer2047"]
            self.Subst["__MAINTAINER_TO__"] = self.pkg.changes["maintainer2047"]
            self.Subst["__MAINTAINER__"] = self.pkg.changes.get("maintainer", "Unknown")
J
Joerg Jaspert 已提交
323

324 325
        if "sponsoremail" in self.pkg.changes:
            self.Subst["__MAINTAINER_TO__"] += ", %s" % self.pkg.changes["sponsoremail"]
J
Joerg Jaspert 已提交
326

327 328
        if cnf.has_key("Dinstall::TrackingServer") and self.pkg.changes.has_key("source"):
            self.Subst["__MAINTAINER_TO__"] += "\nBcc: %s@%s" % (self.pkg.changes["source"], cnf["Dinstall::TrackingServer"])
J
New.  
James Troup 已提交
329

330
        # Apply any global override of the Maintainer field
331 332 333
        if cnf.get("Dinstall::OverrideMaintainer"):
            self.Subst["__MAINTAINER_TO__"] = cnf["Dinstall::OverrideMaintainer"]
            self.Subst["__MAINTAINER_FROM__"] = cnf["Dinstall::OverrideMaintainer"]
334

335
        self.Subst["__REJECT_MESSAGE__"] = self.package_info()
336 337
        self.Subst["__SOURCE__"] = self.pkg.changes.get("source", "Unknown")
        self.Subst["__VERSION__"] = self.pkg.changes.get("version", "Unknown")
J
New.  
James Troup 已提交
338

339 340 341
    ###########################################################################
    def load_changes(self, filename):
        """
F
Frank Lichtenheld 已提交
342
        @rtype: boolean
343 344 345 346 347
        @rvalue: whether the changes file was valid or not.  We may want to
                 reject even if this is True (see what gets put in self.rejects).
                 This is simply to prevent us even trying things later which will
                 fail because we couldn't properly parse the file.
        """
M
Mark Hymers 已提交
348
        Cnf = Config()
349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365
        self.pkg.changes_file = filename

        # Parse the .changes field into a dictionary
        try:
            self.pkg.changes.update(parse_changes(filename))
        except CantOpenError:
            self.rejects.append("%s: can't read file." % (filename))
            return False
        except ParseChangesError, line:
            self.rejects.append("%s: parse error, can't grok: %s." % (filename, line))
            return False
        except ChangesUnicodeError:
            self.rejects.append("%s: changes file not proper utf-8" % (filename))
            return False

        # Parse the Files field from the .changes into another dictionary
        try:
M
Mark Hymers 已提交
366
            self.pkg.files.update(utils.build_file_list(self.pkg.changes))
367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409
        except ParseChangesError, line:
            self.rejects.append("%s: parse error, can't grok: %s." % (filename, line))
            return False
        except UnknownFormatError, format:
            self.rejects.append("%s: unknown format '%s'." % (filename, format))
            return False

        # Check for mandatory fields
        for i in ("distribution", "source", "binary", "architecture",
                  "version", "maintainer", "files", "changes", "description"):
            if not self.pkg.changes.has_key(i):
                # Avoid undefined errors later
                self.rejects.append("%s: Missing mandatory field `%s'." % (filename, i))
                return False

        # Strip a source version in brackets from the source field
        if re_strip_srcver.search(self.pkg.changes["source"]):
            self.pkg.changes["source"] = re_strip_srcver.sub('', self.pkg.changes["source"])

        # Ensure the source field is a valid package name.
        if not re_valid_pkg_name.match(self.pkg.changes["source"]):
            self.rejects.append("%s: invalid source name '%s'." % (filename, self.pkg.changes["source"]))

        # Split multi-value fields into a lower-level dictionary
        for i in ("architecture", "distribution", "binary", "closes"):
            o = self.pkg.changes.get(i, "")
            if o != "":
                del self.pkg.changes[i]

            self.pkg.changes[i] = {}

            for j in o.split():
                self.pkg.changes[i][j] = 1

        # Fix the Maintainer: field to be RFC822/2047 compatible
        try:
            (self.pkg.changes["maintainer822"],
             self.pkg.changes["maintainer2047"],
             self.pkg.changes["maintainername"],
             self.pkg.changes["maintaineremail"]) = \
                   fix_maintainer (self.pkg.changes["maintainer"])
        except ParseMaintError, msg:
            self.rejects.append("%s: Maintainer field ('%s') failed to parse: %s" \
410
                   % (filename, self.pkg.changes["maintainer"], msg))
411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440

        # ...likewise for the Changed-By: field if it exists.
        try:
            (self.pkg.changes["changedby822"],
             self.pkg.changes["changedby2047"],
             self.pkg.changes["changedbyname"],
             self.pkg.changes["changedbyemail"]) = \
                   fix_maintainer (self.pkg.changes.get("changed-by", ""))
        except ParseMaintError, msg:
            self.pkg.changes["changedby822"] = ""
            self.pkg.changes["changedby2047"] = ""
            self.pkg.changes["changedbyname"] = ""
            self.pkg.changes["changedbyemail"] = ""

            self.rejects.append("%s: Changed-By field ('%s') failed to parse: %s" \
                   % (filename, changes["changed-by"], msg))

        # Ensure all the values in Closes: are numbers
        if self.pkg.changes.has_key("closes"):
            for i in self.pkg.changes["closes"].keys():
                if re_isanum.match (i) == None:
                    self.rejects.append(("%s: `%s' from Closes field isn't a number." % (filename, i)))

        # chopversion = no epoch; chopversion2 = no epoch and no revision (e.g. for .orig.tar.gz comparison)
        self.pkg.changes["chopversion"] = re_no_epoch.sub('', self.pkg.changes["version"])
        self.pkg.changes["chopversion2"] = re_no_revision.sub('', self.pkg.changes["chopversion"])

        # Check there isn't already a changes file of the same name in one
        # of the queue directories.
        base_filename = os.path.basename(filename)
J
Joerg Jaspert 已提交
441 442
        if get_knownchange(base_filename):
            self.rejects.append("%s: a file with this name already exists." % (base_filename))
443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476

        # Check the .changes is non-empty
        if not self.pkg.files:
            self.rejects.append("%s: nothing to do (Files field is empty)." % (base_filename))
            return False

        # Changes was syntactically valid even if we'll reject
        return True

    ###########################################################################

    def check_distributions(self):
        "Check and map the Distribution field"

        Cnf = Config()

        # Handle suite mappings
        for m in Cnf.ValueList("SuiteMappings"):
            args = m.split()
            mtype = args[0]
            if mtype == "map" or mtype == "silent-map":
                (source, dest) = args[1:3]
                if self.pkg.changes["distribution"].has_key(source):
                    del self.pkg.changes["distribution"][source]
                    self.pkg.changes["distribution"][dest] = 1
                    if mtype != "silent-map":
                        self.notes.append("Mapping %s to %s." % (source, dest))
                if self.pkg.changes.has_key("distribution-version"):
                    if self.pkg.changes["distribution-version"].has_key(source):
                        self.pkg.changes["distribution-version"][source]=dest
            elif mtype == "map-unreleased":
                (source, dest) = args[1:3]
                if self.pkg.changes["distribution"].has_key(source):
                    for arch in self.pkg.changes["architecture"].keys():
M
Mark Hymers 已提交
477
                        if arch not in [ a.arch_string for a in get_suite_architectures(source) ]:
478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508
                            self.notes.append("Mapping %s to %s for unreleased architecture %s." % (source, dest, arch))
                            del self.pkg.changes["distribution"][source]
                            self.pkg.changes["distribution"][dest] = 1
                            break
            elif mtype == "ignore":
                suite = args[1]
                if self.pkg.changes["distribution"].has_key(suite):
                    del self.pkg.changes["distribution"][suite]
                    self.warnings.append("Ignoring %s as a target suite." % (suite))
            elif mtype == "reject":
                suite = args[1]
                if self.pkg.changes["distribution"].has_key(suite):
                    self.rejects.append("Uploads to %s are not accepted." % (suite))
            elif mtype == "propup-version":
                # give these as "uploaded-to(non-mapped) suites-to-add-when-upload-obsoletes"
                #
                # changes["distribution-version"] looks like: {'testing': 'testing-proposed-updates'}
                if self.pkg.changes["distribution"].has_key(args[1]):
                    self.pkg.changes.setdefault("distribution-version", {})
                    for suite in args[2:]:
                        self.pkg.changes["distribution-version"][suite] = suite

        # Ensure there is (still) a target distribution
        if len(self.pkg.changes["distribution"].keys()) < 1:
            self.rejects.append("No valid distribution remaining.")

        # Ensure target distributions exist
        for suite in self.pkg.changes["distribution"].keys():
            if not Cnf.has_key("Suite::%s" % (suite)):
                self.rejects.append("Unknown distribution `%s'." % (suite))

J
New.  
James Troup 已提交
509 510
    ###########################################################################

511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601
    def binary_file_checks(self, f, session):
        cnf = Config()
        entry = self.pkg.files[f]

        # Extract package control information
        deb_file = utils.open_file(f)
        try:
            control = apt_pkg.ParseSection(apt_inst.debExtractControl(deb_file))
        except:
            self.rejects.append("%s: debExtractControl() raised %s." % (f, sys.exc_type))
            deb_file.close()
            # Can't continue, none of the checks on control would work.
            return

        # Check for mandantory "Description:"
        deb_file.seek(0)
        try:
            apt_pkg.ParseSection(apt_inst.debExtractControl(deb_file))["Description"] + '\n'
        except:
            self.rejects.append("%s: Missing Description in binary package" % (f))
            return

        deb_file.close()

        # Check for mandatory fields
        for field in [ "Package", "Architecture", "Version" ]:
            if control.Find(field) == None:
                # Can't continue
                self.rejects.append("%s: No %s field in control." % (f, field))
                return

        # Ensure the package name matches the one give in the .changes
        if not self.pkg.changes["binary"].has_key(control.Find("Package", "")):
            self.rejects.append("%s: control file lists name as `%s', which isn't in changes file." % (f, control.Find("Package", "")))

        # Validate the package field
        package = control.Find("Package")
        if not re_valid_pkg_name.match(package):
            self.rejects.append("%s: invalid package name '%s'." % (f, package))

        # Validate the version field
        version = control.Find("Version")
        if not re_valid_version.match(version):
            self.rejects.append("%s: invalid version number '%s'." % (f, version))

        # Ensure the architecture of the .deb is one we know about.
        default_suite = cnf.get("Dinstall::DefaultSuite", "Unstable")
        architecture = control.Find("Architecture")
        upload_suite = self.pkg.changes["distribution"].keys()[0]

        if      architecture not in [a.arch_string for a in get_suite_architectures(default_suite, session)] \
            and architecture not in [a.arch_string for a in get_suite_architectures(upload_suite, session)]:
            self.rejects.append("Unknown architecture '%s'." % (architecture))

        # Ensure the architecture of the .deb is one of the ones
        # listed in the .changes.
        if not self.pkg.changes["architecture"].has_key(architecture):
            self.rejects.append("%s: control file lists arch as `%s', which isn't in changes file." % (f, architecture))

        # Sanity-check the Depends field
        depends = control.Find("Depends")
        if depends == '':
            self.rejects.append("%s: Depends field is empty." % (f))

        # Sanity-check the Provides field
        provides = control.Find("Provides")
        if provides:
            provide = re_spacestrip.sub('', provides)
            if provide == '':
                self.rejects.append("%s: Provides field is empty." % (f))
            prov_list = provide.split(",")
            for prov in prov_list:
                if not re_valid_pkg_name.match(prov):
                    self.rejects.append("%s: Invalid Provides field content %s." % (f, prov))

        # Check the section & priority match those given in the .changes (non-fatal)
        if     control.Find("Section") and entry["section"] != "" \
           and entry["section"] != control.Find("Section"):
            self.warnings.append("%s control file lists section as `%s', but changes file has `%s'." % \
                                (f, control.Find("Section", ""), entry["section"]))
        if control.Find("Priority") and entry["priority"] != "" \
           and entry["priority"] != control.Find("Priority"):
            self.warnings.append("%s control file lists priority as `%s', but changes file has `%s'." % \
                                (f, control.Find("Priority", ""), entry["priority"]))

        entry["package"] = package
        entry["architecture"] = architecture
        entry["version"] = version
        entry["maintainer"] = control.Find("Maintainer", "")

        if f.endswith(".udeb"):
M
Mark Hymers 已提交
602
            self.pkg.files[f]["dbtype"] = "udeb"
603
        elif f.endswith(".deb"):
M
Mark Hymers 已提交
604
            self.pkg.files[f]["dbtype"] = "deb"
605 606 607 608 609 610 611 612 613 614 615 616 617 618 619
        else:
            self.rejects.append("%s is neither a .deb or a .udeb." % (f))

        entry["source"] = control.Find("Source", entry["package"])

        # Get the source version
        source = entry["source"]
        source_version = ""

        if source.find("(") != -1:
            m = re_extract_src_version.match(source)
            source = m.group(1)
            source_version = m.group(2)

        if not source_version:
M
Mark Hymers 已提交
620
            source_version = self.pkg.files[f]["version"]
621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677

        entry["source package"] = source
        entry["source version"] = source_version

        # Ensure the filename matches the contents of the .deb
        m = re_isadeb.match(f)

        #  package name
        file_package = m.group(1)
        if entry["package"] != file_package:
            self.rejects.append("%s: package part of filename (%s) does not match package name in the %s (%s)." % \
                                (f, file_package, entry["dbtype"], entry["package"]))
        epochless_version = re_no_epoch.sub('', control.Find("Version"))

        #  version
        file_version = m.group(2)
        if epochless_version != file_version:
            self.rejects.append("%s: version part of filename (%s) does not match package version in the %s (%s)." % \
                                (f, file_version, entry["dbtype"], epochless_version))

        #  architecture
        file_architecture = m.group(3)
        if entry["architecture"] != file_architecture:
            self.rejects.append("%s: architecture part of filename (%s) does not match package architecture in the %s (%s)." % \
                                (f, file_architecture, entry["dbtype"], entry["architecture"]))

        # Check for existent source
        source_version = entry["source version"]
        source_package = entry["source package"]
        if self.pkg.changes["architecture"].has_key("source"):
            if source_version != self.pkg.changes["version"]:
                self.rejects.append("source version (%s) for %s doesn't match changes version %s." % \
                                    (source_version, f, self.pkg.changes["version"]))
        else:
            # Check in the SQL database
            if not source_exists(source_package, source_version, self.pkg.changes["distribution"].keys(), session):
                # Check in one of the other directories
                source_epochless_version = re_no_epoch.sub('', source_version)
                dsc_filename = "%s_%s.dsc" % (source_package, source_epochless_version)
                if os.path.exists(os.path.join(cnf["Dir::Queue::Byhand"], dsc_filename)):
                    entry["byhand"] = 1
                elif os.path.exists(os.path.join(cnf["Dir::Queue::New"], dsc_filename)):
                    entry["new"] = 1
                else:
                    dsc_file_exists = False
                    for myq in ["Accepted", "Embargoed", "Unembargoed", "ProposedUpdates", "OldProposedUpdates"]:
                        if cnf.has_key("Dir::Queue::%s" % (myq)):
                            if os.path.exists(os.path.join(cnf["Dir::Queue::" + myq], dsc_filename)):
                                dsc_file_exists = True
                                break

                    if not dsc_file_exists:
                        self.rejects.append("no source found for %s %s (%s)." % (source_package, source_version, f))

        # Check the version and for file overwrites
        self.check_binary_against_db(f, session)

M
Mark Hymers 已提交
678 679 680 681 682 683
        # Temporarily disable contents generation until we change the table storage layout
        #b = Binary(f)
        #b.scan_package()
        #if len(b.rejects) > 0:
        #    for j in b.rejects:
        #        self.rejects.append(j)
684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700

    def source_file_checks(self, f, session):
        entry = self.pkg.files[f]

        m = re_issource.match(f)
        if not m:
            return

        entry["package"] = m.group(1)
        entry["version"] = m.group(2)
        entry["type"] = m.group(3)

        # Ensure the source package name matches the Source filed in the .changes
        if self.pkg.changes["source"] != entry["package"]:
            self.rejects.append("%s: changes file doesn't say %s for Source" % (f, entry["package"]))

        # Ensure the source version matches the version in the .changes file
701
        if re_is_orig_source.match(f):
702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725
            changes_version = self.pkg.changes["chopversion2"]
        else:
            changes_version = self.pkg.changes["chopversion"]

        if changes_version != entry["version"]:
            self.rejects.append("%s: should be %s according to changes file." % (f, changes_version))

        # Ensure the .changes lists source in the Architecture field
        if not self.pkg.changes["architecture"].has_key("source"):
            self.rejects.append("%s: changes file doesn't list `source' in Architecture field." % (f))

        # Check the signature of a .dsc file
        if entry["type"] == "dsc":
            # check_signature returns either:
            #  (None, [list, of, rejects]) or (signature, [])
            (self.pkg.dsc["fingerprint"], rejects) = utils.check_signature(f)
            for j in rejects:
                self.rejects.append(j)

        entry["architecture"] = "source"

    def per_suite_file_checks(self, f, suite, session):
        cnf = Config()
        entry = self.pkg.files[f]
M
Mark Hymers 已提交
726
        archive = utils.where_am_i()
727 728 729 730 731

        # Skip byhand
        if entry.has_key("byhand"):
            return

M
Mark Hymers 已提交
732 733 734 735 736 737 738 739 740 741
        # Check we have fields we need to do these checks
        oktogo = True
        for m in ['component', 'package', 'priority', 'size', 'md5sum']:
            if not entry.has_key(m):
                self.rejects.append("file '%s' does not have field %s set" % (f, m))
                oktogo = False

        if not oktogo:
            return

742 743 744 745 746 747 748 749 750 751 752 753 754 755
        # Handle component mappings
        for m in cnf.ValueList("ComponentMappings"):
            (source, dest) = m.split()
            if entry["component"] == source:
                entry["original component"] = source
                entry["component"] = dest

        # Ensure the component is valid for the target suite
        if cnf.has_key("Suite:%s::Components" % (suite)) and \
           entry["component"] not in cnf.ValueList("Suite::%s::Components" % (suite)):
            self.rejects.append("unknown component `%s' for suite `%s'." % (entry["component"], suite))
            return

        # Validate the component
M
Mark Hymers 已提交
756
        if not get_component(entry["component"], session):
757
            self.rejects.append("file '%s' has unknown component '%s'." % (f, entry["component"]))
758 759 760 761 762 763 764 765 766 767 768 769
            return

        # See if the package is NEW
        if not self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), f, session):
            entry["new"] = 1

        # Validate the priority
        if entry["priority"].find('/') != -1:
            self.rejects.append("file '%s' has invalid priority '%s' [contains '/']." % (f, entry["priority"]))

        # Determine the location
        location = cnf["Dir::Pool"]
M
Mark Hymers 已提交
770
        l = get_location(location, entry["component"], archive, session)
771
        if l is None:
772
            self.rejects.append("[INTERNAL ERROR] couldn't determine location (Component: %s, Archive: %s)" % (entry["component"], archive))
773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794
            entry["location id"] = -1
        else:
            entry["location id"] = l.location_id

        # Check the md5sum & size against existing files (if any)
        entry["pool name"] = utils.poolify(self.pkg.changes["source"], entry["component"])

        found, poolfile = check_poolfile(os.path.join(entry["pool name"], f),
                                         entry["size"], entry["md5sum"], entry["location id"])

        if found is None:
            self.rejects.append("INTERNAL ERROR, get_files_id() returned multiple matches for %s." % (f))
        elif found is False and poolfile is not None:
            self.rejects.append("md5sum and/or size mismatch on existing copy of %s." % (f))
        else:
            if poolfile is None:
                entry["files id"] = None
            else:
                entry["files id"] = poolfile.file_id

        # Check for packages that have moved from one component to another
        entry['suite'] = suite
M
Mark Hymers 已提交
795
        res = get_binary_components(self.pkg.files[f]['package'], suite, entry["architecture"], session)
796 797 798 799 800 801 802 803
        if res.rowcount > 0:
            entry["othercomponents"] = res.fetchone()[0]

    def check_files(self, action=True):
        file_keys = self.pkg.files.keys()
        holding = Holding()
        cnf = Config()

F
Frank Lichtenheld 已提交
804
        if action:
805 806 807 808 809 810 811 812 813 814
            cwd = os.getcwd()
            os.chdir(self.pkg.directory)
            for f in file_keys:
                ret = holding.copy_to_holding(f)
                if ret is not None:
                    # XXX: Should we bail out here or try and continue?
                    self.rejects.append(ret)

            os.chdir(cwd)

F
Frank Lichtenheld 已提交
815 816
        # Check there isn't already a .changes file of the same name in
        # the proposed-updates "CopyChanges" storage directories.
817 818 819 820 821 822 823 824 825 826 827 828 829
        # [NB: this check must be done post-suite mapping]
        base_filename = os.path.basename(self.pkg.changes_file)

        for suite in self.pkg.changes["distribution"].keys():
            copychanges = "Suite::%s::CopyChanges" % (suite)
            if cnf.has_key(copychanges) and \
                   os.path.exists(os.path.join(cnf[copychanges], base_filename)):
                self.rejects.append("%s: a file with this name already exists in %s" \
                           % (base_filename, cnf[copychanges]))

        has_binaries = False
        has_source = False

M
Mark Hymers 已提交
830
        session = DBConn().session()
831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867

        for f, entry in self.pkg.files.items():
            # Ensure the file does not already exist in one of the accepted directories
            for d in [ "Accepted", "Byhand", "New", "ProposedUpdates", "OldProposedUpdates", "Embargoed", "Unembargoed" ]:
                if not cnf.has_key("Dir::Queue::%s" % (d)): continue
                if os.path.exists(cnf["Dir::Queue::%s" % (d) ] + '/' + f):
                    self.rejects.append("%s file already exists in the %s directory." % (f, d))

            if not re_taint_free.match(f):
                self.rejects.append("!!WARNING!! tainted filename: '%s'." % (f))

            # Check the file is readable
            if os.access(f, os.R_OK) == 0:
                # When running in -n, copy_to_holding() won't have
                # generated the reject_message, so we need to.
                if action:
                    if os.path.exists(f):
                        self.rejects.append("Can't read `%s'. [permission denied]" % (f))
                    else:
                        self.rejects.append("Can't read `%s'. [file not found]" % (f))
                entry["type"] = "unreadable"
                continue

            # If it's byhand skip remaining checks
            if entry["section"] == "byhand" or entry["section"][:4] == "raw-":
                entry["byhand"] = 1
                entry["type"] = "byhand"

            # Checks for a binary package...
            elif re_isadeb.match(f):
                has_binaries = True
                entry["type"] = "deb"

                # This routine appends to self.rejects/warnings as appropriate
                self.binary_file_checks(f, session)

            # Checks for a source package...
M
Mark Hymers 已提交
868
            elif re_issource.match(f):
869 870 871 872 873 874 875 876 877 878 879 880 881 882 883
                has_source = True

                # This routine appends to self.rejects/warnings as appropriate
                self.source_file_checks(f, session)

            # Not a binary or source package?  Assume byhand...
            else:
                entry["byhand"] = 1
                entry["type"] = "byhand"

            # Per-suite file checks
            entry["oldfiles"] = {}
            for suite in self.pkg.changes["distribution"].keys():
                self.per_suite_file_checks(f, suite, session)

M
Mark Hymers 已提交
884 885
        session.close()

886 887 888 889 890 891 892 893 894
        # If the .changes file says it has source, it must have source.
        if self.pkg.changes["architecture"].has_key("source"):
            if not has_source:
                self.rejects.append("no source found and Architecture line in changes mention source.")

            if not has_binaries and cnf.FindB("Dinstall::Reject::NoSourceOnly"):
                self.rejects.append("source only uploads are not supported.")

    ###########################################################################
895
    def check_dsc(self, action=True, session=None):
896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931
        """Returns bool indicating whether or not the source changes are valid"""
        # Ensure there is source to check
        if not self.pkg.changes["architecture"].has_key("source"):
            return True

        # Find the .dsc
        dsc_filename = None
        for f, entry in self.pkg.files.items():
            if entry["type"] == "dsc":
                if dsc_filename:
                    self.rejects.append("can not process a .changes file with multiple .dsc's.")
                    return False
                else:
                    dsc_filename = f

        # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
        if not dsc_filename:
            self.rejects.append("source uploads must contain a dsc file")
            return False

        # Parse the .dsc file
        try:
            self.pkg.dsc.update(utils.parse_changes(dsc_filename, signing_rules=1))
        except CantOpenError:
            # if not -n copy_to_holding() will have done this for us...
            if not action:
                self.rejects.append("%s: can't read file." % (dsc_filename))
        except ParseChangesError, line:
            self.rejects.append("%s: parse error, can't grok: %s." % (dsc_filename, line))
        except InvalidDscError, line:
            self.rejects.append("%s: syntax error on line %s." % (dsc_filename, line))
        except ChangesUnicodeError:
            self.rejects.append("%s: dsc file not proper utf-8." % (dsc_filename))

        # Build up the file list of files mentioned by the .dsc
        try:
M
Mark Hymers 已提交
932
            self.pkg.dsc_files.update(utils.build_file_list(self.pkg.dsc, is_a_dsc=1))
933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951
        except NoFilesFieldError:
            self.rejects.append("%s: no Files: field." % (dsc_filename))
            return False
        except UnknownFormatError, format:
            self.rejects.append("%s: unknown format '%s'." % (dsc_filename, format))
            return False
        except ParseChangesError, line:
            self.rejects.append("%s: parse error, can't grok: %s." % (dsc_filename, line))
            return False

        # Enforce mandatory fields
        for i in ("format", "source", "version", "binary", "maintainer", "architecture", "files"):
            if not self.pkg.dsc.has_key(i):
                self.rejects.append("%s: missing mandatory field `%s'." % (dsc_filename, i))
                return False

        # Validate the source and version fields
        if not re_valid_pkg_name.match(self.pkg.dsc["source"]):
            self.rejects.append("%s: invalid source name '%s'." % (dsc_filename, self.pkg.dsc["source"]))
M
Mark Hymers 已提交
952
        if not re_valid_version.match(self.pkg.dsc["version"]):
953 954
            self.rejects.append("%s: invalid version number '%s'." % (dsc_filename, self.pkg.dsc["version"]))

955 956 957 958 959
        # Only a limited list of source formats are allowed in each suite
        for dist in self.pkg.changes["distribution"].keys():
            allowed = [ x.format_name for x in get_suite_src_formats(dist, session) ]
            if self.pkg.dsc["format"] not in allowed:
                self.rejects.append("%s: source format '%s' not allowed in %s (accepted: %s) " % (dsc_filename, self.pkg.dsc["format"], dist, ", ".join(allowed)))
960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985

        # Validate the Maintainer field
        try:
            # We ignore the return value
            fix_maintainer(self.pkg.dsc["maintainer"])
        except ParseMaintError, msg:
            self.rejects.append("%s: Maintainer field ('%s') failed to parse: %s" \
                                 % (dsc_filename, self.pkg.dsc["maintainer"], msg))

        # Validate the build-depends field(s)
        for field_name in [ "build-depends", "build-depends-indep" ]:
            field = self.pkg.dsc.get(field_name)
            if field:
                # Have apt try to parse them...
                try:
                    apt_pkg.ParseSrcDepends(field)
                except:
                    self.rejects.append("%s: invalid %s field (can not be parsed by apt)." % (dsc_filename, field_name.title()))

        # Ensure the version number in the .dsc matches the version number in the .changes
        epochless_dsc_version = re_no_epoch.sub('', self.pkg.dsc["version"])
        changes_version = self.pkg.files[dsc_filename]["version"]

        if epochless_dsc_version != self.pkg.files[dsc_filename]["version"]:
            self.rejects.append("version ('%s') in .dsc does not match version ('%s') in .changes." % (epochless_dsc_version, changes_version))

986 987
        # Ensure the Files field contain only what's expected
        self.rejects.extend(check_dsc_files(dsc_filename, self.pkg.dsc, self.pkg.dsc_files))
988 989

        # Ensure source is newer than existing source in target suites
M
Mark Hymers 已提交
990 991 992 993
        session = DBConn().session()
        self.check_source_against_db(dsc_filename, session)
        self.check_dsc_against_db(dsc_filename, session)
        session.close()
994 995 996 997 998

        return True

    ###########################################################################

C
Chris Lamb 已提交
999 1000 1001
    def get_changelog_versions(self, source_dir):
        """Extracts a the source package and (optionally) grabs the
        version history out of debian/changelog for the BTS."""
1002

C
Chris Lamb 已提交
1003
        cnf = Config()
1004

C
Chris Lamb 已提交
1005 1006 1007 1008 1009 1010 1011 1012 1013
        # Find the .dsc (again)
        dsc_filename = None
        for f in self.pkg.files.keys():
            if self.pkg.files[f]["type"] == "dsc":
                dsc_filename = f

        # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
        if not dsc_filename:
            return
1014 1015

        # Create a symlink mirror of the source files in our temporary directory
M
Mark Hymers 已提交
1016
        for f in self.pkg.files.keys():
1017 1018 1019 1020 1021 1022 1023
            m = re_issource.match(f)
            if m:
                src = os.path.join(source_dir, f)
                # If a file is missing for whatever reason, give up.
                if not os.path.exists(src):
                    return
                ftype = m.group(3)
C
Chris Lamb 已提交
1024 1025
                if re_is_orig_source.match(f) and self.pkg.orig_files.has_key(f) and \
                   self.pkg.orig_files[f].has_key("path"):
1026
                    continue
C
Chris Lamb 已提交
1027
                dest = os.path.join(os.getcwd(), f)
1028 1029
                os.symlink(src, dest)

1030 1031 1032 1033 1034 1035 1036
        # If the orig files are not a part of the upload, create symlinks to the
        # existing copies.
        for orig_file in self.pkg.orig_files.keys():
            if not self.pkg.orig_files[orig_file].has_key("path"):
                continue
            dest = os.path.join(os.getcwd(), os.path.basename(orig_file))
            os.symlink(self.pkg.orig_files[orig_file]["path"], dest)
1037 1038 1039 1040 1041 1042

        # Extract the source
        cmd = "dpkg-source -sn -x %s" % (dsc_filename)
        (result, output) = commands.getstatusoutput(cmd)
        if (result != 0):
            self.rejects.append("'dpkg-source -x' failed for %s [return code: %s]." % (dsc_filename, result))
1043
            self.rejects.append(utils.prefix_multi_line_string(output, " [dpkg-source output:] "))
1044 1045 1046 1047 1048 1049
            return

        if not cnf.Find("Dir::Queue::BTSVersionTrack"):
            return

        # Get the upstream version
M
Mark Hymers 已提交
1050
        upstr_version = re_no_epoch.sub('', self.pkg.dsc["version"])
1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075
        if re_strip_revision.search(upstr_version):
            upstr_version = re_strip_revision.sub('', upstr_version)

        # Ensure the changelog file exists
        changelog_filename = "%s-%s/debian/changelog" % (self.pkg.dsc["source"], upstr_version)
        if not os.path.exists(changelog_filename):
            self.rejects.append("%s: debian/changelog not found in extracted source." % (dsc_filename))
            return

        # Parse the changelog
        self.pkg.dsc["bts changelog"] = ""
        changelog_file = utils.open_file(changelog_filename)
        for line in changelog_file.readlines():
            m = re_changelog_versions.match(line)
            if m:
                self.pkg.dsc["bts changelog"] += line
        changelog_file.close()

        # Check we found at least one revision in the changelog
        if not self.pkg.dsc["bts changelog"]:
            self.rejects.append("%s: changelog format not recognised (empty version tree)." % (dsc_filename))

    def check_source(self):
        # Bail out if:
        #    a) there's no source
1076
        # or c) the orig files are MIA
F
Frank Lichtenheld 已提交
1077
        if not self.pkg.changes["architecture"].has_key("source") \
1078
           or len(self.pkg.orig_files) == 0:
1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096
            return

        tmpdir = utils.temp_dirname()

        # Move into the temporary directory
        cwd = os.getcwd()
        os.chdir(tmpdir)

        # Get the changelog version history
        self.get_changelog_versions(cwd)

        # Move back and cleanup the temporary tree
        os.chdir(cwd)

        try:
            shutil.rmtree(tmpdir)
        except OSError, e:
            if e.errno != errno.EACCES:
M
Mark Hymers 已提交
1097
                print "foobar"
1098 1099 1100 1101 1102 1103 1104 1105 1106 1107
                utils.fubar("%s: couldn't remove tmp dir for source tree." % (self.pkg.dsc["source"]))

            self.rejects.append("%s: source tree could not be cleanly removed." % (self.pkg.dsc["source"]))
            # We probably have u-r or u-w directories so chmod everything
            # and try again.
            cmd = "chmod -R u+rwx %s" % (tmpdir)
            result = os.system(cmd)
            if result != 0:
                utils.fubar("'%s' failed with result %s." % (cmd, result))
            shutil.rmtree(tmpdir)
M
Mark Hymers 已提交
1108 1109
        except Exception, e:
            print "foobar2 (%s)" % e
1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122
            utils.fubar("%s: couldn't remove tmp dir for source tree." % (self.pkg.dsc["source"]))

    ###########################################################################
    def ensure_hashes(self):
        # Make sure we recognise the format of the Files: field in the .changes
        format = self.pkg.changes.get("format", "0.0").split(".", 1)
        if len(format) == 2:
            format = int(format[0]), int(format[1])
        else:
            format = int(float(format[0])), 0

        # We need to deal with the original changes blob, as the fields we need
        # might not be in the changes dict serialised into the .dak anymore.
M
Mark Hymers 已提交
1123
        orig_changes = utils.parse_deb822(self.pkg.changes['filecontents'])
1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145

        # Copy the checksums over to the current changes dict.  This will keep
        # the existing modifications to it intact.
        for field in orig_changes:
            if field.startswith('checksums-'):
                self.pkg.changes[field] = orig_changes[field]

        # Check for unsupported hashes
        for j in utils.check_hash_fields(".changes", self.pkg.changes):
            self.rejects.append(j)

        for j in utils.check_hash_fields(".dsc", self.pkg.dsc):
            self.rejects.append(j)

        # We have to calculate the hash if we have an earlier changes version than
        # the hash appears in rather than require it exist in the changes file
        for hashname, hashfunc, version in utils.known_hashes:
            # TODO: Move _ensure_changes_hash into this class
            for j in utils._ensure_changes_hash(self.pkg.changes, format, version, self.pkg.files, hashname, hashfunc):
                self.rejects.append(j)
            if "source" in self.pkg.changes["architecture"]:
                # TODO: Move _ensure_dsc_hash into this class
M
Mark Hymers 已提交
1146
                for j in utils._ensure_dsc_hash(self.pkg.dsc, self.pkg.dsc_files, hashname, hashfunc):
1147 1148
                    self.rejects.append(j)

M
Mark Hymers 已提交
1149
    def check_hashes(self):
1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161
        for m in utils.check_hash(".changes", self.pkg.files, "md5", apt_pkg.md5sum):
            self.rejects.append(m)

        for m in utils.check_size(".changes", self.pkg.files):
            self.rejects.append(m)

        for m in utils.check_hash(".dsc", self.pkg.dsc_files, "md5", apt_pkg.md5sum):
            self.rejects.append(m)

        for m in utils.check_size(".dsc", self.pkg.dsc_files):
            self.rejects.append(m)

M
Mark Hymers 已提交
1162
        self.ensure_hashes()
1163

J
Joerg Jaspert 已提交
1164
    ###########################################################################
1165

1166 1167 1168 1169
    def ensure_orig(self, target_dir='.', session=None):
        """
        Ensures that all orig files mentioned in the changes file are present
        in target_dir. If they do not exist, they are symlinked into place.
1170

1171 1172 1173
        An list containing the symlinks that were created are returned (so they
        can be removed).
        """
1174

C
Chris Lamb 已提交
1175
        symlinked = []
1176 1177
        cnf = Config()

1178
        for filename, entry in self.pkg.dsc_files.iteritems():
1179
            if not re_is_orig_source.match(filename):
1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197
                # File is not an orig; ignore
                continue

            if os.path.exists(filename):
                # File exists, no need to continue
                continue

            def symlink_if_valid(path):
                f = utils.open_file(path)
                md5sum = apt_pkg.md5sum(f)
                f.close()

                fingerprint = (os.stat(path)[stat.ST_SIZE], md5sum)
                expected = (int(entry['size']), entry['md5sum'])

                if fingerprint != expected:
                    return False

C
Chris Lamb 已提交
1198 1199 1200 1201 1202
                dest = os.path.join(target_dir, filename)

                os.symlink(path, dest)
                symlinked.append(dest)

1203 1204
                return True

1205 1206 1207 1208
            session_ = session
            if session is None:
                session_ = DBConn().session()

1209 1210 1211
            found = False

            # Look in the pool
1212
            for poolfile in get_poolfile_like_name('/%s' % filename, session_):
1213 1214 1215 1216 1217 1218 1219 1220
                poolfile_path = os.path.join(
                    poolfile.location.path, poolfile.filename
                )

                if symlink_if_valid(poolfile_path):
                    found = True
                    break

1221 1222
            if session is None:
                session_.close()
1223

1224 1225 1226 1227 1228 1229 1230 1231
            if found:
                continue

            # Look in some other queues for the file
            queues = ('Accepted', 'New', 'Byhand', 'ProposedUpdates',
                'OldProposedUpdates', 'Embargoed', 'Unembargoed')

            for queue in queues:
1232
                if not cnf.get('Dir::Queue::%s' % queue):
1233 1234 1235
                    continue

                queuefile_path = os.path.join(
1236
                    cnf['Dir::Queue::%s' % queue], filename
1237 1238 1239 1240 1241 1242 1243 1244
                )

                if not os.path.exists(queuefile_path):
                    # Does not exist in this queue
                    continue

                if symlink_if_valid(queuefile_path):
                    break
1245

1246 1247 1248 1249 1250 1251 1252
        return symlinked

    ###########################################################################

    def check_lintian(self):
        cnf = Config()

1253 1254 1255 1256
        # Don't reject binary uploads
        if not self.pkg.changes['architecture'].has_key('source'):
            return

1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284
        # Only check some distributions
        valid_dist = False
        for dist in ('unstable', 'experimental'):
            if dist in self.pkg.changes['distribution']:
                valid_dist = True
                break

        if not valid_dist:
            return

        tagfile = cnf.get("Dinstall::LintianTags")
        if tagfile is None:
            # We don't have a tagfile, so just don't do anything.
            return

        # Parse the yaml file
        sourcefile = file(tagfile, 'r')
        sourcecontent = sourcefile.read()
        sourcefile.close()
        try:
            lintiantags = yaml.load(sourcecontent)['lintian']
        except yaml.YAMLError, msg:
            utils.fubar("Can not read the lintian tags file %s, YAML error: %s." % (tagfile, msg))
            return

        # Try and find all orig mentioned in the .dsc
        symlinked = self.ensure_orig()

J
Joerg Jaspert 已提交
1285 1286 1287 1288 1289
        # Now setup the input file for lintian. lintian wants "one tag per line" only,
        # so put it together like it. We put all types of tags in one file and then sort
        # through lintians output later to see if its a fatal tag we detected, or not.
        # So we only run lintian once on all tags, even if we might reject on some, but not
        # reject on others.
1290 1291
        # Additionally build up a set of tags
        tags = set()
J
Joerg Jaspert 已提交
1292 1293 1294 1295
        (fd, temp_filename) = utils.temp_filename()
        temptagfile = os.fdopen(fd, 'w')
        for tagtype in lintiantags:
            for tag in lintiantags[tagtype]:
1296
                temptagfile.write("%s\n" % tag)
1297
                tags.add(tag)
J
Joerg Jaspert 已提交
1298 1299 1300 1301 1302
        temptagfile.close()

        # So now we should look at running lintian at the .changes file, capturing output
        # to then parse it.
        command = "lintian --show-overrides --tags-from-file %s %s" % (temp_filename, self.pkg.changes_file)
M
Mark Hymers 已提交
1303
        (result, output) = commands.getstatusoutput(command)
C
Chris Lamb 已提交
1304 1305

        # We are done with lintian, remove our tempfile and any symlinks we created
J
Joerg Jaspert 已提交
1306
        os.unlink(temp_filename)
C
Chris Lamb 已提交
1307 1308 1309
        for symlink in symlinked:
            os.unlink(symlink)

1310 1311 1312
        if (result == 2):
            utils.warn("lintian failed for %s [return code: %s]." % (self.pkg.changes_file, result))
            utils.warn(utils.prefix_multi_line_string(output, " [possible output:] "))
J
Joerg Jaspert 已提交
1313

1314 1315
        if len(output) == 0:
            return
1316

C
Chris Lamb 已提交
1317 1318
        def log(*txt):
            if self.logger:
C
Chris Lamb 已提交
1319
                self.logger.log([self.pkg.changes_file, "check_lintian"] + list(txt))
C
Chris Lamb 已提交
1320

1321 1322 1323 1324 1325 1326 1327
        # We have output of lintian, this package isn't clean. Lets parse it and see if we
        # are having a victim for a reject.
        # W: tzdata: binary-without-manpage usr/sbin/tzconfig
        for line in output.split('\n'):
            m = re_parse_lintian.match(line)
            if m is None:
                continue
1328

1329 1330 1331 1332
            etype = m.group(1)
            epackage = m.group(2)
            etag = m.group(3)
            etext = m.group(4)
C
Chris Lamb 已提交
1333

1334 1335 1336 1337 1338 1339
            # So lets check if we know the tag at all.
            if etag not in tags:
                continue

            if etype == 'O':
                # We know it and it is overriden. Check that override is allowed.
1340
                if etag in lintiantags['warning']:
1341 1342
                    # The tag is overriden, and it is allowed to be overriden.
                    # Don't add a reject message.
M
PASS  
Mark Hymers 已提交
1343
                    pass
1344
                elif etag in lintiantags['error']:
1345 1346
                    # The tag is overriden - but is not allowed to be
                    self.rejects.append("%s: Overriden tag %s found, but this tag may not be overwritten." % (epackage, etag))
C
Chris Lamb 已提交
1347
                    log("ftpmaster does not allow tag to be overridable", etag)
1348 1349 1350 1351
            else:
                # Tag is known, it is not overriden, direct reject.
                self.rejects.append("%s: Found lintian output: '%s %s', automatically rejected package." % (epackage, etag, etext))
                # Now tell if they *might* override it.
C
Chris Lamb 已提交
1352
                if etag in lintiantags['warning']:
1353
                    log("auto rejecting", "overridable", etag)
1354
                    self.rejects.append("%s: If you have a good reason, you may override this lintian tag." % (epackage))
1355 1356
                else:
                    log("auto rejecting", "not overridable", etag)
J
Joerg Jaspert 已提交
1357

1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376
    ###########################################################################
    def check_urgency(self):
        cnf = Config()
        if self.pkg.changes["architecture"].has_key("source"):
            if not self.pkg.changes.has_key("urgency"):
                self.pkg.changes["urgency"] = cnf["Urgency::Default"]
            self.pkg.changes["urgency"] = self.pkg.changes["urgency"].lower()
            if self.pkg.changes["urgency"] not in cnf.ValueList("Urgency::Valid"):
                self.warnings.append("%s is not a valid urgency; it will be treated as %s by testing." % \
                                     (self.pkg.changes["urgency"], cnf["Urgency::Default"]))
                self.pkg.changes["urgency"] = cnf["Urgency::Default"]

    ###########################################################################

    # Sanity check the time stamps of files inside debs.
    # [Files in the near future cause ugly warnings and extreme time
    #  travel can cause errors on extraction]

    def check_timestamps(self):
M
Mark Hymers 已提交
1377 1378
        Cnf = Config()

1379 1380 1381 1382
        future_cutoff = time.time() + int(Cnf["Dinstall::FutureTimeTravelGrace"])
        past_cutoff = time.mktime(time.strptime(Cnf["Dinstall::PastCutoffYear"],"%Y"))
        tar = TarTime(future_cutoff, past_cutoff)

M
Mark Hymers 已提交
1383
        for filename, entry in self.pkg.files.items():
1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418
            if entry["type"] == "deb":
                tar.reset()
                try:
                    deb_file = utils.open_file(filename)
                    apt_inst.debExtract(deb_file, tar.callback, "control.tar.gz")
                    deb_file.seek(0)
                    try:
                        apt_inst.debExtract(deb_file, tar.callback, "data.tar.gz")
                    except SystemError, e:
                        # If we can't find a data.tar.gz, look for data.tar.bz2 instead.
                        if not re.search(r"Cannot f[ui]nd chunk data.tar.gz$", str(e)):
                            raise
                        deb_file.seek(0)
                        apt_inst.debExtract(deb_file,tar.callback,"data.tar.bz2")

                    deb_file.close()

                    future_files = tar.future_files.keys()
                    if future_files:
                        num_future_files = len(future_files)
                        future_file = future_files[0]
                        future_date = tar.future_files[future_file]
                        self.rejects.append("%s: has %s file(s) with a time stamp too far into the future (e.g. %s [%s])."
                               % (filename, num_future_files, future_file, time.ctime(future_date)))

                    ancient_files = tar.ancient_files.keys()
                    if ancient_files:
                        num_ancient_files = len(ancient_files)
                        ancient_file = ancient_files[0]
                        ancient_date = tar.ancient_files[ancient_file]
                        self.rejects.append("%s: has %s file(s) with a time stamp too ancient (e.g. %s [%s])."
                               % (filename, num_ancient_files, ancient_file, time.ctime(ancient_date)))
                except:
                    self.rejects.append("%s: deb contents timestamp check failed [%s: %s]" % (filename, sys.exc_type, sys.exc_value))

M
Mark Hymers 已提交
1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436
    def check_if_upload_is_sponsored(self, uid_email, uid_name):
        if uid_email in [self.pkg.changes["maintaineremail"], self.pkg.changes["changedbyemail"]]:
            sponsored = False
        elif uid_name in [self.pkg.changes["maintainername"], self.pkg.changes["changedbyname"]]:
            sponsored = False
            if uid_name == "":
                sponsored = True
        else:
            sponsored = True
            if ("source" in self.pkg.changes["architecture"] and uid_email and utils.is_email_alias(uid_email)):
                sponsor_addresses = utils.gpg_get_key_addresses(self.pkg.changes["fingerprint"])
                if (self.pkg.changes["maintaineremail"] not in sponsor_addresses and
                    self.pkg.changes["changedbyemail"] not in sponsor_addresses):
                        self.pkg.changes["sponsoremail"] = uid_email

        return sponsored


1437
    ###########################################################################
M
Mark Hymers 已提交
1438
    # check_signed_by_key checks
1439
    ###########################################################################
M
Mark Hymers 已提交
1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477

    def check_signed_by_key(self):
        """Ensure the .changes is signed by an authorized uploader."""
        session = DBConn().session()

        # First of all we check that the person has proper upload permissions
        # and that this upload isn't blocked
        fpr = get_fingerprint(self.pkg.changes['fingerprint'], session=session)

        if fpr is None:
            self.rejects.append("Cannot find fingerprint %s" % self.pkg.changes["fingerprint"])
            return

        # TODO: Check that import-keyring adds UIDs properly
        if not fpr.uid:
            self.rejects.append("Cannot find uid for fingerprint %s.  Please contact ftpmaster@debian.org" % fpr.fingerprint)
            return

        # Check that the fingerprint which uploaded has permission to do so
        self.check_upload_permissions(fpr, session)

        # Check that this package is not in a transition
        self.check_transition(session)

        session.close()


    def check_upload_permissions(self, fpr, session):
        # Check any one-off upload blocks
        self.check_upload_blocks(fpr, session)

        # Start with DM as a special case
        # DM is a special case unfortunately, so we check it first
        # (keys with no source access get more access than DMs in one
        #  way; DMs can only upload for their packages whether source
        #  or binary, whereas keys with no access might be able to
        #  upload some binaries)
        if fpr.source_acl.access_level == 'dm':
F
Frank Lichtenheld 已提交
1478
            self.check_dm_upload(fpr, session)
M
Mark Hymers 已提交
1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547
        else:
            # Check source-based permissions for other types
            if self.pkg.changes["architecture"].has_key("source"):
                if fpr.source_acl.access_level is None:
                    rej = 'Fingerprint %s may not upload source' % fpr.fingerprint
                    rej += '\nPlease contact ftpmaster if you think this is incorrect'
                    self.rejects.append(rej)
                    return
            else:
                # If not a DM, we allow full upload rights
                uid_email = "%s@debian.org" % (fpr.uid.uid)
                self.check_if_upload_is_sponsored(uid_email, fpr.uid.name)


        # Check binary upload permissions
        # By this point we know that DMs can't have got here unless they
        # are allowed to deal with the package concerned so just apply
        # normal checks
        if fpr.binary_acl.access_level == 'full':
            return

        # Otherwise we're in the map case
        tmparches = self.pkg.changes["architecture"].copy()
        tmparches.pop('source', None)

        for bam in fpr.binary_acl_map:
            tmparches.pop(bam.architecture.arch_string, None)

        if len(tmparches.keys()) > 0:
            if fpr.binary_reject:
                rej = ".changes file contains files of architectures not permitted for fingerprint %s" % fpr.fingerprint
                rej += "\narchitectures involved are: ", ",".join(tmparches.keys())
                self.rejects.append(rej)
            else:
                # TODO: This is where we'll implement reject vs throw away binaries later
                rej = "Uhm.  I'm meant to throw away the binaries now but that's not implemented yet"
                rej += "\nPlease complain to ftpmaster@debian.org as this shouldn't have been turned on"
                rej += "\nFingerprint: %s", (fpr.fingerprint)
                self.rejects.append(rej)


    def check_upload_blocks(self, fpr, session):
        """Check whether any upload blocks apply to this source, source
           version, uid / fpr combination"""

        def block_rej_template(fb):
            rej = 'Manual upload block in place for package %s' % fb.source
            if fb.version is not None:
                rej += ', version %s' % fb.version
            return rej

        for fb in session.query(UploadBlock).filter_by(source = self.pkg.changes['source']).all():
            # version is None if the block applies to all versions
            if fb.version is None or fb.version == self.pkg.changes['version']:
                # Check both fpr and uid - either is enough to cause a reject
                if fb.fpr is not None:
                    if fb.fpr.fingerprint == fpr.fingerprint:
                        self.rejects.append(block_rej_template(fb) + ' for fingerprint %s\nReason: %s' % (fpr.fingerprint, fb.reason))
                if fb.uid is not None:
                    if fb.uid == fpr.uid:
                        self.rejects.append(block_rej_template(fb) + ' for uid %s\nReason: %s' % (fb.uid.uid, fb.reason))


    def check_dm_upload(self, fpr, session):
        # Quoth the GR (http://www.debian.org/vote/2007/vote_003):
        ## none of the uploaded packages are NEW
        rej = False
        for f in self.pkg.files.keys():
            if self.pkg.files[f].has_key("byhand"):
1548
                self.rejects.append("%s may not upload BYHAND file %s" % (fpr.uid.uid, f))
M
Mark Hymers 已提交
1549 1550
                rej = True
            if self.pkg.files[f].has_key("new"):
1551
                self.rejects.append("%s may not upload NEW file %s" % (fpr.uid.uid, f))
M
Mark Hymers 已提交
1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613
                rej = True

        if rej:
            return

        ## the most recent version of the package uploaded to unstable or
        ## experimental includes the field "DM-Upload-Allowed: yes" in the source
        ## section of its control file
        q = session.query(DBSource).filter_by(source=self.pkg.changes["source"])
        q = q.join(SrcAssociation)
        q = q.join(Suite).filter(Suite.suite_name.in_(['unstable', 'experimental']))
        q = q.order_by(desc('source.version')).limit(1)

        r = q.all()

        if len(r) != 1:
            rej = "Could not find existing source package %s in unstable or experimental and this is a DM upload" % self.pkg.changes["source"]
            self.rejects.append(rej)
            return

        r = r[0]
        if not r.dm_upload_allowed:
            rej = "Source package %s does not have 'DM-Upload-Allowed: yes' in its most recent version (%s)" % (self.pkg.changes["source"], r.version)
            self.rejects.append(rej)
            return

        ## the Maintainer: field of the uploaded .changes file corresponds with
        ## the owner of the key used (ie, non-developer maintainers may not sponsor
        ## uploads)
        if self.check_if_upload_is_sponsored(fpr.uid.uid, fpr.uid.name):
            self.rejects.append("%s (%s) is not authorised to sponsor uploads" % (fpr.uid.uid, fpr.fingerprint))

        ## the most recent version of the package uploaded to unstable or
        ## experimental lists the uploader in the Maintainer: or Uploaders: fields (ie,
        ## non-developer maintainers cannot NMU or hijack packages)

        # srcuploaders includes the maintainer
        accept = False
        for sup in r.srcuploaders:
            (rfc822, rfc2047, name, email) = sup.maintainer.get_split_maintainer()
            # Eww - I hope we never have two people with the same name in Debian
            if email == fpr.uid.uid or name == fpr.uid.name:
                accept = True
                break

        if not accept:
            self.rejects.append("%s is not in Maintainer or Uploaders of source package %s" % (fpr.uid.uid, self.pkg.changes["source"]))
            return

        ## none of the packages are being taken over from other source packages
        for b in self.pkg.changes["binary"].keys():
            for suite in self.pkg.changes["distribution"].keys():
                q = session.query(DBSource)
                q = q.join(DBBinary).filter_by(package=b)
                q = q.join(BinAssociation).join(Suite).filter_by(suite_name=suite)

                for s in q.all():
                    if s.source != self.pkg.changes["source"]:
                        self.rejects.append("%s may not hijack %s from source package %s in suite %s" % (fpr.uid.uid, b, s, suite))



1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666
    def check_transition(self, session):
        cnf = Config()

        sourcepkg = self.pkg.changes["source"]

        # No sourceful upload -> no need to do anything else, direct return
        # We also work with unstable uploads, not experimental or those going to some
        # proposed-updates queue
        if "source" not in self.pkg.changes["architecture"] or \
           "unstable" not in self.pkg.changes["distribution"]:
            return

        # Also only check if there is a file defined (and existant) with
        # checks.
        transpath = cnf.get("Dinstall::Reject::ReleaseTransitions", "")
        if transpath == "" or not os.path.exists(transpath):
            return

        # Parse the yaml file
        sourcefile = file(transpath, 'r')
        sourcecontent = sourcefile.read()
        try:
            transitions = yaml.load(sourcecontent)
        except yaml.YAMLError, msg:
            # This shouldn't happen, there is a wrapper to edit the file which
            # checks it, but we prefer to be safe than ending up rejecting
            # everything.
            utils.warn("Not checking transitions, the transitions file is broken: %s." % (msg))
            return

        # Now look through all defined transitions
        for trans in transitions:
            t = transitions[trans]
            source = t["source"]
            expected = t["new"]

            # Will be None if nothing is in testing.
            current = get_source_in_suite(source, "testing", session)
            if current is not None:
                compare = apt_pkg.VersionCompare(current.version, expected)

            if current is None or compare < 0:
                # This is still valid, the current version in testing is older than
                # the new version we wait for, or there is none in testing yet

                # Check if the source we look at is affected by this.
                if sourcepkg in t['packages']:
                    # The source is affected, lets reject it.

                    rejectmsg = "%s: part of the %s transition.\n\n" % (
                        sourcepkg, trans)

                    if current is not None:
M
Mark Hymers 已提交
1667
                        currentlymsg = "at version %s" % (current.version)
1668 1669 1670 1671 1672 1673
                    else:
                        currentlymsg = "not present in testing"

                    rejectmsg += "Transition description: %s\n\n" % (t["reason"])

                    rejectmsg += "\n".join(textwrap.wrap("""Your package
M
Mark Hymers 已提交
1674 1675 1676 1677 1678 1679
is part of a testing transition designed to get %s migrated (it is
currently %s, we need version %s).  This transition is managed by the
Release Team, and %s is the Release-Team member responsible for it.
Please mail debian-release@lists.debian.org or contact %s directly if you
need further assistance.  You might want to upload to experimental until this
transition is done."""
M
Mark Hymers 已提交
1680
                            % (source, currentlymsg, expected,t["rm"], t["rm"])))
1681 1682 1683 1684

                    self.rejects.append(rejectmsg)
                    return

1685
    ###########################################################################
M
Mark Hymers 已提交
1686
    # End check_signed_by_key checks
1687
    ###########################################################################
M
Mark Hymers 已提交
1688

J
New.  
James Troup 已提交
1689
    def build_summaries(self):
J
Joerg Jaspert 已提交
1690
        """ Build a summary of changes the upload introduces. """
1691 1692

        (byhand, new, summary, override_summary) = self.pkg.file_summary()
J
New.  
James Troup 已提交
1693

1694
        short_summary = summary
J
New.  
James Troup 已提交
1695 1696

        # This is for direport's benefit...
1697
        f = re_fdnic.sub("\n .\n", self.pkg.changes.get("changes", ""))
J
New.  
James Troup 已提交
1698 1699

        if byhand or new:
1700
            summary += "Changes: " + f
J
New.  
James Troup 已提交
1701

1702 1703
        summary += "\n\nOverride entries for your package:\n" + override_summary + "\n"

1704
        summary += self.announce(short_summary, 0)
J
New.  
James Troup 已提交
1705

1706
        return (summary, short_summary)
J
New.  
James Troup 已提交
1707 1708 1709

    ###########################################################################

1710
    def close_bugs(self, summary, action):
J
Joerg Jaspert 已提交
1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724
        """
        Send mail to close bugs as instructed by the closes field in the changes file.
        Also add a line to summary if any work was done.

        @type summary: string
        @param summary: summary text, as given by L{build_summaries}

        @type action: bool
        @param action: Set to false no real action will be done.

        @rtype: string
        @return: summary. If action was taken, extended by the list of closed bugs.

        """
J
New.  
James Troup 已提交
1725

1726 1727 1728
        template = os.path.join(Config()["Dir::Templates"], 'process-unchecked.bug-close')

        bugs = self.pkg.changes["closes"].keys()
J
New.  
James Troup 已提交
1729

1730
        if not bugs:
1731
            return summary
J
New.  
James Troup 已提交
1732

1733
        bugs.sort()
1734 1735 1736 1737
        summary += "Closing bugs: "
        for bug in bugs:
            summary += "%s " % (bug)
            if action:
M
Mark Hymers 已提交
1738
                self.update_subst()
1739 1740 1741
                self.Subst["__BUG_NUMBER__"] = bug
                if self.pkg.changes["distribution"].has_key("stable"):
                    self.Subst["__STABLE_WARNING__"] = """
1742 1743 1744 1745
Note that this package is not part of the released stable Debian
distribution.  It may have dependencies on other unreleased software,
or other instabilities.  Please take care if you wish to install it.
The update will eventually make its way into the next released Debian
1746
distribution."""
1747
                else:
1748
                    self.Subst["__STABLE_WARNING__"] = ""
M
Mark Hymers 已提交
1749 1750
                mail_message = utils.TemplateSubst(self.Subst, template)
                utils.send_mail(mail_message)
1751 1752 1753 1754 1755

                # Clear up after ourselves
                del self.Subst["__BUG_NUMBER__"]
                del self.Subst["__STABLE_WARNING__"]

M
Mark Hymers 已提交
1756 1757
        if action and self.logger:
            self.logger.log(["closing bugs"] + bugs)
1758

1759
        summary += "\n"
1760

1761
        return summary
1762 1763 1764

    ###########################################################################

1765
    def announce(self, short_summary, action):
J
Joerg Jaspert 已提交
1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778
        """
        Send an announce mail about a new upload.

        @type short_summary: string
        @param short_summary: Short summary text to include in the mail

        @type action: bool
        @param action: Set to false no real action will be done.

        @rtype: string
        @return: Textstring about action taken.

        """
1779 1780 1781

        cnf = Config()
        announcetemplate = os.path.join(cnf["Dir::Templates"], 'process-unchecked.announce')
1782 1783

        # Only do announcements for source uploads with a recent dpkg-dev installed
1784 1785
        if float(self.pkg.changes.get("format", 0)) < 1.6 or not \
           self.pkg.changes["architecture"].has_key("source"):
1786
            return ""
J
New.  
James Troup 已提交
1787

1788 1789
        lists_done = {}
        summary = ""
1790

1791 1792 1793
        self.Subst["__SHORT_SUMMARY__"] = short_summary

        for dist in self.pkg.changes["distribution"].keys():
M
Mark Hymers 已提交
1794
            announce_list = cnf.Find("Suite::%s::Announce" % (dist))
J
Joerg Jaspert 已提交
1795
            if announce_list == "" or lists_done.has_key(announce_list):
1796
                continue
1797

J
Joerg Jaspert 已提交
1798 1799
            lists_done[announce_list] = 1
            summary += "Announcing to %s\n" % (announce_list)
1800 1801

            if action:
M
Mark Hymers 已提交
1802
                self.update_subst()
1803 1804 1805 1806 1807 1808 1809 1810
                self.Subst["__ANNOUNCE_LIST_ADDRESS__"] = announce_list
                if cnf.get("Dinstall::TrackingServer") and \
                   self.pkg.changes["architecture"].has_key("source"):
                    trackingsendto = "Bcc: %s@%s" % (self.pkg.changes["source"], cnf["Dinstall::TrackingServer"])
                    self.Subst["__ANNOUNCE_LIST_ADDRESS__"] += "\n" + trackingsendto

                mail_message = utils.TemplateSubst(self.Subst, announcetemplate)
                utils.send_mail(mail_message)
1811

1812 1813 1814
                del self.Subst["__ANNOUNCE_LIST_ADDRESS__"]

        if cnf.FindB("Dinstall::CloseBugs"):
1815
            summary = self.close_bugs(summary, action)
1816

1817 1818
        del self.Subst["__SHORT_SUMMARY__"]

1819
        return summary
J
New.  
James Troup 已提交
1820 1821 1822

    ###########################################################################

1823
    def accept (self, summary, short_summary, session):
J
Joerg Jaspert 已提交
1824 1825 1826
        """
        Accept an upload.

1827 1828
        This moves all files referenced from the .changes into the pool,
        sends the accepted mail, announces to lists, closes bugs and
J
Joerg Jaspert 已提交
1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839
        also checks for override disparities. If enabled it will write out
        the version history for the BTS Version Tracking and will finally call
        L{queue_build}.

        @type summary: string
        @param summary: Summary text

        @type short_summary: string
        @param short_summary: Short summary
        """

1840 1841 1842
        cnf = Config()
        stats = SummaryStats()

1843 1844
        print "Installing."
        Logger.log(["installing changes", u.pkg.changes_file])
J
New.  
James Troup 已提交
1845

1846 1847 1848 1849
        # Add the .dsc file to the DB first
        for newfile, entry in u.pkg.files.items():
            if entry["type"] == "dsc":
                dsc_component, dsc_location_id = add_dsc_to_db(u, newfile, session)
1850

1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915
        # Add .deb / .udeb files to the DB (type is always deb, dbtype is udeb/deb)
        for newfile, entry in u.pkg.files.items():
            if entry["type"] == "deb":
                add_deb_to_db(u, newfile, session)

        # If this is a sourceful diff only upload that is moving
        # cross-component we need to copy the .orig files into the new
        # component too for the same reasons as above.
        if u.pkg.changes["architecture"].has_key("source"):
            for orig_file in u.pkg.orig_files.keys():
                if not u.pkg.orig_files[orig_file].has_key("id"):
                    continue # Skip if it's not in the pool
                orig_file_id = u.pkg.orig_files[orig_file]["id"]
                if u.pkg.orig_files[orig_file]["location"] == dsc_location_id:
                    continue # Skip if the location didn't change

                # Do the move
                oldf = get_poolfile_by_id(orig_file_id, session)
                old_filename = os.path.join(oldf.location.path, oldf.filename)
                old_dat = {'size': oldf.filesize,   'md5sum': oldf.md5sum,
                           'sha1sum': oldf.sha1sum, 'sha256sum': oldf.sha256sum}

                new_filename = os.path.join(utils.poolify(u.pkg.changes["source"], dsc_component), os.path.basename(old_filename))

                # TODO: Care about size/md5sum collisions etc
                (found, newf) = check_poolfile(new_filename, file_size, file_md5sum, dsc_location_id, session)

                if newf is None:
                    utils.copy(old_filename, os.path.join(cnf["Dir::Pool"], new_filename))
                    newf = add_poolfile(new_filename, old_dat, dsc_location_id, session)

                    # TODO: Check that there's only 1 here
                    source = get_sources_from_name(u.pkg.changes["source"], u.pkg.changes["version"])[0]
                    dscf = get_dscfiles(source_id=source.source_id, poolfile_id=orig_file_id, session=session)[0]
                    dscf.poolfile_id = newf.file_id
                    session.add(dscf)
                    session.flush()

        # Install the files into the pool
        for newfile, entry in u.pkg.files.items():
            destination = os.path.join(cnf["Dir::Pool"], entry["pool name"], newfile)
            utils.move(newfile, destination)
            Logger.log(["installed", newfile, entry["type"], entry["size"], entry["architecture"]])
            summarystats.accept_bytes += float(entry["size"])

        # Copy the .changes file across for suite which need it.
        copy_changes = {}
        for suite_name in u.pkg.changes["distribution"].keys():
            if cnf.has_key("Suite::%s::CopyChanges" % (suite_name)):
                copy_changes[cnf["Suite::%s::CopyChanges" % (suite_name)]] = ""

        for dest in copy_changes.keys():
            utils.copy(u.pkg.changes_file, os.path.join(cnf["Dir::Root"], dest))

        # We're done - commit the database changes
        session.commit()
        # Our SQL session will automatically start a new transaction after
        # the last commit

        # Move the .changes into the 'done' directory
        utils.move(u.pkg.changes_file,
                   os.path.join(cnf["Dir::Queue::Done"], os.path.basename(u.pkg.changes_file)))

        if u.pkg.changes["architecture"].has_key("source") and log_urgency:
            UrgencyLog().log(u.pkg.dsc["source"], u.pkg.dsc["version"], u.pkg.changes["urgency"])
J
New.  
James Troup 已提交
1916 1917 1918

        # Send accept mail, announce to lists, close bugs and check for
        # override disparities
1919
        if not cnf["Dinstall::Options::No-Mail"]:
M
Mark Hymers 已提交
1920
            self.update_subst()
1921 1922 1923
            self.Subst["__SUITE__"] = ""
            self.Subst["__SUMMARY__"] = summary
            mail_message = utils.TemplateSubst(self.Subst, accepttemplate)
1924
            utils.send_mail(mail_message)
J
New.  
James Troup 已提交
1925 1926
            self.announce(short_summary, 1)

1927
        ## Helper stuff for DebBugs Version Tracking
1928
        if cnf.Find("Dir::Queue::BTSVersionTrack"):
1929 1930 1931 1932 1933
            # ??? once queue/* is cleared on *.d.o and/or reprocessed
            # the conditionalization on dsc["bts changelog"] should be
            # dropped.

            # Write out the version history from the changelog
1934 1935
            if self.pkg.changes["architecture"].has_key("source") and \
               self.pkg.dsc.has_key("bts changelog"):
1936

1937
                (fd, temp_filename) = utils.temp_filename(cnf["Dir::Queue::BTSVersionTrack"], prefix=".")
J
fdopen  
Joerg Jaspert 已提交
1938
                version_history = os.fdopen(fd, 'w')
1939
                version_history.write(self.pkg.dsc["bts changelog"])
1940
                version_history.close()
1941 1942
                filename = "%s/%s" % (cnf["Dir::Queue::BTSVersionTrack"],
                                      self.pkg.changes_file[:-8]+".versions")
1943
                os.rename(temp_filename, filename)
J
Joerg Jaspert 已提交
1944
                os.chmod(filename, 0644)
1945 1946

            # Write out the binary -> source mapping.
1947
            (fd, temp_filename) = utils.temp_filename(cnf["Dir::Queue::BTSVersionTrack"], prefix=".")
J
fdopen  
Joerg Jaspert 已提交
1948
            debinfo = os.fdopen(fd, 'w')
1949 1950 1951 1952 1953
            for name, entry in sorted(self.pkg.files.items()):
                if entry["type"] == "deb":
                    line = " ".join([entry["package"], entry["version"],
                                     entry["architecture"], entry["source package"],
                                     entry["source version"]])
1954 1955
                    debinfo.write(line+"\n")
            debinfo.close()
1956 1957
            filename = "%s/%s" % (cnf["Dir::Queue::BTSVersionTrack"],
                                  self.pkg.changes_file[:-8]+".debinfo")
1958
            os.rename(temp_filename, filename)
J
Joerg Jaspert 已提交
1959
            os.chmod(filename, 0644)
1960

1961 1962 1963 1964 1965 1966 1967
        # auto-build queue
#        res = get_or_set_queue('buildd', session).autobuild_upload(self.pkg, session)
#        if res:
#            utils.fubar(res)
#            now_date = datetime.now()

        session.commit()
J
Joerg Jaspert 已提交
1968

1969 1970
        # Finally...
        summarystats.accept_count += 1
J
New.  
James Troup 已提交
1971

1972
    def check_override(self):
J
Joerg Jaspert 已提交
1973 1974 1975 1976 1977 1978 1979 1980
        """
        Checks override entries for validity. Mails "Override disparity" warnings,
        if that feature is enabled.

        Abandons the check if
          - override disparity checks are disabled
          - mail sending is disabled
        """
1981 1982

        cnf = Config()
J
New.  
James Troup 已提交
1983

1984
        # Abandon the check if:
1985 1986 1987 1988
        #  a) override disparity checks have been disabled
        #  b) we're not sending mail
        if not cnf.FindB("Dinstall::OverrideDisparityCheck") or \
           cnf["Dinstall::Options::No-Mail"]:
1989
            return
J
New.  
James Troup 已提交
1990

1991
        summary = self.pkg.check_override()
J
New.  
James Troup 已提交
1992 1993

        if summary == "":
1994
            return
J
New.  
James Troup 已提交
1995

1996 1997
        overridetemplate = os.path.join(cnf["Dir::Templates"], 'process-unchecked.override-disparity')

M
Mark Hymers 已提交
1998
        self.update_subst()
1999 2000
        self.Subst["__SUMMARY__"] = summary
        mail_message = utils.TemplateSubst(self.Subst, overridetemplate)
2001
        utils.send_mail(mail_message)
2002
        del self.Subst["__SUMMARY__"]
J
New.  
James Troup 已提交
2003 2004

    ###########################################################################
2005

C
Chris Lamb 已提交
2006
    def remove(self, from_dir=None):
2007 2008 2009
        """
        Used (for instance) in p-u to remove the package from unchecked
        """
C
Chris Lamb 已提交
2010
        if from_dir is None:
2011 2012
            os.chdir(self.pkg.directory)
        else:
C
Chris Lamb 已提交
2013
            os.chdir(from_dir)
2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030

        for f in self.pkg.files.keys():
            os.unlink(f)
        os.unlink(self.pkg.changes_file)

    ###########################################################################

    def move_to_dir (self, dest, perms=0660, changesperms=0664):
        """
        Move files to dest with certain perms/changesperms
        """
        utils.move(self.pkg.changes_file, dest, perms=changesperms)
        for f in self.pkg.files.keys():
            utils.move(f, dest, perms=perms)

    ###########################################################################

2031
    def force_reject(self, reject_files):
J
Joerg Jaspert 已提交
2032 2033 2034 2035 2036 2037 2038 2039 2040 2041
        """
        Forcefully move files from the current directory to the
        reject directory.  If any file already exists in the reject
        directory it will be moved to the morgue to make way for
        the new file.

        @type files: dict
        @param files: file dictionary

        """
J
New.  
James Troup 已提交
2042

2043
        cnf = Config()
J
New.  
James Troup 已提交
2044

2045
        for file_entry in reject_files:
J
New.  
James Troup 已提交
2046
            # Skip any files which don't exist or which we don't have permission to copy.
2047
            if os.access(file_entry, os.R_OK) == 0:
2048
                continue
2049 2050 2051

            dest_file = os.path.join(cnf["Dir::Queue::Reject"], file_entry)

J
New.  
James Troup 已提交
2052
            try:
2053
                dest_fd = os.open(dest_file, os.O_RDWR | os.O_CREAT | os.O_EXCL, 0644)
J
New.  
James Troup 已提交
2054 2055
            except OSError, e:
                # File exists?  Let's try and move it to the morgue
2056 2057
                if e.errno == errno.EEXIST:
                    morgue_file = os.path.join(cnf["Dir::Morgue"], cnf["Dir::MorgueReject"], file_entry)
J
New.  
James Troup 已提交
2058
                    try:
2059
                        morgue_file = utils.find_next_free(morgue_file)
J
Joerg Jaspert 已提交
2060
                    except NoFreeFilenameError:
J
New.  
James Troup 已提交
2061 2062
                        # Something's either gone badly Pete Tong, or
                        # someone is trying to exploit us.
J
Joerg Jaspert 已提交
2063
                        utils.warn("**WARNING** failed to move %s from the reject directory to the morgue." % (file_entry))
2064 2065
                        return
                    utils.move(dest_file, morgue_file, perms=0660)
J
New.  
James Troup 已提交
2066
                    try:
2067
                        dest_fd = os.open(dest_file, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0644)
J
New.  
James Troup 已提交
2068 2069
                    except OSError, e:
                        # Likewise
J
Joerg Jaspert 已提交
2070
                        utils.warn("**WARNING** failed to claim %s in the reject directory." % (file_entry))
2071
                        return
J
New.  
James Troup 已提交
2072
                else:
2073
                    raise
J
New.  
James Troup 已提交
2074 2075
            # If we got here, we own the destination file, so we can
            # safely overwrite it.
J
Joerg Jaspert 已提交
2076
            utils.move(file_entry, dest_file, 1, perms=0660)
2077
            os.close(dest_fd)
2078

J
New.  
James Troup 已提交
2079
    ###########################################################################
2080
    def do_reject (self, manual=0, reject_message="", note=""):
J
Joerg Jaspert 已提交
2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093
        """
        Reject an upload. If called without a reject message or C{manual} is
        true, spawn an editor so the user can write one.

        @type manual: bool
        @param manual: manual or automated rejection

        @type reject_message: string
        @param reject_message: A reject message

        @return: 0

        """
J
James Troup 已提交
2094 2095 2096
        # If we weren't given a manual rejection message, spawn an
        # editor so the user can add one in...
        if manual and not reject_message:
J
various  
Joerg Jaspert 已提交
2097
            (fd, temp_filename) = utils.temp_filename()
J
Joerg Jaspert 已提交
2098 2099 2100 2101 2102
            temp_file = os.fdopen(fd, 'w')
            if len(note) > 0:
                for line in note:
                    temp_file.write(line)
            temp_file.close()
J
James Troup 已提交
2103
            editor = os.environ.get("EDITOR","vi")
2104
            answer = 'E'
J
James Troup 已提交
2105 2106
            while answer == 'E':
                os.system("%s %s" % (editor, temp_filename))
2107 2108 2109 2110 2111
                temp_fh = utils.open_file(temp_filename)
                reject_message = "".join(temp_fh.readlines())
                temp_fh.close()
                print "Reject message:"
                print utils.prefix_multi_line_string(reject_message,"  ",include_blank_lines=1)
J
James Troup 已提交
2112
                prompt = "[R]eject, Edit, Abandon, Quit ?"
2113
                answer = "XXX"
2114
                while prompt.find(answer) == -1:
2115 2116
                    answer = utils.our_raw_input(prompt)
                    m = re_default_answer.search(prompt)
J
James Troup 已提交
2117
                    if answer == "":
2118 2119 2120
                        answer = m.group(1)
                    answer = answer[:1].upper()
            os.unlink(temp_filename)
J
James Troup 已提交
2121
            if answer == 'A':
2122
                return 1
J
James Troup 已提交
2123
            elif answer == 'Q':
2124
                sys.exit(0)
J
James Troup 已提交
2125

J
New.  
James Troup 已提交
2126 2127
        print "Rejecting.\n"

2128
        cnf = Config()
J
New.  
James Troup 已提交
2129

2130 2131
        reason_filename = self.pkg.changes_file[:-8] + ".reason"
        reason_filename = os.path.join(cnf["Dir::Queue::Reject"], reason_filename)
J
New.  
James Troup 已提交
2132 2133

        # Move all the files into the reject directory
2134
        reject_files = self.pkg.files.keys() + [self.pkg.changes_file]
2135
        self.force_reject(reject_files)
J
New.  
James Troup 已提交
2136 2137 2138

        # If we fail here someone is probably trying to exploit the race
        # so let's just raise an exception ...
J
James Troup 已提交
2139
        if os.path.exists(reason_filename):
2140 2141
            os.unlink(reason_filename)
        reason_fd = os.open(reason_filename, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0644)
J
New.  
James Troup 已提交
2142

2143 2144
        rej_template = os.path.join(cnf["Dir::Templates"], "queue.rejected")

M
Mark Hymers 已提交
2145
        self.update_subst()
J
New.  
James Troup 已提交
2146
        if not manual:
2147 2148
            self.Subst["__REJECTOR_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
            self.Subst["__MANUAL_REJECT_MESSAGE__"] = ""
J
Joerg Jaspert 已提交
2149
            self.Subst["__CC__"] = "X-DAK-Rejection: automatic (moo)"
2150
            os.write(reason_fd, reject_message)
2151
            reject_mail_message = utils.TemplateSubst(self.Subst, rej_template)
J
New.  
James Troup 已提交
2152 2153
        else:
            # Build up the rejection email
2154 2155 2156
            user_email_address = utils.whoami() + " <%s>" % (cnf["Dinstall::MyAdminAddress"])
            self.Subst["__REJECTOR_ADDRESS__"] = user_email_address
            self.Subst["__MANUAL_REJECT_MESSAGE__"] = reject_message
F
Frank Lichtenheld 已提交
2157
            self.Subst["__CC__"] = "Cc: " + cnf["Dinstall::MyEmailAddress"]
2158
            reject_mail_message = utils.TemplateSubst(self.Subst, rej_template)
J
New.  
James Troup 已提交
2159
            # Write the rejection email out as the <foo>.reason file
2160
            os.write(reason_fd, reject_mail_message)
J
James Troup 已提交
2161

2162 2163 2164 2165
        del self.Subst["__REJECTOR_ADDRESS__"]
        del self.Subst["__MANUAL_REJECT_MESSAGE__"]
        del self.Subst["__CC__"]

2166
        os.close(reason_fd)
J
New.  
James Troup 已提交
2167 2168

        # Send the rejection mail if appropriate
2169
        if not cnf["Dinstall::Options::No-Mail"]:
2170
            utils.send_mail(reject_mail_message)
J
New.  
James Troup 已提交
2171

M
Mark Hymers 已提交
2172 2173
        if self.logger:
            self.logger.log(["rejected", self.pkg.changes_file])
J
Joerg Jaspert 已提交
2174

2175
        return 0
J
New.  
James Troup 已提交
2176 2177

    ################################################################################
2178
    def in_override_p(self, package, component, suite, binary_type, filename, session):
J
Joerg Jaspert 已提交
2179 2180 2181 2182 2183 2184 2185
        """
        Check if a package already has override entries in the DB

        @type package: string
        @param package: package name

        @type component: string
2186
        @param component: database id of the component
J
Joerg Jaspert 已提交
2187 2188

        @type suite: int
2189
        @param suite: database id of the suite
J
Joerg Jaspert 已提交
2190 2191 2192 2193

        @type binary_type: string
        @param binary_type: type of the package

2194 2195
        @type filename: string
        @param filename: filename we check
J
Joerg Jaspert 已提交
2196 2197 2198 2199

        @return: the database result. But noone cares anyway.

        """
2200 2201 2202

        cnf = Config()

J
New.  
James Troup 已提交
2203
        if binary_type == "": # must be source
J
Joerg Jaspert 已提交
2204
            file_type = "dsc"
J
New.  
James Troup 已提交
2205
        else:
J
Joerg Jaspert 已提交
2206
            file_type = binary_type
J
New.  
James Troup 已提交
2207 2208

        # Override suite name; used for example with proposed-updates
2209 2210 2211 2212
        if cnf.Find("Suite::%s::OverrideSuite" % (suite)) != "":
            suite = cnf["Suite::%s::OverrideSuite" % (suite)]

        result = get_override(package, suite, component, file_type, session)
J
New.  
James Troup 已提交
2213 2214

        # If checking for a source package fall back on the binary override type
2215 2216
        if file_type == "dsc" and len(result) < 1:
            result = get_override(package, suite, component, ['deb', 'udeb'], session)
J
New.  
James Troup 已提交
2217 2218

        # Remember the section and priority so we can check them later if appropriate
2219 2220
        if len(result) > 0:
            result = result[0]
2221 2222
            self.pkg.files[filename]["override section"] = result.section.section
            self.pkg.files[filename]["override priority"] = result.priority.priority
2223
            return result
J
New.  
James Troup 已提交
2224

2225
        return None
J
New.  
James Troup 已提交
2226

2227
    ################################################################################
2228 2229 2230 2231 2232 2233 2234
    def get_anyversion(self, sv_list, suite):
        """
        @type sv_list: list
        @param sv_list: list of (suite, version) tuples to check

        @type suite: string
        @param suite: suite name
2235

2236 2237
        Description: TODO
        """
M
Mark Hymers 已提交
2238
        Cnf = Config()
2239
        anyversion = None
M
Mark Hymers 已提交
2240
        anysuite = [suite] + Cnf.ValueList("Suite::%s::VersionChecks::Enhances" % (suite))
2241
        for (s, v) in sv_list:
2242
            if s in [ x.lower() for x in anysuite ]:
2243
                if not anyversion or apt_pkg.VersionCompare(anyversion, v) <= 0:
2244 2245
                    anyversion = v

2246 2247 2248 2249
        return anyversion

    ################################################################################

2250
    def cross_suite_version_check(self, sv_list, filename, new_version, sourceful=False):
J
Joerg Jaspert 已提交
2251
        """
2252 2253 2254
        @type sv_list: list
        @param sv_list: list of (suite, version) tuples to check

2255 2256
        @type filename: string
        @param filename: XXX
2257 2258 2259 2260

        @type new_version: string
        @param new_version: XXX

J
Joerg Jaspert 已提交
2261
        Ensure versions are newer than existing packages in target
2262
        suites and that cross-suite version checking rules as
J
Joerg Jaspert 已提交
2263 2264
        set out in the conf file are satisfied.
        """
2265

2266 2267
        cnf = Config()

2268 2269
        # Check versions for each target suite
        for target_suite in self.pkg.changes["distribution"].keys():
2270 2271 2272
            must_be_newer_than = [ i.lower() for i in cnf.ValueList("Suite::%s::VersionChecks::MustBeNewerThan" % (target_suite)) ]
            must_be_older_than = [ i.lower() for i in cnf.ValueList("Suite::%s::VersionChecks::MustBeOlderThan" % (target_suite)) ]

2273 2274
            # Enforce "must be newer than target suite" even if conffile omits it
            if target_suite not in must_be_newer_than:
2275
                must_be_newer_than.append(target_suite)
2276 2277 2278 2279 2280

            for (suite, existent_version) in sv_list:
                vercmp = apt_pkg.VersionCompare(new_version, existent_version)

                if suite in must_be_newer_than and sourceful and vercmp < 1:
2281
                    self.rejects.append("%s: old version (%s) in %s >= new version (%s) targeted at %s." % (filename, existent_version, suite, new_version, target_suite))
2282 2283

                if suite in must_be_older_than and vercmp > -1:
2284
                    cansave = 0
2285

2286 2287 2288 2289 2290 2291
                    if self.pkg.changes.get('distribution-version', {}).has_key(suite):
                        # we really use the other suite, ignoring the conflicting one ...
                        addsuite = self.pkg.changes["distribution-version"][suite]

                        add_version = self.get_anyversion(sv_list, addsuite)
                        target_version = self.get_anyversion(sv_list, target_suite)
2292

2293 2294 2295 2296 2297 2298 2299 2300 2301 2302
                        if not add_version:
                            # not add_version can only happen if we map to a suite
                            # that doesn't enhance the suite we're propup'ing from.
                            # so "propup-ver x a b c; map a d" is a problem only if
                            # d doesn't enhance a.
                            #
                            # i think we could always propagate in this case, rather
                            # than complaining. either way, this isn't a REJECT issue
                            #
                            # And - we really should complain to the dorks who configured dak
2303
                            self.warnings.append("%s is mapped to, but not enhanced by %s - adding anyways" % (suite, addsuite))
2304 2305
                            self.pkg.changes.setdefault("propdistribution", {})
                            self.pkg.changes["propdistribution"][addsuite] = 1
2306 2307 2308 2309 2310
                            cansave = 1
                        elif not target_version:
                            # not targets_version is true when the package is NEW
                            # we could just stick with the "...old version..." REJECT
                            # for this, I think.
2311
                            self.rejects.append("Won't propogate NEW packages.")
2312 2313
                        elif apt_pkg.VersionCompare(new_version, add_version) < 0:
                            # propogation would be redundant. no need to reject though.
2314
                            self.warnings.append("ignoring versionconflict: %s: old version (%s) in %s <= new version (%s) targeted at %s." % (filename, existent_version, suite, new_version, target_suite))
2315 2316
                            cansave = 1
                        elif apt_pkg.VersionCompare(new_version, add_version) > 0 and \
2317
                             apt_pkg.VersionCompare(add_version, target_version) >= 0:
2318
                            # propogate!!
2319
                            self.warnings.append("Propogating upload to %s" % (addsuite))
2320 2321
                            self.pkg.changes.setdefault("propdistribution", {})
                            self.pkg.changes["propdistribution"][addsuite] = 1
2322
                            cansave = 1
2323

2324
                    if not cansave:
2325
                        self.reject.append("%s: old version (%s) in %s <= new version (%s) targeted at %s." % (filename, existent_version, suite, new_version, target_suite))
2326 2327

    ################################################################################
2328
    def check_binary_against_db(self, filename, session):
2329
        # Ensure version is sane
2330
        q = session.query(BinAssociation)
2331 2332
        q = q.join(DBBinary).filter(DBBinary.package==self.pkg.files[filename]["package"])
        q = q.join(Architecture).filter(Architecture.arch_string.in_([self.pkg.files[filename]["architecture"], 'all']))
2333 2334

        self.cross_suite_version_check([ (x.suite.suite_name, x.binary.version) for x in q.all() ],
2335
                                       filename, self.pkg.files[filename]["version"], sourceful=False)
2336

J
New.  
James Troup 已提交
2337
        # Check for any existing copies of the file
2338 2339 2340
        q = session.query(DBBinary).filter_by(package=self.pkg.files[filename]["package"])
        q = q.filter_by(version=self.pkg.files[filename]["version"])
        q = q.join(Architecture).filter_by(arch_string=self.pkg.files[filename]["architecture"])
2341 2342

        if q.count() > 0:
2343
            self.rejects.append("%s: can not overwrite existing copy already in the archive." % filename)
J
New.  
James Troup 已提交
2344 2345 2346

    ################################################################################

2347
    def check_source_against_db(self, filename, session):
J
Joerg Jaspert 已提交
2348 2349
        """
        """
2350 2351
        source = self.pkg.dsc.get("source")
        version = self.pkg.dsc.get("version")
J
New.  
James Troup 已提交
2352

2353
        # Ensure version is sane
2354 2355 2356 2357
        q = session.query(SrcAssociation)
        q = q.join(DBSource).filter(DBSource.source==source)

        self.cross_suite_version_check([ (x.suite.suite_name, x.source.version) for x in q.all() ],
2358
                                       filename, version, sourceful=True)
2359

J
New.  
James Troup 已提交
2360
    ################################################################################
2361
    def check_dsc_against_db(self, filename, session):
J
Joerg Jaspert 已提交
2362 2363 2364
        """

        @warning: NB: this function can remove entries from the 'files' index [if
2365
         the orig tarball is a duplicate of the one in the archive]; if
J
Joerg Jaspert 已提交
2366 2367 2368 2369 2370
         you're iterating over 'files' and call this function as part of
         the loop, be sure to add a check to the top of the loop to
         ensure you haven't just tried to dereference the deleted entry.

        """
M
Mark Hymers 已提交
2371

M
Mark Hymers 已提交
2372
        Cnf = Config()
2373 2374
        self.pkg.orig_files = {} # XXX: do we need to clear it?
        orig_files = self.pkg.orig_files
J
New.  
James Troup 已提交
2375 2376 2377 2378

        # Try and find all files mentioned in the .dsc.  This has
        # to work harder to cope with the multiple possible
        # locations of an .orig.tar.gz.
2379 2380
        # The ordering on the select is needed to pick the newest orig
        # when it exists in multiple places.
2381
        for dsc_name, dsc_entry in self.pkg.dsc_files.items():
2382
            found = None
2383 2384 2385 2386 2387
            if self.pkg.files.has_key(dsc_name):
                actual_md5 = self.pkg.files[dsc_name]["md5sum"]
                actual_size = int(self.pkg.files[dsc_name]["size"])
                found = "%s in incoming" % (dsc_name)

J
New.  
James Troup 已提交
2388
                # Check the file does not already exist in the archive
M
Mark Hymers 已提交
2389
                ql = get_poolfile_like_name(dsc_name, session)
2390

2391 2392
                # Strip out anything that isn't '%s' or '/%s$'
                for i in ql:
2393
                    if not i.filename.endswith(dsc_name):
2394
                        ql.remove(i)
2395

2396
                # "[dak] has not broken them.  [dak] has fixed a
J
New.  
James Troup 已提交
2397 2398 2399 2400 2401 2402 2403 2404
                # brokenness.  Your crappy hack exploited a bug in
                # the old dinstall.
                #
                # "(Come on!  I thought it was always obvious that
                # one just doesn't release different files with
                # the same name and version.)"
                #                        -- ajk@ on d-devel@l.d.o

2405
                if len(ql) > 0:
2406
                    # Ignore exact matches for .orig.tar.gz
2407
                    match = 0
2408
                    if re_is_orig_source.match(dsc_name):
2409
                        for i in ql:
2410 2411 2412
                            if self.pkg.files.has_key(dsc_name) and \
                               int(self.pkg.files[dsc_name]["size"]) == int(i.filesize) and \
                               self.pkg.files[dsc_name]["md5sum"] == i.md5sum:
2413
                                self.warnings.append("ignoring %s, since it's already in the archive." % (dsc_name))
2414 2415 2416
                                # TODO: Don't delete the entry, just mark it as not needed
                                # This would fix the stupidity of changing something we often iterate over
                                # whilst we're doing it
M
Mark Hymers 已提交
2417
                                del self.pkg.files[dsc_name]
2418 2419 2420
                                if not orig_files.has_key(dsc_name):
                                    orig_files[dsc_name] = {}
                                orig_files[dsc_name]["path"] = os.path.join(i.location.path, i.filename)
2421
                                match = 1
2422 2423

                    if not match:
2424
                        self.rejects.append("can not overwrite existing copy of '%s' already in the archive." % (dsc_name))
2425

2426
            elif re_is_orig_source.match(dsc_name):
J
New.  
James Troup 已提交
2427
                # Check in the pool
M
Mark Hymers 已提交
2428
                ql = get_poolfile_like_name(dsc_name, session)
2429

2430
                # Strip out anything that isn't '%s' or '/%s$'
2431
                # TODO: Shouldn't we just search for things which end with our string explicitly in the SQL?
2432
                for i in ql:
2433
                    if not i.filename.endswith(dsc_name):
2434
                        ql.remove(i)
J
New.  
James Troup 已提交
2435

2436
                if len(ql) > 0:
2437 2438 2439
                    # Unfortunately, we may get more than one match here if,
                    # for example, the package was in potato but had an -sa
                    # upload in woody.  So we need to choose the right one.
J
New.  
James Troup 已提交
2440

J
Various  
Joerg Jaspert 已提交
2441 2442
                    # default to something sane in case we don't match any or have only one
                    x = ql[0]
J
New.  
James Troup 已提交
2443 2444 2445

                    if len(ql) > 1:
                        for i in ql:
2446
                            old_file = os.path.join(i.location.path, i.filename)
2447
                            old_file_fh = utils.open_file(old_file)
2448
                            actual_md5 = apt_pkg.md5sum(old_file_fh)
2449
                            old_file_fh.close()
2450
                            actual_size = os.stat(old_file)[stat.ST_SIZE]
2451
                            if actual_md5 == dsc_entry["md5sum"] and actual_size == int(dsc_entry["size"]):
2452
                                x = i
J
New.  
James Troup 已提交
2453

2454
                    old_file = os.path.join(i.location.path, i.filename)
2455
                    old_file_fh = utils.open_file(old_file)
2456
                    actual_md5 = apt_pkg.md5sum(old_file_fh)
2457
                    old_file_fh.close()
2458 2459
                    actual_size = os.stat(old_file)[stat.ST_SIZE]
                    found = old_file
M
Mark Hymers 已提交
2460
                    suite_type = x.location.archive_type
J
Various  
Joerg Jaspert 已提交
2461
                    # need this for updating dsc_files in install()
M
Mark Hymers 已提交
2462
                    dsc_entry["files id"] = x.file_id
2463
                    # See install() in process-accepted...
2464 2465 2466 2467 2468
                    if not orig_files.has_key(dsc_name):
                        orig_files[dsc_name] = {}
                    orig_files[dsc_name]["id"] = x.file_id
                    orig_files[dsc_name]["path"] = old_file
                    orig_files[dsc_name]["location"] = x.location.location_id
J
New.  
James Troup 已提交
2469
                else:
2470
                    # TODO: Record the queues and info in the DB so we don't hardcode all this crap
2471
                    # Not there? Check the queue directories...
2472
                    for directory in [ "Accepted", "New", "Byhand", "ProposedUpdates", "OldProposedUpdates", "Embargoed", "Unembargoed" ]:
M
Mark Hymers 已提交
2473 2474
                        if not Cnf.has_key("Dir::Queue::%s" % (directory)):
                            continue
M
Mark Hymers 已提交
2475
                        in_otherdir = os.path.join(Cnf["Dir::Queue::%s" % (directory)], dsc_name)
2476 2477 2478 2479 2480 2481
                        if os.path.exists(in_otherdir):
                            in_otherdir_fh = utils.open_file(in_otherdir)
                            actual_md5 = apt_pkg.md5sum(in_otherdir_fh)
                            in_otherdir_fh.close()
                            actual_size = os.stat(in_otherdir)[stat.ST_SIZE]
                            found = in_otherdir
2482 2483 2484
                            if not orig_files.has_key(dsc_name):
                                orig_files[dsc_name] = {}
                            orig_files[dsc_name]["path"] = in_otherdir
2485 2486

                    if not found:
2487
                        self.rejects.append("%s refers to %s, but I can't find it in the queue or in the pool." % (filename, dsc_name))
2488
                        continue
J
New.  
James Troup 已提交
2489
            else:
2490
                self.rejects.append("%s refers to %s, but I can't find it in the queue." % (filename, dsc_name))
2491
                continue
2492
            if actual_md5 != dsc_entry["md5sum"]:
2493
                self.rejects.append("md5sum for %s doesn't match %s." % (found, filename))
2494
            if actual_size != int(dsc_entry["size"]):
2495
                self.rejects.append("size for %s doesn't match %s." % (found, filename))
J
New.  
James Troup 已提交
2496

2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534
    ################################################################################
    # This is used by process-new and process-holding to recheck a changes file
    # at the time we're running.  It mainly wraps various other internal functions
    # and is similar to accepted_checks - these should probably be tidied up
    # and combined
    def recheck(self, session):
        cnf = Config()
        for f in self.pkg.files.keys():
            # The .orig.tar.gz can disappear out from under us is it's a
            # duplicate of one in the archive.
            if not self.pkg.files.has_key(f):
                continue

            entry = self.pkg.files[f]

            # Check that the source still exists
            if entry["type"] == "deb":
                source_version = entry["source version"]
                source_package = entry["source package"]
                if not self.pkg.changes["architecture"].has_key("source") \
                   and not source_exists(source_package, source_version, self.pkg.changes["distribution"].keys(), session):
                    source_epochless_version = re_no_epoch.sub('', source_version)
                    dsc_filename = "%s_%s.dsc" % (source_package, source_epochless_version)
                    found = False
                    for q in ["Accepted", "Embargoed", "Unembargoed", "Newstage"]:
                        if cnf.has_key("Dir::Queue::%s" % (q)):
                            if os.path.exists(cnf["Dir::Queue::%s" % (q)] + '/' + dsc_filename):
                                found = True
                    if not found:
                        self.rejects.append("no source found for %s %s (%s)." % (source_package, source_version, f))

            # Version and file overwrite checks
            if entry["type"] == "deb":
                self.check_binary_against_db(f, session)
            elif entry["type"] == "dsc":
                self.check_source_against_db(f, session)
                self.check_dsc_against_db(f, session)

M
Mark Hymers 已提交
2535
    ################################################################################
M
Mark Hymers 已提交
2536
    def accepted_checks(self, overwrite_checks, session):
M
Mark Hymers 已提交
2537 2538 2539 2540 2541 2542 2543 2544
        # Recheck anything that relies on the database; since that's not
        # frozen between accept and our run time when called from p-a.

        # overwrite_checks is set to False when installing to stable/oldstable

        propogate={}
        nopropogate={}

M
Mark Hymers 已提交
2545 2546 2547 2548 2549 2550
        # Find the .dsc (again)
        dsc_filename = None
        for f in self.pkg.files.keys():
            if self.pkg.files[f]["type"] == "dsc":
                dsc_filename = f

M
Mark Hymers 已提交
2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576
        for checkfile in self.pkg.files.keys():
            # The .orig.tar.gz can disappear out from under us is it's a
            # duplicate of one in the archive.
            if not self.pkg.files.has_key(checkfile):
                continue

            entry = self.pkg.files[checkfile]

            # Check that the source still exists
            if entry["type"] == "deb":
                source_version = entry["source version"]
                source_package = entry["source package"]
                if not self.pkg.changes["architecture"].has_key("source") \
                   and not source_exists(source_package, source_version,  self.pkg.changes["distribution"].keys()):
                    self.rejects.append("no source found for %s %s (%s)." % (source_package, source_version, checkfile))

            # Version and file overwrite checks
            if overwrite_checks:
                if entry["type"] == "deb":
                    self.check_binary_against_db(checkfile, session)
                elif entry["type"] == "dsc":
                    self.check_source_against_db(checkfile, session)
                    self.check_dsc_against_db(dsc_filename, session)

            # propogate in the case it is in the override tables:
            for suite in self.pkg.changes.get("propdistribution", {}).keys():
M
Mark Hymers 已提交
2577
                if self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), checkfile, session):
M
Mark Hymers 已提交
2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589
                    propogate[suite] = 1
                else:
                    nopropogate[suite] = 1

        for suite in propogate.keys():
            if suite in nopropogate:
                continue
            self.pkg.changes["distribution"][suite] = 1

        for checkfile in self.pkg.files.keys():
            # Check the package is still in the override tables
            for suite in self.pkg.changes["distribution"].keys():
M
Mark Hymers 已提交
2590
                if not self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), checkfile, session):
M
Mark Hymers 已提交
2591 2592 2593 2594 2595 2596 2597 2598 2599 2600
                    self.rejects.append("%s is NEW for %s." % (checkfile, suite))

    ################################################################################
    # This is not really a reject, but an unaccept, but since a) the code for
    # that is non-trivial (reopen bugs, unannounce etc.), b) this should be
    # extremely rare, for now we'll go with whining at our admin folks...

    def do_unaccept(self):
        cnf = Config()

M
Mark Hymers 已提交
2601
        self.update_subst()
M
Mark Hymers 已提交
2602 2603 2604
        self.Subst["__REJECTOR_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
        self.Subst["__REJECT_MESSAGE__"] = self.package_info()
        self.Subst["__CC__"] = "Cc: " + cnf["Dinstall::MyEmailAddress"]
J
Joerg Jaspert 已提交
2605
        self.Subst["__BCC__"] = "X-DAK: dak process-accepted"
M
Mark Hymers 已提交
2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631
        if cnf.has_key("Dinstall::Bcc"):
            self.Subst["__BCC__"] += "\nBcc: %s" % (cnf["Dinstall::Bcc"])

        template = os.path.join(cnf["Dir::Templates"], "process-accepted.unaccept")

        reject_mail_message = utils.TemplateSubst(self.Subst, template)

        # Write the rejection email out as the <foo>.reason file
        reason_filename = os.path.basename(self.pkg.changes_file[:-8]) + ".reason"
        reject_filename = os.path.join(cnf["Dir::Queue::Reject"], reason_filename)

        # If we fail here someone is probably trying to exploit the race
        # so let's just raise an exception ...
        if os.path.exists(reject_filename):
            os.unlink(reject_filename)

        fd = os.open(reject_filename, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0644)
        os.write(fd, reject_mail_message)
        os.close(fd)

        utils.send_mail(reject_mail_message)

        del self.Subst["__REJECTOR_ADDRESS__"]
        del self.Subst["__REJECT_MESSAGE__"]
        del self.Subst["__CC__"]

2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655
    ################################################################################
    # If any file of an upload has a recent mtime then chances are good
    # the file is still being uploaded.

    def upload_too_new(self):
        cnf = Config()
        too_new = False
        # Move back to the original directory to get accurate time stamps
        cwd = os.getcwd()
        os.chdir(self.pkg.directory)
        file_list = self.pkg.files.keys()
        file_list.extend(self.pkg.dsc_files.keys())
        file_list.append(self.pkg.changes_file)
        for f in file_list:
            try:
                last_modified = time.time()-os.path.getmtime(f)
                if last_modified < int(cnf["Dinstall::SkipTime"]):
                    too_new = True
                    break
            except:
                pass

        os.chdir(cwd)
        return too_new