Max Spring discovered a stack overflow in http://jenkins.361315.n4.nabble.com/channel-example-and-plugin-classes-gives-ClassNotFoundException-td3756092.html that pointed this call into thread context classloader (TCL) as the culprit. Independently, Paul Sandoz discovered the same issue in our products. If TCL is another classloader that delegates to UberClassLoader (UCL), this code causes infinite recursion.

And moreover, given the goal of UCL, it seems wrong that this class is changing behaviour based on contextual information like TCL.

 In looking at 4de81f1e, the change was introduced to make sure XStream unmarshalling invoked from Plugin.start() would see the classes in that plugin. This was an issue back then when plugins are prepared and loaded one by one, as UCL didn't have visibility into plugins being prepared. But in the current Jenkins, classloaders for all the plugins are prepared, before any plugin gets started, so by the time Plugin.start() runs, UCL is fully functioning.

 Therefore, there's no need to consult TCL for the purpose of resolving its own classes. I could have also removed the code that sets TCL, but because some libraries often depend on TCL and doesn't properly look at caller class, I'm leaving it in, even though it's generally a bad practice to rely on TCL in multi-classloader apps like Jenkins

We weren't actually enforcing the initialization order at all, as
sorting was based on the plugin name.

Just import changes, from hudson.model.Jenkins -> jenkins.model.Jenkins,
and Javadoc comments.
Signed-off-by: NNigel Magnay <nigel.magnay@gmail.com>

Signed-off-by: NNigel Magnay <nigel.magnay@gmail.com>

to be able to get in an other place (sure git could be better :-) )
some issue when using maven 2
some stuff to do more in maven 3 build (recording mojo execution etc...)



git-svn-id: https://hudson.dev.java.net/svn/hudson/branches/main-maven3-support@36643 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@36008 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@35980 71c3de6d-444a-0410-be80-ed276b4c234a

```-----
Merged revisions 32975,33588,33697,34342 via svnmerge from 
https://www.dev.java.net/svn/hudson/branches/downgrade
```

.....
  r32975 | kohsuke | 2010-07-16 21:27:59 +0200 (Fri, 16 Jul 2010) | 1 line
  
  committed my partially modified version
........
  r33588 | dienomight | 2010-08-05 09:42:36 +0200 (Thu, 05 Aug 2010) | 13 lines
  
  Added getBackupVersion (UpdateCenter)
  downgrade button now shows version of backup war file
  
  Added HudsonDowngradeJob (UpdateCenter)
  downgrading process is works now as HudsonUpgradeJob
  
  Changed rewriteHudsonWar (Lifecycle) 
  backup file is deleted when downgrading
  
  hudson/model/Hudson/downgrade_success.jelly is no longer necessary
  
  Changed rewriteHudsonWar(WindowsServiceLifecycle)
  hudson run as windows service creates backup during upgrading
........
  r33697 | dienomight | 2010-08-11 17:09:48 +0200 (Wed, 11 Aug 2010) | 8 lines
  
  committed changes:
  "plugins downgrade functionality"
  added: 
  * PluginDowngradeJob in UpdateCenter
  * getCanDowngrade & getBackupPath & getBackupVersion in PluginWrapper
  * additional "previous version" column in installed.jelly (PluginManager) with downgrade button (when it's possible to downgrade)
  * doDowngrade in PluginManager
  * deployBackup in UpdateSite
........
  r34342 | dienomight | 2010-09-03 09:52:13 +0200 (Fri, 03 Sep 2010) | 12 lines
  
  Code improvements: 
  jelly files:
  *I put text inside ${%} so it would be available for translation.
  UpdateCenter: 
  *changed getCanDowngrade to isDowngradable
  *getBackupVersion use JarFile class to get version of .war backup
  PluginWrapper:
  *changed getBackupPath to getBackupFile
  *getBackupVersion use JarFile class to get version of plugin backup
  PluginManager:
  *changed condition in doDowngrade method
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@34543 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32004 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31831 71c3de6d-444a-0410-be80-ed276b4c234a

- click category heading on Available tab to show/hide plugins in that category
- add initial sort for plugins on Installed tab
- no mouseover bgcolor for Advanced tab


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31819 71c3de6d-444a-0410-be80-ed276b4c234a

to avoid possible ConcurrentModificationException when optional dependencies are
being processed in PLUGINS_LISTED phase.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31481 71c3de6d-444a-0410-be80-ed276b4c234a

when submitting proxy settings.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30454 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30070 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29641 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26636 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25682 71c3de6d-444a-0410-be80-ed276b4c234a

Merged revisions 23666-23667,23670,23711,23782-23785,23788,23809-23810,23817,23859,23870,23879,23899-23904,23906-23907,23909,23913 via svnmerge from 
https://www.dev.java.net/svn/hudson/branches/managed-startup

........
  r23666 | kohsuke | 2009-11-11 15:56:46 -0800 (Wed, 11 Nov 2009) | 1 line
  
  Reworked the initialization logic
........
  r23667 | kohsuke | 2009-11-11 16:01:56 -0800 (Wed, 11 Nov 2009) | 1 line
  
  fixed a failing test
........
  r23670 | kohsuke | 2009-11-11 16:42:32 -0800 (Wed, 11 Nov 2009) | 1 line
  
  use a non-snapshot
........
  r23711 | kohsuke | 2009-11-13 14:27:28 -0800 (Fri, 13 Nov 2009) | 1 line
  
  Session -> Reactor
........
  r23782 | kohsuke | 2009-11-17 10:35:14 -0800 (Tue, 17 Nov 2009) | 1 line
  
  Poorman's clone of JDK6 ServiceLoader.
........
  r23783 | kohsuke | 2009-11-17 10:56:25 -0800 (Tue, 17 Nov 2009) | 1 line
  
  Integrated the fatal support so that all errors are sent to the listener.
........
  r23784 | kohsuke | 2009-11-17 10:58:07 -0800 (Tue, 17 Nov 2009) | 1 line
  
  with the new reactor initialization, things are getting too verbose
........
  r23785 | kohsuke | 2009-11-17 11:18:45 -0800 (Tue, 17 Nov 2009) | 1 line
  
  failing to load jobs are non-fatal, too
........
  r23788 | kohsuke | 2009-11-17 13:18:59 -0800 (Tue, 17 Nov 2009) | 1 line
  
  logging the exception properly
........
  r23809 | kohsuke | 2009-11-17 18:45:47 -0800 (Tue, 17 Nov 2009) | 1 line
  
  releasing 1.1 as milestone
........
  r23810 | kohsuke | 2009-11-17 18:47:37 -0800 (Tue, 17 Nov 2009) | 2 lines
  
  - use a better idiom for building a sequence
  - use null display name to signify internal book-keeping tasks that's not worth displaying
........
  r23817 | kohsuke | 2009-11-18 07:54:17 -0800 (Wed, 18 Nov 2009) | 1 line
  
  removed accidental JDK6 dependency.
........
  r23859 | kohsuke | 2009-11-19 11:03:28 -0800 (Thu, 19 Nov 2009) | 1 line
  
  introducing the strategy pattern to hook into key decision making points during the start up
........
  r23870 | kohsuke | 2009-11-19 14:33:07 -0800 (Thu, 19 Nov 2009) | 1 line
  
  bug fix. These steps add additional tasks to the reactor, so they need to also prevent future milestones from getting attained.
........
  r23879 | kohsuke | 2009-11-19 16:54:59 -0800 (Thu, 19 Nov 2009) | 1 line
  
  moved the logic to the strategy.
........
  r23899 | kohsuke | 2009-11-20 09:32:13 -0800 (Fri, 20 Nov 2009) | 1 line
  
  handle duplicate plugins better
........
  r23900 | kohsuke | 2009-11-20 10:06:42 -0800 (Fri, 20 Nov 2009) | 1 line
  
  support pre-exploded plugin
........
  r23901 | kohsuke | 2009-11-20 10:49:04 -0800 (Fri, 20 Nov 2009) | 1 line
  
  making it a subtype
........
  r23902 | kohsuke | 2009-11-20 10:54:42 -0800 (Fri, 20 Nov 2009) | 1 line
  
  allow InitStrategy to skip some tasks
........
  r23903 | kohsuke | 2009-11-20 11:03:38 -0800 (Fri, 20 Nov 2009) | 1 line
  
  doc improvement.
........
  r23904 | kohsuke | 2009-11-20 11:03:49 -0800 (Fri, 20 Nov 2009) | 1 line
  
  no need to throw exceptions
........
  r23906 | kohsuke | 2009-11-20 11:17:34 -0800 (Fri, 20 Nov 2009) | 1 line
  
  debug switch to disable the automatic launch of slaves
........
  r23907 | kohsuke | 2009-11-20 11:25:15 -0800 (Fri, 20 Nov 2009) | 1 line
  
  added a magic object for cancelling all saves
........
  r23909 | kohsuke | 2009-11-20 11:29:53 -0800 (Fri, 20 Nov 2009) | 1 line
  
  moving initialization up
........
  r23913 | kohsuke | 2009-11-20 13:32:08 -0800 (Fri, 20 Nov 2009) | 1 line
  
  seeing heap space problem during tests
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23992 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23340 71c3de6d-444a-0410-be80-ed276b4c234a

https://www.dev.java.net/svn/hudson/branches/multiple-update-sources

........
  r23183 | abayer | 2009-10-25 11:53:17 -0700 (Sun, 25 Oct 2009) | 1 line
  
  First chunk of work towards supporting multiple update centers - infrastructure in place for it, and default update center treated as only one of multiple - have to use slightly modified update-center.json though
........
  r23185 | abayer | 2009-10-25 12:25:49 -0700 (Sun, 25 Oct 2009) | 1 line
  
  a number of tweaks - among other things, now works properly with additional update centers defined in hudson.model.UpdateCenter.xml - try using http://andrewbayer.com/images/hello-world/helloWorld-update-center.json as second update center
........
  r23245 | abayer | 2009-10-27 13:45:25 -0700 (Tue, 27 Oct 2009) | 1 line
  
  Modified to support existing default update-center.json
........
  r23256 | kohsuke | 2009-10-27 18:30:15 -0700 (Tue, 27 Oct 2009) | 7 lines
  
  - moved data binding of update-center.json to UpdateSource.
  - moved some of the UpdateSource property into JSON, to improve the user experience when adding an update source.
    the user should just type in one URL, and everything else should happen automatically.
  - it doesn't make sense for UpdateSource to rely on UpdateCenterConfiguration, since behaviors cannot be
    modified per UpdateSource basis. Instead, leaving it in UpdateCenter allows us to maintain backward compatible
    behaviors with the existing custom UpdateCenterConfiguration implementation.
........
  r23266 | kohsuke | 2009-10-27 19:29:24 -0700 (Tue, 27 Oct 2009) | 1 line
  
  serve id inside JSON.
........
  r23279 | kohsuke | 2009-10-28 10:44:00 -0700 (Wed, 28 Oct 2009) | 1 line
  
  Do not special-case "default" ID. Receive hudson.war updates from wherever that provides one.
........
  r23280 | kohsuke | 2009-10-28 10:50:57 -0700 (Wed, 28 Oct 2009) | 1 line
  
  formatting change.
........
  r23281 | kohsuke | 2009-10-28 11:30:40 -0700 (Wed, 28 Oct 2009) | 1 line
  
  typo
........
  r23282 | kohsuke | 2009-10-28 11:45:06 -0700 (Wed, 28 Oct 2009) | 2 lines
  
  - added the UI to remove sites.
  - persistence of UpdateSource happens more automatically now.
........
  r23283 | kohsuke | 2009-10-28 11:50:04 -0700 (Wed, 28 Oct 2009) | 1 line
  
  UpdateSource -> UpdateSite to align terminology with Eclipse.
........
  r23284 | kohsuke | 2009-10-28 11:55:03 -0700 (Wed, 28 Oct 2009) | 5 lines
  
  Actually, for now, just having a programmatic modification to UpdateSite would satisfy the primary use case.
  
  And I'd like to upgrade YUI to a more recent version so that we can use its DataTable for UI. Plus the single update center model encourages the community to bring the code into the Hudson project, which is something we'd like to keep.
  
  So all in all, I'm postponing the UI work.
........
  r23286 | kohsuke | 2009-10-28 13:07:19 -0700 (Wed, 28 Oct 2009) | 1 line
  
  Renaming and bug fixes.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23326 71c3de6d-444a-0410-be80-ed276b4c234a

Hudson APIs: tasks.Shell, model.Hudson, model.*LoadStatistics,
             slaves.ConnecationActivityMonitor, PluginManager
XStream APIs: util.CopyOnWriteList, util.Robust*Converter, model.Result,
              model.BuildAuthorizationToken, model.Fingerprint
Stapler APIs: diagnosis.HudsonHomeDiskUsageMonitor, os.solaris.ZFSInstaller
args4j APIs: model.Job, cli.GroovyCommand, cli.handlers.*


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23277 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21977 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21776 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@20684 71c3de6d-444a-0410-be80-ed276b4c234a

Merged revisions 19665-19668,19675-19677,19683-19684,19692-19696,19701,19706-19708,19716-19722,19730,19737,19802-19803 via svnmerge from 
https://www.dev.java.net/svn/hudson/branches/rc

........
  r19665 | kohsuke | 2009-07-13 10:48:59 -0700 (Mon, 13 Jul 2009) | 1 line
  
  merged the RC branch back. This time I saw a lot of strange merge failures. Is svnmerge interfering with Subversion 1.6 somehow?
........
  r19666 | kohsuke | 2009-07-13 10:58:37 -0700 (Mon, 13 Jul 2009) | 1 line
  
  fixed a compilation problem
........
  r19667 | kohsuke | 2009-07-13 11:51:29 -0700 (Mon, 13 Jul 2009) | 1 line
  
  The default view is now configurable.
........
  r19668 | kohsuke | 2009-07-13 12:20:49 -0700 (Mon, 13 Jul 2009) | 1 line
  
  added a reference to a typical way of creating a Launcher
........
  r19675 | kohsuke | 2009-07-13 18:58:37 -0700 (Mon, 13 Jul 2009) | 1 line
  
  doc improvement.
........
  r19676 | kohsuke | 2009-07-13 18:58:59 -0700 (Mon, 13 Jul 2009) | 1 line
  
  this makes it easier for me to discover the related tests
........
  r19677 | kohsuke | 2009-07-13 19:02:23 -0700 (Mon, 13 Jul 2009) | 3 lines
  
      Fixed a bug in Winstone that may result in "unable to create new native thread" error
      (<a href="http://www.nabble.com/OutOfMemoryError-on-all-jobs-after-a-while-td24408800.html">report</a>)
........
  r19683 | kohsuke | 2009-07-13 20:55:43 -0700 (Mon, 13 Jul 2009) | 1 line
  
  [FIXED HUDSON-1920] Applied a patch. In 1.316.
........
  r19684 | kohsuke | 2009-07-13 21:17:00 -0700 (Mon, 13 Jul 2009) | 1 line
  
  bumped up to 0.8 to fix IE7 rendering problem
........
  r19692 | kohsuke | 2009-07-14 10:22:18 -0700 (Tue, 14 Jul 2009) | 1 line
  
  added an icon for plugins
........
  r19693 | kohsuke | 2009-07-14 10:22:32 -0700 (Tue, 14 Jul 2009) | 1 line
  
  forgot to commit this file
........
  r19694 | kohsuke | 2009-07-14 10:31:12 -0700 (Tue, 14 Jul 2009) | 1 line
  
  replaced the icon
........
  r19695 | kohsuke | 2009-07-14 10:38:17 -0700 (Tue, 14 Jul 2009) | 3 lines
  
      Tentatively added additional extension points to control queue behaviors.
      (<a href="http://www.nabble.com/Queue-handling-contribution-td24322512.html">patch</a>)
........
  r19696 | kohsuke | 2009-07-14 11:48:03 -0700 (Tue, 14 Jul 2009) | 3 lines
  
      Fixed a possible NPEs with the slavestatus plugin.
      (<a href="http://www.nabble.com/Hudson-throws-NPE-after-upgrade-to-1.1315-td24476619.html">report</a>)
........
  r19701 | kohsuke | 2009-07-14 14:33:15 -0700 (Tue, 14 Jul 2009) | 1 line
  
  cherry picking from rev.19592.
........
  r19706 | kohsuke | 2009-07-14 17:03:13 -0700 (Tue, 14 Jul 2009) | 1 line
  
  fixed possible NPE
........
  r19707 | kohsuke | 2009-07-14 17:03:37 -0700 (Tue, 14 Jul 2009) | 1 line
  
  doc fix
........
  r19708 | kohsuke | 2009-07-14 17:41:37 -0700 (Tue, 14 Jul 2009) | 1 line
  
  improved error diagnostics
........
  r19716 | kohsuke | 2009-07-14 18:58:46 -0700 (Tue, 14 Jul 2009) | 3 lines
  
      Fixed a possible StringIndexOutOfBoundsException with Windows process execution.
      (<a href="https://hudson.dev.java.net/issues/show_bug.cgi?id=4034">issue 4034</a>)
........
  r19717 | mindless | 2009-07-14 19:01:52 -0700 (Tue, 14 Jul 2009) | 2 lines
  
  [FIXED HUDSON-4011] translation correction from flominator
........
  r19718 | kohsuke | 2009-07-14 19:02:24 -0700 (Tue, 14 Jul 2009) | 1 line
  
  [FIXED HUDSON-4032] Fixed in 1.316.
........
  r19719 | kohsuke | 2009-07-14 19:09:23 -0700 (Tue, 14 Jul 2009) | 1 line
  
  [HUDSON-3984] Added logging.
........
  r19720 | kohsuke | 2009-07-14 19:12:19 -0700 (Tue, 14 Jul 2009) | 1 line
  
  [HUDSON-3984] Added logging.
........
  r19721 | kohsuke | 2009-07-14 19:14:40 -0700 (Tue, 14 Jul 2009) | 1 line
  
  [HUDSON-3984] Added logging.
........
  r19722 | kohsuke | 2009-07-14 20:14:34 -0700 (Tue, 14 Jul 2009) | 1 line
  
  modernized.
........
  r19730 | kohsuke | 2009-07-15 11:49:16 -0700 (Wed, 15 Jul 2009) | 1 line
  
  [FIXED HUDSON-3803] In 1.316.
........
  r19737 | kohsuke | 2009-07-15 12:44:53 -0700 (Wed, 15 Jul 2009) | 1 line
  
  creating a new RC branch
........
  r19802 | kohsuke | 2009-07-16 19:22:06 -0700 (Thu, 16 Jul 2009) | 3 lines
  
  resurrected URLClassLoader code and made that a default after Tom reported a performance problem during a start up, caused by repeated attempt to load a non-existent class.
  
  Our current theory is that the AntClassLoader.getResourceStream(...) does repeated file system stat calls, and we suspect that is slow on NTFS. Caching a failure should help boost the performance.
........
  r19803 | kohsuke | 2009-07-16 19:31:41 -0700 (Thu, 16 Jul 2009) | 3 lines
  
                  // see http://www.nabble.com/404-Not-Found-error-when-clicking-on-help-td24508544.html
                  // I suspect some containers are returning directory names.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19805 71c3de6d-444a-0410-be80-ed276b4c234a

Using AntClassLoader with Closeable so that we can predictably release jar files opened by URLClassLoader

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19472 71c3de6d-444a-0410-be80-ed276b4c234a

I want the Plugin.postInitialize() to see all the other plugins, namely PluginManager.uberClassLoader.

So this code needs to be in a separate method.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@17125 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@17122 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16922 71c3de6d-444a-0410-be80-ed276b4c234a