removed some redundant constructs and replaced stringbuilder operations with too few arguments with string concatenation

* set HttpOnly flag to prevent cookie read by a malicious script in browser

* Update core/src/main/java/hudson/Functions.java
Co-Authored-By: NWadeck Follonier <Wadeck@users.noreply.github.com>

* Move cloud configuration out of Configure System

* Update display name

* Add section header back

* Rejuvenate log levels

* clean up

* Reverting the plugin download
Co-Authored-By: NOleg Nenashev <o.v.nenashev@gmail.com>

JENKINS-56553 Make proxy config compatible with JCasC without workarounds on the plugin side (#3935)

* JENKINS-56553 Make proxy config compatible with JCASC

* Use DataBoundSetters as other fields are optional

* Fix Jelly for ProxyConfiguration

* Use default field name now that field matches

* Fix validate proxy

* Change field type

* After review

* Update core/src/main/java/jenkins/model/Jenkins.java
Co-Authored-By: Ntimja <t.jacomb@kainos.com>

* Update core/src/main/java/jenkins/model/Jenkins.java
Co-Authored-By: Ntimja <t.jacomb@kainos.com>

* Update core/src/main/java/hudson/ProxyConfiguration.java
Co-Authored-By: Ntimja <t.jacomb@kainos.com>

* Update core/src/main/java/jenkins/model/Jenkins.java
Co-Authored-By: Ntimja <t.jacomb@kainos.com>

* Update core/src/main/java/jenkins/model/Jenkins.java
Co-Authored-By: Ntimja <t.jacomb@kainos.com>

* Update core/src/main/java/hudson/ProxyConfiguration.java
Co-Authored-By: NOleg Nenashev <o.v.nenashev@gmail.com>

* Tweak javadoc

* Align fields

* Update core/src/main/java/hudson/ProxyConfiguration.java
Co-Authored-By: NAdrien Lecharpentier <adrien.lecharpentier@gmail.com>

* JENKINS-6722 Show slave error status on Dashboard

* Update executors.properties

Add StandardOpenOption.CREATE flag to create FileChannelWriter to avoid full fs flush and 5sec log operation on creating empty file with CephFS as a storage

* Hide password form fields by default

* Trying to bypass enforced autocompletion by just having a test field at first

Something like onfocus didn't work, you'd tab through form elements
and unless you filled in the user name, changing the form field to
password would cause it to autocomplete.

It looks like, at least in Mac/Firefox, going from plain text to password
in the 'oninput' event handler works. The plain text is revealed neither
with typing nor pasting.

* Update core/src/main/resources/lib/form/password.jelly
Co-Authored-By: Ndaniel-beck <daniel-beck@users.noreply.github.com>

* Use previously defined value

* Make new password form fields opt-out

* Add support for redacting form secrets in new password field

* Have a password value pre-set in Jelly

* Fix method

* Fix test by clicking on the button to change the password

* Forgot period separator between class and property name

[JENKINS-59665] - Fix sorting of the Uninstall column in the Install pane of the Plugin Manager  (#4298)

* refs #JENKINS-59665 Fixed sorting for uninstall column of installed in plugin manager

* refs #JENKINS-59665 removed test attribute

The jenkins-slave.xml file has been copied to the windows-slave-installer-module,
but a unused (old) copy is still present in the jenkins core.

* Try to execute flyweight tasks on the master

* Fix offline behavior, add tests

* Remove obsolete TODOs, also check #isAcceptingTasks

This exception occurs while defining a view using job DSL:

    SEVERE  jenkins.InitReactorRunner$1#onTaskFailed: Failed ConfigurationAsCode.init
    java.lang.ArrayIndexOutOfBoundsException: 0
        at java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:388)
        at java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:397)
        at hudson.model.ViewGroupMixIn.getPrimaryView(ViewGroupMixIn.java:172)
        at hudson.model.ViewGroupMixIn.getView(ViewGroupMixIn.java:134)
        at jenkins.model.Jenkins.getView(Jenkins.java:1834)
        at javaposse.jobdsl.plugin.JenkinsJobManagement.createOrUpdateView(JenkinsJobManagement.java:175)
        at javaposse.jobdsl.dsl.JobManagement$createOrUpdateView$2.call(Unknown Source)
        at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:141)
        at javaposse.jobdsl.dsl.AbstractDslScriptLoader$_extractGeneratedViews_closure5.doCall(AbstractDslScriptLoader.groovy:216)

Co-authored-by: NStephen Connolly <stephen.alan.connolly@gmail.com>

* IntelliJ/Java: Duplicate code -- Refactored as DOSToUnixPathHelper.validate

* Change DOSToUnixPathHelper from validate() to iteratePath()

* Refactor DOSToUnixPathHelper checkPrefix

* mark DOSToUnixPathHelper as NoExternalUse

* Do not tempt fate
Co-Authored-By: NDaniel Beck <1831569+daniel-beck@users.noreply.github.com>

* Use plugin URL from the update site rather than the manifest

* Avoid Mockito when not needed

* Resolve plugin URL from multiple update sites

[JENKINS-59886] Strengthen the queue to avoid canTake and canRun implementers hanging the queue (#4311)

* [JENKINS-59886] Strengthen the queue to avoid canTake and canRun implementers hanging it

* [JENKINS-59886] Messages on iso-8859-1

* [JENKINS-59886] Messages on iso-8859-1

* [JENKINS-59886] lower case on properties

* [JENKINS-59886] trailing empty blanks

* [JENKINS-59886] Double single-quotes

* [JENKINS-59886] Don't sleep in the loop maintaining the queue

* [JENKINS-59886] Add class suffix, wait to just the start of the build

* [JENKINS-59886] Assert clearly there is only one job in the queue

* [JENKINS-59886] Uncomment fix

* [JENKINS-59886] Remove old comment

* [JENKINS-59886] Remove log messages from property files

* [JENKINS-59886] Remove UTF8 characters from es messages

* Minor improvements to the logging UI

* Fix URL