1. 07 6月, 2016 1 次提交
  2. 12 5月, 2016 1 次提交
  3. 09 3月, 2016 2 次提交
    • S
      Jenkins.getInstance() will be @Nonnull in Jenkins 2.0+ · 96150d3a
      Stephen Connolly 提交于
      - Code that is running from a plugin and on the master's JVM is guaranteed to never get null from this method (any cases where you do get null are bugs in core)
      - Code that is running from a plugin and on a remote JVM should never be allowed to load the Jenkins class in their classloader, so should never use Jenkins.getInstance()... we are annotating the method with @Nullable so that such code can have some evolution time
      - Code that is running in core and on one of two special paths should use the Jenkins.getInstanceOrNull() method so that the UI can be presented to users before the singleton has been instantiated / after the singleton has been destroyed
      - The remaining 95% of uses in core (and 100% of uses in plugins) can safely assume that the instance is never null
      96150d3a
    • S
      Revert "Jenkins.getInstance() should be non-null" · d1dfbd2b
      Stephen Connolly 提交于
      This reverts commit bb7c8fce.
      
      Closes #2090, I'll redo this as a PR... though if that PR is subject to multiple rounds of review before being merged then I will take that of evidence of the exact problem that committing directly was supposed to resolve... namely exponentially multiplying the effort required to make actual improvements to the code base.
      d1dfbd2b
  4. 08 3月, 2016 2 次提交
    • S
      Jenkins.getInstance() is safe to assume non-null · 16eb3487
      Stephen Connolly 提交于
      - Only ever called after extensions are on the classpath and before termination
      16eb3487
    • S
      Jenkins.getInstance() should be non-null · bb7c8fce
      Stephen Connolly 提交于
      - It is never too late to do the right thing.
      - The vast majority of usages of `Jenkins.getInstance()` in core currently assume that its return value is non-null
      - This commit changes those that are written to correctly check for non-null values will call `Jenkins.getInstanceOrNull()`
      - We deprecate the `Jenkins.getActiveInstance()` madness
      - I checked with @kohsuke who said not to bother with a PR and just commit this strongly opinionated change direct to master as a PR will just degrade into a bikeshedding.
      bb7c8fce
  5. 30 1月, 2016 1 次提交
  6. 19 11月, 2015 1 次提交
  7. 17 11月, 2015 1 次提交
  8. 10 11月, 2015 1 次提交
    • C
      remove unused import statements · 7efb9090
      Christopher Simons 提交于
      In addition to cluttering the namespace, unused imports generate
      compiler warnings, introducing noise and obscuring more important
      compiler warnings.  This change removes them.
      7efb9090
  9. 05 10月, 2015 1 次提交
  10. 03 10月, 2015 1 次提交
  11. 07 7月, 2015 1 次提交
  12. 10 6月, 2015 1 次提交
  13. 09 6月, 2015 1 次提交
  14. 20 4月, 2015 1 次提交
  15. 15 4月, 2015 1 次提交
  16. 30 3月, 2015 1 次提交
  17. 27 3月, 2015 1 次提交
  18. 26 3月, 2015 2 次提交
  19. 20 3月, 2015 1 次提交
  20. 24 2月, 2015 2 次提交
  21. 20 2月, 2015 1 次提交
  22. 05 2月, 2015 1 次提交
  23. 01 2月, 2015 1 次提交
  24. 30 1月, 2015 1 次提交
  25. 19 11月, 2014 1 次提交
  26. 29 10月, 2014 1 次提交
    • J
      fromExternalizableId should just return null, not throw IAE, if the job has... · 4cb7414e
      Jesse Glick 提交于
      fromExternalizableId should just return null, not throw IAE, if the job has since been renamed/move/deleted.
      (It could already return null if the run has since been deleted; #1264 failed to mark this properly.)
      Reserving IAE for inputs that getExternalizableId could not actually have produced,
      and making sure to also throw this in case of non-numeric text after the hash.
      Adding Javadoc for both methods.
      4cb7414e
  27. 07 10月, 2014 1 次提交
    • J
      Better robustness when action loading fails. · f8146742
      Jesse Glick 提交于
      For example, the following should not cause Run.onLoad itself to fail:
      java.lang.NullPointerException
      	at org.jenkinsci.plugins.workflow.steps.input.InputAction.onLoad(InputAction.java:29)
      	at hudson.model.Run.onLoad(Run.java:342)
      	at org.jenkinsci.plugins.workflow.job.WorkflowRun.onLoad(WorkflowRun.java:332)
      f8146742
  28. 24 9月, 2014 1 次提交
  29. 28 8月, 2014 5 次提交
  30. 27 8月, 2014 1 次提交
    • J
      Fixed compatibility with MatrixRun. · c0d48fc1
      Jesse Glick 提交于
      The Run constructors taking a timestamp must not be deprecated.
      And the root directory must be created in RunMap.put, not the constructor,
      in case the number (and hence directory name) is changed after the constructor completes.
      c0d48fc1
  31. 22 8月, 2014 1 次提交
  32. 05 8月, 2014 1 次提交