[JENKINS-36720] - Fix Spotbugs issues (SE_COMPARATOR_SHOULD_BE_SERIALIZABLE, ES_COMPARING_STRINGS_WITH_EQ) (#4379)

* fixed Spotbugs issues (SE_COMPARATOR_SHOULD_BE_SERIALIZABLE, ES_COMPARING_STRINGS_WITH_EQ)

* replaced wildcard import with specific imports

* added missing import

* fixed spotbugs issues

* removed accidently added import

[JENKINS-56152] Improve plugin manager UI wording + [JENKINS-56173] - Fix JavaScript error in Plugin Manager when optional dependency metadata cannot be retrieved (#3904)

* [JENKINS-56173] Uncaught TypeError: Cannot read property 'jenkinsPluginMetadata' of undefined

* [JENKINS-56173] missing dependencies covers both not installed and not enabled

* [JENKINS-56152] i18n: DirectlyDependentPlugins.title / IndirectlyDependentPlugins.title

* [JENKINS-56152] replace `version X` with `(X)`

* [JENKINS-56152] simplify messages; replace `version X` with `(X)`; use higher instead of later

* [JENKINS-56173] Uncaught Exception: TypeError: Cannot read property 'get' of undefined at _createResponder

* Update PluginWrapperTest

* Switch to descriptive class for plugin version

* Updated EnvVars to add a method that extends putAll functionality

* Updated method name

* Added test coverage

[JENKINS-60579] - Allow the usage of DescriptorVisibilityFilter to filter View properties on UI. (#4404)

* [JENKINS-60579] Functionnal test on View that shows the issue for invisible properties.

* [JENKINS-60579] Apply the visibility filter on View for configuration.

* [JENKINS-60579] Better configuration for testing on invisible property on view.

* [JENKINS-60579] Move tests on ViewPropertyTest.

* [JENKINS-60579]adding the since on getVisiblePropertyDescriptors.

- trailing spaces ` ` after backslash `\` for multi-line entries
- missing backslash `\` for multi-line entries
- missing escaping of the key/value separator colon `:` when used literally
- missing key/value separator `=`
- duplicate entries
- extra content without a key

Add the original `blurb` entry back with the "slave" term changed to "agente".

Part of the entry was removed in commit 05a29896,
leaving an invalid multi-line entry behind.

The errors 681-1023 are missing in this file.

It looks like left-behind from commit cf9034fe.

* removed redundnat null checks of nonnull values

* integrated suggestions

* removed local jenkins variable as suggested

* replaced null check with check for error object

* IntelliJ/Java: Duplicate declaration

AntClassLoader.getUrl

* Add missing import for annotation

* Switch from Vector to ArrayList<File>

* Drop inferable File

* Use for (File pathComponent : pathComponents) sugar

* Accept generic container type for getUrl
Co-Authored-By: NOleg Nenashev <o.v.nenashev@gmail.com>
Co-authored-by: NOleg Nenashev <o.v.nenashev@gmail.com>

* Add new module optional-depender and a new failing test

* Variant plugin is a dependency of optional-depender

Optional-depender contains the following class

@OptionalExtension(requirePlugins = {"dependee"})
public class OptionalDependerExtension {
      private static void foo(Dependee d) {

      }
}

* [JENKINS-60449] Move plugin initialization at the end, keep only one extension refresh

* Improve logic to detect classloading issues

Inspect all declared constructors/methods/fields recursively to exclude
failing classes from Guice rather than have Guice explode.

This also fix the failing test, but the previous commit is still better
because it avoids an extra Jenkins.get().refreshExtensions() call.

* Only test resolveClass method if the classloader is not the bootstrap one

Co-Authored-By: NDaniel Beck <1831569+daniel-beck@users.noreply.github.com>

Remove anything unnecessary. Move SLAVE_SECRET to JnlpAgentReceiver
and alias it for existing usages.

set spotbugs URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD to ignore because reads are not detectable by spotbugs

* [JENKINS-21311] Make the queue/cancelItem API an API.

This change:
* documents the API
* adds meaningful return codes to help API caller.

* [JENKINS-21311] Code review

* [JENKINS-21311] Update failing integration test

* [JENKINS-36720]: Fixed Spotbugs issues WMI_WRONG_MAP_ITERATOR and OS_OPEN_STREAM in core

* merged try with resources with try finally

* reverted auto format from IDE

* reverted auto format from IDE

* use Util.fileToPath() as suggested to remove catch block

* merged try statements

* merged try statements

* reverted some whitespace fixes

* reverted another whitespace fix

* Apply suggestions from code review
Co-Authored-By: NOleg Nenashev <o.v.nenashev@gmail.com>

* reverted change

* reverted change

* reverted change
Co-authored-by: NOleg Nenashev <o.v.nenashev@gmail.com>

* replaced implementation with call to Integer.compare or Long.compare

* Update core/src/main/java/hudson/model/HealthReport.java
Co-Authored-By: NZbynek Konecny <zbynek1729@gmail.com>

* mark compare methods as deprecated
Co-authored-by: NZbynek Konecny <zbynek1729@gmail.com>

* JENKINS-60513: Added AtomicInteger to whitelist

* JENKINS-60513: Mark field as transient

* reverted whitelist change

* renamed field to support deserialization of ols values

* refactor exception to actually put the failing string inside instead of null

* do not catch RuntimeExceptions

[JENKINS-60351] - Make it possible to disable multiple deletion attempts by setting hudson.Util.maxFileDeletionRetries to zero (#4382)

* [JENKINS-60351] It should be possible to disable a retry of the
PathRemover

This does not address the issues that the comments and code in
hudons.Util are inconsistent if they are for retries or total number of
attempts (they are currently total number of attempts)

* [JENKINS-60351] Make the code conform to the documentation

maxRetries should control the number of retries not the number of
attempts.

* rename field from DELETION_MAX to DELETION_RETRIES

This fixes a regression introduced in SECURITY-901 where performing an authentication check on another user while logged in caused the user to get logged out.
Signed-off-by: NMatt Sicker <boards@gmail.com>

* replaced integer with AtomicInteger to fix spotbugs issue

* added @Restricted to prevent further usage

* replaced volatile with final because of AtomicInteger usage

* implemented a getter and an increment method

* fixed typeo in javadoc

* [JENKINS-59656] when stopping a Run via the executors widget, make sure it's the intended one

* [JENKINS-59656] added Executor.stopBuild(String) instead of .stop(String)

* revert change to deprecated doStop(StaplerRequest,StaplerResponse), useless now that it's doStopBuild(String) which takes a runExtId parameter

* javadoc: "@since TODO" rather than "@since 2.???"

* [JENKINS-59656] added test case

* jelly cleanup with h.urlEncode(String)

* make Functions.urlEncode(null) return empty String

* Executor.doStopBuild(runExtId): ignore runExtId if executable is not a Run

* Executor.doStopBuild(runExtId) doesn't have to be a public API