1. 22 7月, 2014 6 次提交
  2. 21 7月, 2014 3 次提交
  3. 19 7月, 2014 1 次提交
  4. 18 7月, 2014 1 次提交
    • T
      IE compatibility mode tweaks · de6ea1ab
      tfennelly 提交于
      Set "X-UA-Compatible" meta tag (MSIE browsers only - forces browser compatibility mode)
      JS based warning if Document Mode doesn't match IE version (MSIE browsers only)
      de6ea1ab
  5. 16 7月, 2014 6 次提交
  6. 15 7月, 2014 4 次提交
  7. 14 7月, 2014 5 次提交
  8. 13 7月, 2014 2 次提交
  9. 12 7月, 2014 6 次提交
    • K
      [ZD-19640] diagnostic improvement in case impersonation failed. · 38ab6192
      Kohsuke Kawaguchi 提交于
      I think this is an oversight in bded790f. A random attacker wouldn't know the correct API token value,
      so given that it matched, I think the caller should know that it was the impersonation that failed, not the authentication.
      
      Also log this at a higher level, since this indicates a problem in SecurityRealm.
      38ab6192
    • J
      [JENKINS-18065] Uncommenting original test. · 2f58ceb1
      Jesse Glick 提交于
      The actual implementation does not behave as nicely as one would hope, for a few reasons:
      1. isEmpty actually tries to load the newestBuild, rather than simply checking whether there is some idOnDisk.
         Arguably this is necessary, since there could be an unloadable build record, in which case it would be technically correct for the map to be considered empty.
      2. Loading AbstractLazyLoadRunMap.newestBuild calls search(MAX_VALUE, DESC), which behaves oddly, by doing a binary search, and thus perhaps loading lg(|map|) entries.
         You would think that it would suffice to check for the last member of idOnDisk in index.byId.
      3. The iterator eagerly loads the next value before hasNext has even been called.
         Looks bad in a test, though it probably has little practical impact since most callers would be calling hasNext soon afterward anyway.
         Might cause one extra build record to be loaded unnecessarily from a limited RunList.
      2f58ceb1
    • J
      [JENKINS-18065] 54c08461 amendment: presumably... · da57ad5c
      Jesse Glick 提交于
      [JENKINS-18065] 54c08461 amendment: presumably RunMap.entrySet().iterator().next().setValue(…) should be illegal.
      da57ad5c
    • J
      11bc4ba2
    • K
      54c08461
    • K
      Line up elements in the left side · 8057217f
      Kevin Burke 提交于
      Now you can draw a straight vertical line and see that the logo image, the
      beginning breadcrumb, and the build history are all in a straight line.
      8057217f
  10. 11 7月, 2014 4 次提交
    • K
      [JENKINS-22395] more diagnostics · aa8e0b4f
      Kohsuke Kawaguchi 提交于
      Just in case the previous fix didn't address the root cause of ZD-11985 (and given the time it takes for changes like this to land in LTS), I'm adding additional diagnostics that let us track how previous/next builds are getting discovered
      aa8e0b4f
    • K
      Doc improvements · fe3575c1
      Kohsuke Kawaguchi 提交于
      fe3575c1
    • K
      [FIXED JENKINS-22395] redoing the fix in f1430a25 · b6226ad2
      Kohsuke Kawaguchi 提交于
      Based on the last few commits, I proved that the original fix in f1430a25
      doesn't really address the problem.
      
      That is, once b2 is deleted, and after sufficient garbage collection,
      we can make b2.previousBuild.get() be null, and then
      b2.getPreviousBuild().getNextBuild() ends up incorrectly returning b2.
      
      In this commit, I roll back that part of f1430a25, and then fix the
      problem differently.
      
      I started thinking that the main problem we are trying to fix here
      is that the deleted build object should be unreferenceable. That is,
      it should behave almost as if the object has already been GCed.
      The easiest way to do this is to clear a BuildReference object,
      since we always use the same BuildReference object for all inbound
      references.
      
      This change allows us to clear BuildReference. Code like
      b2.getPreviousBuild() will continue to try to update
      b1.nextBuildR to b2, but it will only end up wiping out the field,
      only to have b1.getNextBuild() recompute the correct value.
      
      This fix makes both test cases pass in LazyBuildMixInTest.
      b6226ad2
    • K
      update to #index must be synchronized · fb47f1d1
      Kohsuke Kawaguchi 提交于
      fb47f1d1
  11. 10 7月, 2014 1 次提交
  12. 09 7月, 2014 1 次提交
    • J
      Failed to diagnose an NPE in 1.554.3. · f2a39b52
      Jesse Glick 提交于
      WARNING: Caught exception evaluating: e.hasStopPermission() in /. Reason: java.lang.NullPointerException
      java.lang.NullPointerException
      	at hudson.model.Executor.hasStopPermission(Executor.java:523)
      f2a39b52