1. 13 7月, 2016 2 次提交
  2. 12 7月, 2016 1 次提交
  3. 08 7月, 2016 1 次提交
  4. 29 6月, 2016 1 次提交
  5. 12 5月, 2016 1 次提交
  6. 09 3月, 2016 2 次提交
    • S
      Jenkins.getInstance() will be @Nonnull in Jenkins 2.0+ · 96150d3a
      Stephen Connolly 提交于
      - Code that is running from a plugin and on the master's JVM is guaranteed to never get null from this method (any cases where you do get null are bugs in core)
      - Code that is running from a plugin and on a remote JVM should never be allowed to load the Jenkins class in their classloader, so should never use Jenkins.getInstance()... we are annotating the method with @Nullable so that such code can have some evolution time
      - Code that is running in core and on one of two special paths should use the Jenkins.getInstanceOrNull() method so that the UI can be presented to users before the singleton has been instantiated / after the singleton has been destroyed
      - The remaining 95% of uses in core (and 100% of uses in plugins) can safely assume that the instance is never null
      96150d3a
    • S
      Revert "Jenkins.getInstance() should be non-null" · d1dfbd2b
      Stephen Connolly 提交于
      This reverts commit bb7c8fce.
      
      Closes #2090, I'll redo this as a PR... though if that PR is subject to multiple rounds of review before being merged then I will take that of evidence of the exact problem that committing directly was supposed to resolve... namely exponentially multiplying the effort required to make actual improvements to the code base.
      d1dfbd2b
  7. 08 3月, 2016 2 次提交
    • S
      Noting that there is a potentially valid argument for allowing this method to... · 6be18080
      Stephen Connolly 提交于
      Noting that there is a potentially valid argument for allowing this method to work without the singleton...
      
      - But the type of tests here would be very restricted in what they could safely do anyway, so they would largely be restricted to verifying data migration during xml loading
      6be18080
    • S
      Jenkins.getInstance() should be non-null · bb7c8fce
      Stephen Connolly 提交于
      - It is never too late to do the right thing.
      - The vast majority of usages of `Jenkins.getInstance()` in core currently assume that its return value is non-null
      - This commit changes those that are written to correctly check for non-null values will call `Jenkins.getInstanceOrNull()`
      - We deprecate the `Jenkins.getActiveInstance()` madness
      - I checked with @kohsuke who said not to bother with a PR and just commit this strongly opinionated change direct to master as a PR will just degrade into a bikeshedding.
      bb7c8fce
  8. 14 11月, 2015 1 次提交
  9. 02 11月, 2015 1 次提交
  10. 28 10月, 2015 1 次提交
  11. 09 10月, 2015 1 次提交
    • C
      [FIXED JENKINS-30502] trim job name upon rename · 89ce85df
      Christopher Simons 提交于
      If a job is renamed to a string with trailing whitespace, exceptions are
      thrown as the application attempts to rename the job directory in the
      file system, and the job can be neither deleted nor renamed again
      through the UI. This problem occurs only when renaming a job, and not
      when initially creating a job, because job names are trimmed when first
      created.  This change trims the job name for rename operations as well,
      so that the name-setting behavior is consistent across create/update
      operations and inadvertent leading/trailing whitespace is removed before
      it can cause problems.
      89ce85df
  12. 02 7月, 2015 1 次提交
  13. 20 4月, 2015 1 次提交
  14. 16 12月, 2014 2 次提交
  15. 07 11月, 2014 1 次提交
  16. 26 9月, 2014 1 次提交
    • J
      Simplifying JSONException handling in doConfigSubmit to use standard (?) error reporting. · c1e8b150
      Jesse Glick 提交于
      Also sending the exception to the log, which is where plugin developers expect to see it.
      (This is also necessary for the exception to be visible say from configRoundtrip in a functional test.
      Otherwise you just see a FailingHttpStatusCodeException due to the 400 error code, with no details.)
      Might actually suffice to just throw a ServletException wrapping the exception up the chain,
      letting Stapler or the container handle it, but this change is more conservative.
      c1e8b150
  17. 24 9月, 2014 1 次提交
  18. 28 8月, 2014 1 次提交
  19. 22 8月, 2014 1 次提交
  20. 13 8月, 2014 1 次提交
  21. 30 7月, 2014 1 次提交
  22. 22 7月, 2014 1 次提交
  23. 10 7月, 2014 1 次提交
  24. 15 6月, 2014 1 次提交
  25. 28 5月, 2014 1 次提交
  26. 15 5月, 2014 1 次提交
  27. 25 3月, 2014 1 次提交
    • J
      Null safety during failing tests (BuildTriggerTest.testMavenBuildTrigger in this case). · fa496c7b
      Jesse Glick 提交于
      java.lang.NullPointerException
      	at hudson.model.Job.getBuildDir(Job.java:790)
      	at hudson.model.Run.getRootDir(Run.java:993)
      	at hudson.model.Run.getLogFile(Run.java:1306)
      	at hudson.model.Run.execute(Run.java:1664)
      	at hudson.maven.MavenBuild.access$900(MavenBuild.java:94)
      	at hudson.maven.MavenBuild$ProxyImpl2.close(MavenBuild.java:636)
      	at hudson.maven.AbstractMavenBuilder.end(AbstractMavenBuilder.java:106)
      	at hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.doRun(MavenModuleSetBuild.java:839)
      	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:523)
      	at hudson.model.Run.execute(Run.java:1688)
      	at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:519)
      	at hudson.model.ResourceController.execute(ResourceController.java:88)
      	at hudson.model.Executor.run(Executor.java:231)
      java.lang.NullPointerException
      	at hudson.model.BuildStepListener.all(BuildStepListener.java:31)
      	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:739)
      	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:714)
      	at hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.cleanUp(MavenModuleSetBuild.java:1054)
      	at hudson.model.Run.execute(Run.java:1733)
      	at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:519)
      	at hudson.model.ResourceController.execute(ResourceController.java:88)
      	at hudson.model.Executor.run(Executor.java:231)
      fa496c7b
  28. 05 3月, 2014 1 次提交
  29. 01 3月, 2014 1 次提交
  30. 09 1月, 2014 1 次提交
  31. 07 1月, 2014 1 次提交
  32. 24 12月, 2013 1 次提交
  33. 12 12月, 2013 1 次提交
  34. 07 12月, 2013 1 次提交
  35. 25 8月, 2013 1 次提交
  36. 02 8月, 2013 1 次提交
    • K
      [FIXED JENKINS-19042] · 6588f429
      Kohsuke Kawaguchi 提交于
      Added a new overloaded version that works on a project.
      
      Updated CoreEnvironmentContributor accordingly.
      6588f429