* [JENKINS-36720]: Fixed Spotbugs issues WMI_WRONG_MAP_ITERATOR and OS_OPEN_STREAM in core

* merged try with resources with try finally

* reverted auto format from IDE

* reverted auto format from IDE

* use Util.fileToPath() as suggested to remove catch block

* merged try statements

* merged try statements

* reverted some whitespace fixes

* reverted another whitespace fix

* Apply suggestions from code review
Co-Authored-By: NOleg Nenashev <o.v.nenashev@gmail.com>

* reverted change

* reverted change

* reverted change
Co-authored-by: NOleg Nenashev <o.v.nenashev@gmail.com>

Remove unused direct dependency commons-codec from Jenkins CLI

* replaced implementation with call to Integer.compare or Long.compare

* Update core/src/main/java/hudson/model/HealthReport.java
Co-Authored-By: NZbynek Konecny <zbynek1729@gmail.com>

* mark compare methods as deprecated
Co-authored-by: NZbynek Konecny <zbynek1729@gmail.com>

removed obsolete SpotBugs suppresses

* JENKINS-60513: Added AtomicInteger to whitelist

* JENKINS-60513: Mark field as transient

* reverted whitelist change

* renamed field to support deserialization of ols values

* refactor exception to actually put the failing string inside instead of null

* do not catch RuntimeExceptions

* Adapt to newer HtmlUnit.

* https://github.com/HtmlUnit/htmlunit/pull/29 seems to have been incompatible.
WebClient.addRequestHeader will no longer override a header in a WebRequest,
such as when the same WebClient/WebRequest was previously used with different headers.

* Tracked down a behavioral change in passing through URL-encoded path characters.
https://github.com/HtmlUnit/htmlunit/commit/2c4956863420e4baef9d3d8c23ec0577ec64d2bf picks up
https://github.com/apache/httpcomponents-client/commit/8c04c6ae5e5ba1432e40684428338ce68431766b which is the actual change.

* jenkins-test-harness 2.58

[JENKINS-59107] User is no longer logged out when authenticating another user

fixed_typos_in_bom/pom.xml

[JENKINS-60351] - Make it possible to disable multiple deletion attempts by setting hudson.Util.maxFileDeletionRetries to zero (#4382)

* [JENKINS-60351] It should be possible to disable a retry of the
PathRemover

This does not address the issues that the comments and code in
hudons.Util are inconsistent if they are for retries or total number of
attempts (they are currently total number of attempts)

* [JENKINS-60351] Make the code conform to the documentation

maxRetries should control the number of retries not the number of
attempts.

* rename field from DELETION_MAX to DELETION_RETRIES

DNS comparisons of jenkins.io and www.jenkins.io do not pass.

Fixed typos in comment on servlet-api version tag

This fixes a regression introduced in SECURITY-901 where performing an authentication check on another user while logged in caused the user to get logged out.
Signed-off-by: NMatt Sicker <boards@gmail.com>

* replaced integer with AtomicInteger to fix spotbugs issue

* added @Restricted to prevent further usage

* replaced volatile with final because of AtomicInteger usage

* implemented a getter and an increment method

* fixed typeo in javadoc

Adding some nullability annotations related to Label

* [JENKINS-59656] when stopping a Run via the executors widget, make sure it's the intended one

* [JENKINS-59656] added Executor.stopBuild(String) instead of .stop(String)

* revert change to deprecated doStop(StaplerRequest,StaplerResponse), useless now that it's doStopBuild(String) which takes a runExtId parameter

* javadoc: "@since TODO" rather than "@since 2.???"

* [JENKINS-59656] added test case

* jelly cleanup with h.urlEncode(String)

* make Functions.urlEncode(null) return empty String

* Executor.doStopBuild(runExtId): ignore runExtId if executable is not a Run

* Executor.doStopBuild(runExtId) doesn't have to be a public API

Minor test code cleanup

[JENKINS-60357] Use XMLUnit to fix test

Adapt some tests to newer Jetty

merged superfluous if with while loop

Co-Authored-By: NZbynek Konecny <zbynek1729@gmail.com>

Fix online example/documentation for File Access Rules