1. 08 3月, 2018 3 次提交
    • L
      [JENKINS-45387] Fix validation error displaying in setup wizard's "create first admin" form (#3116) · 12031d7d
      Literallie 提交于
      * [JENKINS-45387] Improve setup wizard account creation in security realm
      
      This commit adds an additional account creation method to the
      security realm, that allows to create a new user account (as the system)
      and is intended to be used by the setup wizard.
      
      The main difference to the existing method is that the new method does
      not force the Stapler to send a response, but instead throws an
      exception if invalid data is submitted. This allows to call this from
      the setup wizard, and send the response there. (This is necessary
      because the setup wizard method has a response return type and
      there is no way to access the response already send in the realm)
      
      Further, it splits the private createAccount() method for
      clarity as well as to allow code reuse from the new method.
      
      * [JENKINS-45387] Fix SetupWizard sending responses twice on create admin
      
      This commit fixes an issue where the SetupWizard class would send
      two responses (indirectly) when invalid form data was provided for
      creating the first admin account.
      
      * [Fix JENKINS-45387] Setup wizard not displaying first account errors
      
      This commit fixes the setup wizard not displaying HTML error
      responses upon first account creation.
      
      Previously, it just froze (buttons were not re-enabled) and didn't
      display responses. (Probably caused by XSS policies on the iframe)
      
      * [JENKINS-45387] Add some @Restricted annotations
      
      As per
      https://github.com/jenkinsci/jenkins/pull/3116#discussion_r172031063
      https://github.com/jenkinsci/jenkins/pull/3116#discussion_r172051979
      12031d7d
    • D
      Refactor TextFile.lines() (#3211) · 145c606e
      Daniel Trebbien 提交于
      * Refactor TextFile.lines()
      
      Introduces a LinesStream utility class that is responsible for closing
      the underlying file handle.
      
      Switches to calling Files.newBufferedReader() instead of wrapping the
      InputStream returned by Files.newInputStream() in a BufferedReader of
      an InputStreamReader.
      
      Creates the file reader at the time that lines() is invoked, instead of
      at the time that iterator() of the returned Iterable is invoked. This
      can help prevent confusion as to the cause of an exception, whether it's
      because of a problem opening the file or reading from it.
      
      * Delete a duplicate import and a now-unused import
      
      * Introduce load2()
      
      * Add a @Deprecated annotation
      145c606e
    • J
      Merge pull request #3332 from jglick/message-JENKINS-49795 · 93b95104
      Jesse Glick 提交于
      s/JENKINS-49573/JENKINS-49795/g in messages
      93b95104
  2. 07 3月, 2018 4 次提交
  3. 06 3月, 2018 4 次提交
  4. 04 3月, 2018 5 次提交
    • O
      Merge pull request #3322 from suren-jenkins/suren-zh · 6117535d
      Oleg Nenashev 提交于
      Add Chinese translation
      6117535d
    • O
      Merge pull request #3316 from daniel-beck/JENKINS-49642 · 67a61033
      Oleg Nenashev 提交于
      [JENKINS-49642] Fix proxy view recursion
      67a61033
    • P
      [JENKINS-29470] - Prevent NPE in AbstractProject.checkout when agent... · b0c5a86a
      Piush 提交于
      [JENKINS-29470] - Prevent NPE in AbstractProject.checkout when agent disconnects during the build (#3094)
      
      [JENKINS-29470] - Prevent NPE in AbstractProject.checkout when agent disconnects during the build
      b0c5a86a
    • Z
      [JENKINS-43581] - Create new custom tool button should be on top (#2926) · d9e1f383
      Zdeněk Soukup 提交于
      * [JENKINS-43581] Create new custom tool button should be on top
      
      * * [JENKINS-43581] Create new custom tool button should be on top
      
      * * [JENKINS-43581] Create new custom tool button should be on top
      
      * * [JENKINS-43581] Create new custom tool button should be on top
      d9e1f383
    • D
      [JENKINS-22936] Move rename logic to AbstractItem (#3289) · c816f965
      Devin Nusbaum 提交于
      * Move rename infrastructure to a dedicated page at the AbstractItem level
      
      * Preserve existing translations where applicable
      
      * Keep doDoRename method at Job level and remove unneeded compatibility page
      
      * Fix tests
      
      * Fix Javadoc
      
      * Update existing rename tests to use new page
      
      * Update test names for clarity
      
      * Add since tag for newly introduced APIs
      
      * Apply project naming strategy to all renamed items, not just jobs
      
      * Use shorthand accessor
      
      * Clean up Job#doDoRename and deprecate it
      
      * Use new-style web method for doDoRename2
      
      * Remove CheckForNull tag from void method and update Javadoc
      
      * Change names to doConfirmRename and confirm-rename.jelly
      
      * Rename index.jelly to action.jelly and use j:if tag correctly
      
      * Update permission check and remove unused import
      
      * Use new url and update method name in test
      
      * Fix Javadoc
      
      * Fix URL in JobTest
      
      * Update Javadoc for AbstractItem#isNameEditable
      c816f965
  5. 03 3月, 2018 4 次提交
    • JenkinsInChina's avatar
      Add Chinese translation · 7d8dcaad
      JenkinsInChina 提交于
      7d8dcaad
    • D
      hudson.Util improvements (#3226) · 8f512603
      Daniel Trebbien 提交于
      * Organize imports
      
      * Use StandardCharsets
      
      * Delete a redundant cast
      
      * Replace use of _ as an identifier
      
      _ is a keyword in Java 9.
      
      * Use Logger message formatting
      
      * Use fileToPath()
      
      * Switch to using Files.createTempDirectory()
      
      * Document that Util.touch() will truncate an existing file
      
      * Replace an unnecessary use of Throwable.initCause()
      
      * Implement deprecated copyStream() using IOUtils
      
      * Copy to NULL_OUTPUT_STREAM
      
      Also, closing source is moved to a finally block, to guarantee that it
      will be closed per the documentation; it was technically possible for
      the input stream to not be closed if construction of the MessageDigest,
      DigestInputStream, or byte[] buffer failed for some reason (e.g. out of
      memory).
      
      * Delete an unnecessary try-with-resources
      
      * Throw an IllegalArgumentException if data has odd length
      
      Previously, a StringIndexOutOfBoundsException would be thrown, which is
      less clear.
      
      * Specify expanded POSIX file permissions
      8f512603
    • O
      Merge pull request #3277 from uhafner/prototype-1.7.3 · 46510e2d
      Oleg Nenashev 提交于
      [FIXED JENKINS-49319] Upgrade to PrototypeJS 1.7.3
      46510e2d
    • O
      Merge pull request #3312 from jglick/inner-madness-JENKINS-49573 · 29f146c7
      Oleg Nenashev 提交于
      [JENKINS-49795] Fix bad serialization of ParametersAction.parameterDefinitionNames and make sure this kind of mistake produces a warning in the future
      29f146c7
  6. 02 3月, 2018 1 次提交
  7. 28 2月, 2018 6 次提交
  8. 27 2月, 2018 2 次提交
  9. 26 2月, 2018 4 次提交
  10. 24 2月, 2018 7 次提交