提交 fbb2bca3 编写于 作者: K Kohsuke Kawaguchi

Using <f:bottomButtonBar> in more places.

Plus fixing the wrong apply button handling in various code.
上级 b88c996d
......@@ -33,8 +33,10 @@ import hudson.model.listeners.SaveableListener;
import hudson.node_monitors.NodeMonitor;
import hudson.slaves.NodeDescriptor;
import hudson.util.DescribableList;
import hudson.util.FormApply;
import hudson.util.FormValidation;
import jenkins.model.Jenkins;
import org.kohsuke.stapler.HttpResponse;
import org.kohsuke.stapler.QueryParameter;
import org.kohsuke.stapler.StaplerRequest;
import org.kohsuke.stapler.StaplerResponse;
......@@ -315,7 +317,7 @@ public final class ComputerSet extends AbstractModelObject implements Describabl
* Accepts submission from the configuration page.
*/
@RequirePOST
public synchronized void doConfigSubmit( StaplerRequest req, StaplerResponse rsp ) throws IOException, ServletException, FormException {
public synchronized HttpResponse doConfigSubmit( StaplerRequest req) throws IOException, ServletException, FormException {
BulkChange bc = new BulkChange(MONITORS_OWNER);
try {
Jenkins.getInstance().checkPermission(Jenkins.ADMINISTER);
......@@ -334,7 +336,7 @@ public final class ComputerSet extends AbstractModelObject implements Describabl
nm.triggerUpdate();
}
rsp.sendRedirect2(".");
return FormApply.success(".");
} finally {
bc.commit();
}
......
......@@ -54,6 +54,7 @@ import hudson.tasks.BuildWrapper;
import hudson.tasks.BuildStep;
import hudson.tasks.test.AbstractTestResultAction;
import hudson.util.FlushProofOutputStream;
import hudson.util.FormApply;
import hudson.util.IOException2;
import hudson.util.LogTaskListener;
import hudson.util.XStream2;
......@@ -2052,7 +2053,7 @@ public abstract class Run <JobT extends Job<JobT,RunT>,RunT extends Run<JobT,Run
} finally {
bc.abort();
}
return HttpResponses.redirectToDot();
return FormApply.success(".");
}
protected void submit(JSONObject json) throws IOException {
......
......@@ -33,6 +33,7 @@ import hudson.security.ACL;
import hudson.security.AccessControlled;
import hudson.security.Permission;
import hudson.security.SecurityRealm;
import hudson.util.FormApply;
import hudson.util.RunList;
import hudson.util.XStream2;
import jenkins.model.Jenkins;
......@@ -529,7 +530,7 @@ public class User extends AbstractModelObject implements AccessControlled, Descr
save();
rsp.sendRedirect(".");
FormApply.success(".").generateResponse(req,rsp,this);
}
/**
......
......@@ -49,6 +49,7 @@ import hudson.util.AlternativeUiTextProvider;
import hudson.util.AlternativeUiTextProvider.Message;
import hudson.util.DescribableList;
import hudson.util.DescriptorList;
import hudson.util.FormApply;
import hudson.util.IOException2;
import hudson.util.RunList;
import hudson.util.XStream2;
......@@ -902,7 +903,7 @@ public abstract class View extends AbstractModelObject implements AccessControll
save();
rsp.sendRedirect2("../"+name);
FormApply.success("../"+name).generateResponse(req,rsp,this);
}
/**
......
......@@ -42,9 +42,9 @@ THE SOFTWARE.
<!-- main body of the configuration -->
<st:include it="${instance}" page="configure-entries.jelly" />
<f:block>
<f:bottomButtonBar>
<f:submit value="${%Save}"/>
</f:block>
</f:bottomButtonBar>
</f:form>
</l:main-panel>
</l:layout>
......
......@@ -39,9 +39,10 @@ THE SOFTWARE.
descriptors="${it.nodeMonitorDescriptors}"
instances="${it.nonIgnoredMonitors}" />
<f:block>
<f:submit value="OK" />
</f:block>
<f:bottomButtonBar>
<f:submit value="${%OK}" />
<f:apply />
</f:bottomButtonBar>
</f:form>
</l:main-panel>
</l:layout>
......
......@@ -37,9 +37,10 @@ THE SOFTWARE.
</f:entry>
<j:if test="${h.hasPermission(it,it.UPDATE)}">
<f:block>
<f:bottomButtonBar>
<f:submit value="${%Save}" />
</f:block>
<f:apply />
</f:bottomButtonBar>
</j:if>
</f:form>
</l:main-panel>
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册