Suppressing some known-good instances of an idiom otherwise warned about by...

Suppressing some known-good instances of an idiom otherwise warned about by NetBeans plugin for Jenkins.

core/src/main/java/hudson/security/BasicAuthenticationFilter.java

@@ -93,6 +93,7 @@ public class BasicAuthenticationFilter implements Filter {
         servletContext = filterConfig.getServletContext();
     }
 
+    @SuppressWarnings("ACL.impersonate")
     public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException {
         HttpServletRequest req = (HttpServletRequest) request;
         HttpServletResponse rsp = (HttpServletResponse) response;

core/src/main/java/hudson/security/FederatedLoginService.java

@@ -174,6 +174,7 @@ public abstract class FederatedLoginService implements ExtensionPoint {
          *      to the caller of your "doXyz" method, it will either render an error page or initiate
          *      a user registration session (provided that {@link SecurityRealm} supports that.)
          */
+        @SuppressWarnings("ACL.impersonate")
         public User signin() throws UnclaimedIdentityException {
             User u = locateUser();
             if (u!=null) {

core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java

@@ -233,6 +233,7 @@ public class HudsonPrivateSecurityRealm extends AbstractPasswordBasedSecurityRea
     /**
      * Lets the current user silently login as the given user and report back accordingly.
      */
+    @SuppressWarnings("ACL.impersonate")
     private void loginAndTakeBack(StaplerRequest req, StaplerResponse rsp, User u) throws ServletException, IOException {
         // ... and let him login
         Authentication a = new UsernamePasswordAuthenticationToken(u.getId(),req.getParameter("password1"));