Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
LinuxSuRen
jenkins
提交
e6efae7d
J
jenkins
项目概览
LinuxSuRen
/
jenkins
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
J
jenkins
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
e6efae7d
编写于
4月 27, 2016
作者:
D
Daniel Beck
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[SECURITY-276] Better method name, add tests
上级
2ed0c046
变更
5
隐藏空白更改
内联
并排
Showing
5 changed file
with
20 addition
and
6 deletion
+20
-6
core/src/main/java/hudson/Util.java
core/src/main/java/hudson/Util.java
+3
-3
core/src/main/java/hudson/model/DirectoryBrowserSupport.java
core/src/main/java/hudson/model/DirectoryBrowserSupport.java
+1
-1
core/src/main/java/hudson/model/ParametersDefinitionProperty.java
.../main/java/hudson/model/ParametersDefinitionProperty.java
+1
-1
core/src/main/java/hudson/security/AuthenticationProcessingFilter2.java
...java/hudson/security/AuthenticationProcessingFilter2.java
+1
-1
core/src/test/java/hudson/UtilTest.java
core/src/test/java/hudson/UtilTest.java
+14
-0
未找到文件。
core/src/main/java/hudson/Util.java
浏览文件 @
e6efae7d
...
...
@@ -1471,10 +1471,10 @@ public class Util {
}
/**
* Return true iff the parameter d
enotes an absolute URI, or
a scheme-relative URI.
* Return true iff the parameter d
oes not denote an absolute URI and not
a scheme-relative URI.
*/
public
static
boolean
is
AbsoluteOrSchemeRelativeUri
(
@Nonnull
String
uri
)
{
return
isAbsoluteUri
(
uri
)
||
uri
.
startsWith
(
"//"
);
public
static
boolean
is
SafeToRedirectTo
(
@Nonnull
String
uri
)
{
return
!
isAbsoluteUri
(
uri
)
&&
!
uri
.
startsWith
(
"//"
);
}
/**
...
...
core/src/main/java/hudson/model/DirectoryBrowserSupport.java
浏览文件 @
e6efae7d
...
...
@@ -158,7 +158,7 @@ public final class DirectoryBrowserSupport implements HttpResponse {
String
pattern
=
req
.
getParameter
(
"pattern"
);
if
(
pattern
==
null
)
pattern
=
req
.
getParameter
(
"path"
);
// compatibility with Hudson<1.129
if
(
pattern
!=
null
&&
!
Util
.
isAbsoluteOrSchemeRelativeUri
(
pattern
))
{
// avoid open redirect
if
(
pattern
!=
null
&&
Util
.
isSafeToRedirectTo
(
pattern
))
{
// avoid open redirect
rsp
.
sendRedirect2
(
pattern
);
return
;
}
...
...
core/src/main/java/hudson/model/ParametersDefinitionProperty.java
浏览文件 @
e6efae7d
...
...
@@ -158,7 +158,7 @@ public class ParametersDefinitionProperty extends JobProperty<Job<?, ?>>
getJob
(),
delay
.
getTime
(),
new
ParametersAction
(
values
),
new
CauseAction
(
new
Cause
.
UserIdCause
()));
if
(
item
!=
null
)
{
String
url
=
formData
.
optString
(
"redirectTo"
);
if
(
url
==
null
||
Util
.
isAbsoluteOrSchemeRelativeUri
(
url
))
// avoid open redirect
if
(
url
==
null
||
!
Util
.
isSafeToRedirectTo
(
url
))
// avoid open redirect
url
=
req
.
getContextPath
()+
'/'
+
item
.
getUrl
();
rsp
.
sendRedirect
(
formData
.
optInt
(
"statusCode"
,
SC_CREATED
),
url
);
}
else
...
...
core/src/main/java/hudson/security/AuthenticationProcessingFilter2.java
浏览文件 @
e6efae7d
...
...
@@ -53,7 +53,7 @@ public class AuthenticationProcessingFilter2 extends AuthenticationProcessingFil
if
(
targetUrl
==
null
)
return
getDefaultTargetUrl
();
if
(
Util
.
isAbsoluteOrSchemeRelativeUri
(
targetUrl
))
if
(
!
Util
.
isSafeToRedirectTo
(
targetUrl
))
return
"."
;
// avoid open redirect
// URL returned from determineTargetUrl() is resolved against the context path,
...
...
core/src/test/java/hudson/UtilTest.java
浏览文件 @
e6efae7d
...
...
@@ -344,6 +344,20 @@ public class UtilTest {
assertFalse
(
Util
.
isAbsoluteUri
(
"foo/bar"
));
}
@Test
@Issue
(
"SECURITY-276"
)
public
void
testIsSafeToRedirectTo
()
{
assertFalse
(
Util
.
isSafeToRedirectTo
(
"http://foobar/"
));
assertFalse
(
Util
.
isSafeToRedirectTo
(
"mailto:kk@kohsuke.org"
));
assertFalse
(
Util
.
isSafeToRedirectTo
(
"d123://test/"
));
assertFalse
(
Util
.
isSafeToRedirectTo
(
"//google.com"
));
assertTrue
(
Util
.
isSafeToRedirectTo
(
"foo/bar/abc:def"
));
assertTrue
(
Util
.
isSafeToRedirectTo
(
"foo?abc:def"
));
assertTrue
(
Util
.
isSafeToRedirectTo
(
"foo#abc:def"
));
assertTrue
(
Util
.
isSafeToRedirectTo
(
"foo/bar"
));
}
@Test
public
void
loadProperties
()
throws
IOException
{
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录