System read cleanup

core/src/main/resources/hudson/PluginManager/advanced.jelly

@@ -29,14 +29,7 @@ THE SOFTWARE.
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout"
          xmlns:t="/lib/hudson" xmlns:f="/lib/form">
     <l:layout title="${%Update Center}" permission="${app.SYSTEM_READ}">
-      <j:choose>
-        <j:when test="${app.hasPermission(app.ADMINISTER)}">
-          <j:set var="readOnlyMode" value="false" />
-        </j:when>
-        <j:otherwise>
-          <j:set var="readOnlyMode" value="true" />
-        </j:otherwise>
-      </j:choose>
+        <j:set var="readOnlyMode" value="${!app.hasPermission(app.ADMINISTER)}" />
         <st:include page="sidepanel.jelly"/>
         <l:main-panel>
             <local:tabBar page="advanced" xmlns:local="/hudson/PluginManager"/>

core/src/main/resources/hudson/PluginManager/installed.jelly

@@ -28,14 +28,7 @@ THE SOFTWARE.
 <?jelly escape-by-default='true'?>
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:s="/lib/form">
   <l:layout title="${%Update Center}" permission="${app.SYSTEM_READ}">
-    <j:choose>
-      <j:when test="${app.hasPermission(app.ADMINISTER)}">
-        <j:set var="readOnlyMode" value="false" />
-      </j:when>
-      <j:otherwise>
-        <j:set var="readOnlyMode" value="true" />
-      </j:otherwise>
-    </j:choose>
+    <j:set var="readOnlyMode" value="${!app.hasPermission(app.ADMINISTER)}" />
     <st:include page="sidepanel.jelly"/>
     <l:main-panel>
         <st:adjunct includes="hudson.PluginManager._table"/>

core/src/main/resources/hudson/ProxyConfiguration/config.groovy

@@ -3,9 +3,7 @@ package hudson.ProxyConfiguration
 def f=namespace(lib.FormTagLib)
 def l=namespace(lib.LayoutTagLib)
 
-if (!h.hasPermission(app.ADMINISTER)) {
-    set("readOnlyMode", "true")
-}
+set("readOnlyMode", !h.hasPermission(app.ADMINISTER))
 
 f.entry(title:_("Server"),field:"name") {
     f.textbox()

core/src/main/resources/hudson/model/Job/configure.jelly

@@ -29,15 +29,7 @@ THE SOFTWARE.
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:l="/lib/layout" xmlns:f="/lib/form">
 
   <l:layout type="one-column" permission="${it.EXTENDED_READ}" title="${%Config(it.displayName)}">
-
-    <j:choose>
-      <j:when test="${it.hasPermission(it.CONFIGURE)}">
-        <j:set var="readOnlyMode" value="false" />
-      </j:when>
-      <j:otherwise>
-        <j:set var="readOnlyMode" value="true" />
-      </j:otherwise>
-    </j:choose>
+    <j:set var="readOnlyMode" value="${!it.hasPermission(it.CONFIGURE)}" />
 
     <l:js src="jsbundles/config-scrollspy.js" />
     <l:css src="jsbundles/config-scrollspy.css" />

core/src/main/resources/hudson/security/GlobalSecurityConfiguration/index.groovy

@@ -17,9 +17,7 @@ l.layout(permission:app.SYSTEM_READ, title:my.displayName, cssclass:request.getP
             l.icon(class: 'icon-secure icon-xlg')
             text(my.displayName)
         }
-        if (!h.hasPermission(app.ADMINISTER)) {
-            set("readOnlyMode", "true")
-        }
+        set("readOnlyMode", !h.hasPermission(app.ADMINISTER))
 
         p()
         div(class:"behavior-loading", _("LOADING"))

core/src/main/resources/jenkins/tools/GlobalToolConfiguration/index.groovy

@@ -7,11 +7,6 @@ def f=namespace(lib.FormTagLib)
 def l=namespace(lib.LayoutTagLib)
 def st=namespace("jelly:stapler")
 
-
-if (!Functions.hasPermission(app.ADMINISTER)) {
-    set("readOnlyMode", "true")
-}
-
 l.layout(permission:app.SYSTEM_READ, title:my.displayName) {
     l.side_panel {
         l.tasks {
@@ -19,6 +14,7 @@ l.layout(permission:app.SYSTEM_READ, title:my.displayName) {
             l.task(icon:"icon-gear2 icon-md", href:"${rootURL}/manage", title:_("Manage Jenkins"))
         }
     }
+    set("readOnlyMode", !h.hasPermission(app.ADMINISTER))
     l.main_panel {
         h1 {
             l.icon(class: 'icon-setting icon-xlg')